Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add set -e to various bash scripts that we want to error loudly #718

Merged
merged 2 commits into from
May 3, 2021
Merged

build: add set -e to various bash scripts that we want to error loudly #718

merged 2 commits into from
May 3, 2021

Conversation

snario
Copy link
Contributor

@snario snario commented May 1, 2021 •
edited
Loading

Inspired by @tynes' comment 7e6f393#r50244089

@snario snario requested review from karlfloersch and tynes as code owners May 1, 2021 00:24
@changeset-bot
Copy link

changeset-bot bot commented May 1, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: ff9d62e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tynes tynes merged commit b2724d3 into master May 3, 2021
@tynes tynes deleted the liam/set-e branch May 3, 2021 03:20
InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
@snario
build: add set -e to various bash scripts that we want to error loudly (
e401a5c 
ethereum-optimism#718)

* build: add set -e to various bash scripts that we want to error loudly

* build: use sh and remove set -e for geth.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tynes tynes tynes approved these changes

@karlfloersch karlfloersch Awaiting requested review from karlfloersch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snario @tynes