l2geth: docall protect nil block #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8aac154 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gakonst
approved these changes
May 3, 2021
l2geth/internal/ethapi/api.go
Outdated
Comment on lines
938
to
940
| if err != nil { | ||
| return nil, 0, false, err | ||
| } |
There was a problem hiding this comment.
This should still be checked every time, independently of the block not being nil
tynes
force-pushed
the
fix/docall-protect-nil
branch
from
a78e38a to
8aac154
Compare
InoMurko
pushed a commit
to omgnetwork/optimism
that referenced
this pull request
May 25, 2021
* l2geth: protect nil in eth_call * chore: add changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Protects a
nilreference of the block duringeth_call. This is a problem because some of the L2 EVM context is based on L1 values. In particular the block number and timestamp are not the L2 values but instead are the L1 values. Duringeth_call, the correct block number and timestamp must be set. The current approach reads a historical block from the db and pulls out the timestamp and blocknumber from that block. The L1 timestamp and L1 blocknumber are serialized as part of theTransactionMetain the db.