-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from V1 to V2 APIs #7623
Merged
trianglesphere
merged 4 commits into
ethereum-optimism:develop
from
danyalprout:migrate-v2-apis
Oct 12, 2023
Merged
Migrate from V1 to V2 APIs #7623
trianglesphere
merged 4 commits into
ethereum-optimism:develop
from
danyalprout:migrate-v2-apis
Oct 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tynes
reviewed
Oct 11, 2023
tynes
reviewed
Oct 11, 2023
tynes
reviewed
Oct 11, 2023
tynes
reviewed
Oct 11, 2023
trianglesphere
approved these changes
Oct 11, 2023
tynes
approved these changes
Oct 11, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Oct 12, 2023
Merged
via the queue into
ethereum-optimism:develop
with commit Oct 12, 2023
ac2df11
64 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate from the V1 to the V2 APIs for Shanghai support. The V2 APIs in are backwards compat:
Tests
Updated current op-e2e tests to support the V2 methods.
Metadata
This PR is the first part of the work this issue. I'll finish up the P2P changes tomorrow and push a PR for those 🙏