Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temp: remove codechecks #768

Merged
merged 1 commit into from
May 5, 2021
Merged

temp: remove codechecks #768

merged 1 commit into from
May 5, 2021

Conversation

tynes
Copy link
Contributor

@tynes tynes commented May 5, 2021

Description
Temporarily removes codechecks from CI until #767 is fixed
This will allow CI to pass again, the problem is due to a bug in codechecks

@changeset-bot
Copy link

changeset-bot bot commented May 5, 2021

⚠️ No Changeset found

Latest commit: 4a7c545

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@karlfloersch
Copy link
Contributor

@tynes what is the bug in codechecks?

@tynes
Copy link
Contributor Author

tynes commented May 5, 2021

@tynes what is the bug in codechecks?

See codechecks/monorepo#80

karlfloersch
karlfloersch approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@karlfloersch karlfloersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tynes tynes merged commit b90cfb9 into master May 5, 2021
@tynes tynes deleted the fix/temp-remove-codechecks branch May 5, 2021 21:51
@elenadimitrova elenadimitrova mentioned this pull request May 6, 2021
Merged
InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
@tynes
temp: remove codechecks (ethereum-optimism#768)
59467d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlfloersch karlfloersch karlfloersch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tynes @karlfloersch