-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canyon: Blocks V2 P2P & Testing #7707
Canyon: Blocks V2 P2P & Testing #7707
Conversation
baed4a9
to
12aacda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to add a check to
func AttributesMatchBlock(attrs *eth.PayloadAttributes, parentHash common.Hash, block *eth.ExecutionPayload, l log.Logger) error { |
We could even completely disable withdrawals and require them to be empty (but not-nil) for the comment b/c we don't have a need for them. It kinda looks like deposits, but our deposits can do much more than withdrawals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed everything. There's a couple things to look into, but broadly looks good.
87bc918
to
460e898
Compare
460e898
to
76a6573
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TYVM for implementing this
601de6b
Description
P2P changes for this issue.
OP_E2E_USE_CANYON=true
to enable the tests to use Canyon[]
TODO
OP_E2E_USE_CANYON=true