Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[contracts]: Remove verifyExclusionProof #772

Merged
merged 2 commits into from
May 5, 2021

Conversation

smartcontracts
Copy link
Contributor

Description
Removes Lib_MerkleTrie.verifyExclusionProof and the various references to it. We haven't been using this method at all, I don't see why it needs to remain in the codebase.

Metadata

@smartcontracts smartcontracts added A-contracts C-chore Category: Code, docs or tooling maintenance labels May 5, 2021
@changeset-bot
Copy link

changeset-bot bot commented May 5, 2021

🦋 Changeset detected

Latest commit: fcd8d9d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/contracts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2021

Codecov Report

Merging #772 (fcd8d9d) into master (34ab776) will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #772      +/-   ##
==========================================
+ Coverage   77.53%   77.78%   +0.24%     
==========================================
  Files          48       48              
  Lines        1892     1886       -6     
  Branches      297      297              
==========================================
  Hits         1467     1467              
+ Misses        425      419       -6     
Impacted Files Coverage Δ
...imistic-ethereum/libraries/trie/Lib_MerkleTrie.sol 74.88% <ø> (+1.01%) ⬆️
...c-ethereum/libraries/trie/Lib_SecureMerkleTrie.sol 78.57% <ø> (+13.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7d17ca...fcd8d9d. Read the comment docs.

Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚮 🙌

@smartcontracts smartcontracts merged commit d2091d4 into master May 5, 2021
@smartcontracts smartcontracts deleted the fix/remove-verify-exclusion-proof branch May 5, 2021 22:34
InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
* fix[contracts]: Remove verifyExclusionProof

* chore: Add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-chore Category: Code, docs or tooling maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Lib_MerkleTrie.verifyExclusionProof
3 participants