Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op-service: Extract shared method for formatting versions #7805

Merged
merged 1 commit into from
Oct 24, 2023
Merged

op-service: Extract shared method for formatting versions #7805

merged 1 commit into from
Oct 24, 2023

Conversation

ajsutton
Copy link
Contributor

Description

Extract a common FormatVersion method to avoid code duplication.

@ajsutton ajsutton requested review from a team as code owners October 24, 2023 01:15
@ajsutton ajsutton added this pull request to the merge queue Oct 24, 2023
Merged via the queue into develop with commit 6911bdc Oct 24, 2023
60 checks passed
@ajsutton ajsutton deleted the aj/common-version-print branch October 24, 2023 02:09
manjaneqx
manjaneqx reviewed Oct 25, 2023
View reviewed changes
Copy link

@manjaneqx manjaneqx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manjaneqx manjaneqx manjaneqx left review comments

@tynes tynes tynes approved these changes

@felipe-op felipe-op Awaiting requested review from felipe-op felipe-op was automatically assigned from ethereum-optimism/infra-reviewers

@sebastianst sebastianst Awaiting requested review from sebastianst sebastianst is a code owner automatically assigned from ethereum-optimism/go-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajsutton @tynes @manjaneqx