contracts-bedrock: loadAllocs support #8148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are expecting these tests to fail until we have the new |
tynes
commented
Nov 13, 2023
tynes
commented
Nov 13, 2023
tynes
force-pushed
the
ctb/l2-load-allocs
branch
2 times, most recently
from
ab5a18b
to
9ef6889
Compare
tynes
force-pushed
the
ctb/l2-load-allocs
branch
from
b6174b3
to
3be0d00
Compare
|
This error doesn't seem to happen locally, need to figure out why it is failing in CI still |
tynes
force-pushed
the
ctb/l2-load-allocs
branch
3 times, most recently
from
1ab45ac
to
266ba67
Compare
tynes
force-pushed
the
ctb/l2-load-allocs
branch
2 times, most recently
from
825effa
to
256d425
Compare
mslipper
approved these changes
Nov 27, 2023
clabby
approved these changes
Nov 27, 2023
Small tweaks to the L2 contracts tests to make the new method of setting up the L2 state work. This depends on the latest build of `ci-builder` and updating the foundry version in #8144.
auto-merge was automatically disabled
November 27, 2023 20:17
Pull Request is not mergeable
tynes
force-pushed
the
ctb/l2-load-allocs
branch
from
23c4dca
to
f58cb3a
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #8148 +/- ##
===========================================
+ Coverage 40.88% 40.93% +0.04%
===========================================
Files 162 162
Lines 6048 6048
Branches 970 970
===========================================
+ Hits 2473 2476 +3
+ Misses 3501 3496 -5
- Partials 74 76 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small tweaks to the L2 contracts tests to make the
new method of setting up the L2 state work. This depends
on the latest build of
ci-builderand updating thefoundry version in #8144.