Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration-tests: Add coverage for eth_call out-of-gas messages #839

Merged
merged 1 commit into from
May 11, 2021

Conversation

ben-chain
Copy link
Collaborator

Description
Just adding more RPC coverage to prevent future regressions!

Metadata

  • Fixes OP-357

@ben-chain ben-chain requested a review from tynes as a code owner May 11, 2021 05:39
@changeset-bot
Copy link

changeset-bot bot commented May 11, 2021

⚠️ No Changeset found

Latest commit: ea894af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2021

Codecov Report

Merging #839 (ea894af) into master (c949803) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #839   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files          48       48           
  Lines        1895     1895           
  Branches      303      303           
=======================================
  Hits         1558     1558           
  Misses        337      337           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c949803...ea894af. Read the comment docs.

@ben-chain ben-chain force-pushed the test/eth_call-OOG branch from 8517f12 to ea894af Compare May 11, 2021 05:52
@gakonst gakonst merged commit 52d9e6b into master May 11, 2021
@gakonst gakonst deleted the test/eth_call-OOG branch May 11, 2021 10:17
smartcontracts added a commit that referenced this pull request May 12, 2021
* docs: add truffle example

* fix: add gasPrice: 0 to all ctc calls and deploys

* chore(truffle-example): use correct truffle command

* fix: install missing packages

* style: fix missing newlines

* fix: attempt to fix yarn.lock (2)

* Update integration.yml

* specify truffle config and network

* correctly specify path and version

* relayer: logging cleanup (#807)

* relayer: don't log options at startup

* chore: add changeset

* relayer: log specifc config options

* config: message relayer (#809)

* relayer: migrate towards prefixed config w/ backwards compat

* chore: update relayer config parsing

* env: use start-offset instead of block offset

* lint: fix

* deps: add bcfg

* message-relayer: cleaner config parsing

* lint: fix

* Version Packages (#833)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix: geth miner timestamp bug (#836)

* l2geth: use correct timestamp protection

* chore: add changeset

* Version Packages (#837)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* style: require curly braces for if statements (#835)

* test[integration-tests]: l2geth call and creation OOG (#839)

* fix: WE DID IT

Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com>
Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: ben-chain <ben@pseudonym.party>
InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
* docs: add truffle example

* fix: add gasPrice: 0 to all ctc calls and deploys

* chore(truffle-example): use correct truffle command

* fix: install missing packages

* style: fix missing newlines

* fix: attempt to fix yarn.lock (2)

* Update integration.yml

* specify truffle config and network

* correctly specify path and version

* relayer: logging cleanup (ethereum-optimism#807)

* relayer: don't log options at startup

* chore: add changeset

* relayer: log specifc config options

* config: message relayer (ethereum-optimism#809)

* relayer: migrate towards prefixed config w/ backwards compat

* chore: update relayer config parsing

* env: use start-offset instead of block offset

* lint: fix

* deps: add bcfg

* message-relayer: cleaner config parsing

* lint: fix

* Version Packages (ethereum-optimism#833)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix: geth miner timestamp bug (ethereum-optimism#836)

* l2geth: use correct timestamp protection

* chore: add changeset

* Version Packages (ethereum-optimism#837)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* style: require curly braces for if statements (ethereum-optimism#835)

* test[integration-tests]: l2geth call and creation OOG (ethereum-optimism#839)

* fix: WE DID IT

Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com>
Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: ben-chain <ben@pseudonym.party>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants