optimism: bump gaslimit to 10 million #870 #871

tynes · 2021-05-13T21:34:08Z

Description
This PR bumps the protocol level gasLimit to 10 million. This is the maximum amount of gas that a single transaction can consume. This number shouldn't grow too large relative to the amount of gas consumed by a block. If the gas consumed by a single transaction on Optimism consumes more gas than what can be fit into an L1 block, then it will not be possible to execute the fraud proof based on the current construction.

Additional context
I believe that these are the only 2 places required to be changed. There is also a gasLimit in the CTC for enqueue transactions that is configured separately and an open PR for removing the need to configure the gasLimit as part of the state dump process. See #840

This PR along with Cached Safety Checking will make contract deployment much better.
For historical info on cached safety checking, see:

changeset-bot · 2021-05-13T21:34:11Z

⚠️ No Changeset found

Latest commit: 51e92cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Forgot something

smartcontracts · 2021-05-13T22:17:21Z

Following lines should be updated as well:

optimism/packages/contracts/tasks/deploy.ts

Line 8 in 0c16805

const DEFAULT_CTC_MAX_TRANSACTION_GAS_LIMIT = 9_000_000
optimism/packages/contracts/tasks/deploy.ts

Line 10 in 0c16805

const DEFAULT_EM_MAX_TRANSACTION_GAS_LIMIT = 9_000_000

Following lines might need to be updated:

optimism/l2geth/scripts/start.sh

Line 9 in 0c16805

TARGET_GAS_LIMIT=9000000
https://github.com/ethereum-optimism/optimism/blob/develop/specs/l2geth/sequencer/fees.md#L63

tynes · 2021-05-13T22:30:16Z

cc @smartcontracts

optimism/packages/data-transport-layer/src/utils/constants.ts

Line 1 in 8d67991

    
           export const SEQUENCER_GAS_LIMIT = 8_000_000 // TODO: Remove and use value from event.

tynes · 2021-05-13T22:31:11Z

Is there any way that we can deduplicate some of these?

elenadimitrova · 2021-05-14T09:47:38Z

packages/contracts/src/contract-dumps.ts

@@ -115,7 +115,7 @@ export const makeStateDump = async (cfg: RollupDeployConfig): Promise<any> => {
    deploymentSigner: signer,
    ovmGasMeteringConfig: {
      minTransactionGasLimit: 0,
-      maxTransactionGasLimit: 9_000_000,
+      maxTransactionGasLimit: 10_000_000,


Since we've upped the maxTransactionGasLimit in EM we might want to up the L2_GAS_DISCOUNT_DIVISOR as well as now the burned gas will be higher for txs sent with a default gas limit. Or at least we could make a note to consider this as part of the work in #762

Is it ok if we handle that in #762?

elenadimitrova · 2021-05-14T09:50:36Z

ops/envs/geth.env

@@ -29,5 +29,5 @@ IPC_DISABLE=true
 NETWORK_ID=420
 NO_USB=true
 NO_DISCOVER=true
-TARGET_GAS_LIMIT=9000000
+TARGET_GAS_LIMIT=10000000


Just a question on how the update to ExecutionManager.maxTransactionGasLimit was done here since I am reading maxTransactionGasLimit being stored in slot 2 not 4. What am I missing?

We spoke out of band and have agreed that the slot is 4, see #840

tynes · 2021-05-17T17:29:58Z

I've rebased and updated the instances of 9 million to 10 million.

Is there any way that we can deduplicate some of these?

Leaving the above comment for future work, but we should really be able to have a single source of truth that is used throughout the rest of the system

platocrat · 2021-05-17T22:58:04Z

@tynes what's preventing this from being merged?

maurelian · 2021-05-18T00:16:06Z

I don't see it mentioned, but assume that this change is due to the recent L1 block gas limit increasing to 15 million.
Do we have a rule of thumb or other means for determining the safe L2 gas limit?

tynes · 2021-05-18T16:47:25Z

I don't see it mentioned, but assume that this change is due to the recent L1 block gas limit increasing to 15 million.
Do we have a rule of thumb or other means for determining the safe L2 gas limit?

This change is due to the increase in L1 block gas limit as well as the large gas overhead that causes projects to have to refactor their code to be able to deploy on Optimism. The larger that our gas limit is, the more risky it becomes when executing a fraud proof because it will require a larger percentage of the total block's gas and it must fit within a single block.

We should be generally cautious around raising the gas limit and reserve the right to lower it in the future if we feel like we need to. A fix to the sequencer entrypoint where it introduces less overhead would let us safely decrease the gas limit.

This particular raise of the gas limit allows uniswap v3 to be deployed without refactoring of the contracts.

snario · 2021-05-19T12:59:46Z

This needs to re-target regenesis/0.4.0.

* optimism: bump gaslimit to 10million * chore: add changeset * optimism: bump max gaslimit to 10 mil * chore: add changeset * chore: remove unnecessary changeset * chore: remove unnecessary changeset Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>

* chore: reduce hardhat timeout to 20 seconds (ethereum-optimism#968) * fix: force LF line endings for scripts to avoid docker problems on Windows (ethereum-optimism#974) * fix: use correct line endings for windows * chore: add changeset * refactor[contracts]: Turn ExecutionManagerWrapper into a predeployed contract (ethereum-optimism#808) * wip: Started working on L2 contract testing revamp * test: clean tests for ProxyEOA * style: clean imports for ProxyEOA tests * test: port tests for ECDSAContractAccount * fix tests and add wrapper to dump * fix: add em wrapper to l2 deploy * ffix: add comments to wrapper contract * fix: add more comments * fix: add smock comment for unbind * Update packages/smock/src/smockit/binding.ts * maintenance[contracts]: use dashes in chain container names (ethereum-optimism#819) * maintenance: use dashes in chain container names * chore: add changeset * feat[contracts]: temporarily disable EOA upgrades (ethereum-optimism#857) * feat[contracts]: disable eoa upgrades temporarily * chore: add changeset * Update OVM_ProxyEOA.sol * fix: turn upgrade into a noop * lint: fix * feat[contracts]: Update Lib_AddressManager.AddressSet event to speed up data transport layer (ethereum-optimism#820) * feat: update and improve AddressSet event * chore: add changeset * Update Lib_AddressManager.sol * Reduce gas costs of deposits (ethereum-optimism#667) * Remove messageNonce from BaseCrossDomainMessenger and use CTC queue lenght instead Remove Abs_BaseCrossDomainMessenger and restore dedicated nonce generation in OVM_L2CrossDomainMessenger Fix typo * Remove sentMessages mapping from L1CrossDomainMessenger storage and use the nonce to check for existence of replayed transaction * Refactor out common library function for getting cross domain calldata * Post rebase fixes * Use the queueIndex to check the transaction was enqueued * Fix tests for L1CrossDomainMessenger.replayMessage Also make that test work with an actual CanonicalTransactionChain implementation rather than a smock * Lint fixes * Optimise the resolve calls into the AddressManager lib * Rename the nonce parameter to be clear * Update test name Co-authored-by: ben-chain <ben@pseudonym.party> * Rename getXDomainCalldata to encodeXDomainCalldata to match the new Lib_CrossDomainUtils Co-authored-by: ben-chain <ben@pseudonym.party> * optimism: bump gaslimit to 10 million ethereum-optimism#870 (ethereum-optimism#871) * optimism: bump gaslimit to 10million * chore: add changeset * optimism: bump max gaslimit to 10 mil * chore: add changeset * chore: remove unnecessary changeset * chore: remove unnecessary changeset Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * fix: use correct contract name in tests (ethereum-optimism#921) * fix: disable upgradability from ECDSA Account (ethereum-optimism#885) * l2geth: remove `SignatureHashType` (ethereum-optimism#752) * l2geth: remove tx type * l2geth: no longer parse type in rollup client * chore: add changeset * chore: remove extra sighash params * fix: do not check txtype in integration tests Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * feat[contracts]: introduce OVM_GasPriceOracle (ethereum-optimism#912) * feat[contracts]: congestion price oracle * chore: add changeset * contracts: gas price oracle (ethereum-optimism#917) * contracts: gas price oracle * tests: update * fees: fix tests * contracts: simplify gas price oracle * lint: fix * test: execution price is at the 1st storage slot * chore: rename predeploy to GasPriceOracle * chore: rename gas price oracle test name Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * fix: configure max gas limit to 11m (ethereum-optimism#928) Uniswap V3 contracts require that, otherwise they throw call exceptions at deployment * Consolidate Predeploy Addresses (ethereum-optimism#931) * added library for predeploy addresses * refactor tests and other packages to use exported predeploys * revert library usage in OVM_ECDSAContractAccount * lint * added newline * fixed address typos Co-authored-by: rajivpo <rajivpatel-oconnor@Rajivs-MacBook-Pro-2.local> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * chore: remove yarn-error.log and gitignore it (ethereum-optimism#956) * feat[contracts]: Replace Lib_RingBuffer with a much simpler Lib_Buffer (ethereum-optimism#821) * feat[contracts]: replace Lib_RingBuffer with a simpler Lib_Buffer * chore: changeset * test: add tests for Lib_Buffer * lint: fix * test: add extra coverage for Lib_Buffer * Update packages/contracts/contracts/optimistic-ethereum/libraries/utils/Lib_Buffer.sol Co-authored-by: ben-chain <ben@pseudonym.party> * add some extra comments Co-authored-by: ben-chain <ben@pseudonym.party> * fix(contracts): import predeploys (ethereum-optimism#982) * fix(contracts): import predeploys * fix: lint * feat: add hardhat deploy instructions to readme (ethereum-optimism#965) * feat: add deployment instructions to readme * Add changeset * fix style * Update README.md * feat: fees v2 (ethereum-optimism#976) * l2 geth: new fee logic * l2 geth: migrate to fees package * core-utils: new fee scheme * chore: add changeset * l2geth: delete dead code * integration-tests: fix typo * integration-tests: fixes * fees: use fee scalar * lint: fix * rollup: correct gas payment comparison * fix(integration-tests): do not hardcode gas price * core-utils: update with new scheme * l2geth: refactor rollup oracle * l2geth: clean up DoEstimateGas * l2geth: implement latest scheme * tests: fix up * lint: fix * l2geth: better sycn service test * optimism: rename to TxGasLimit * fee: fix docstring * tests: fix * variables: rename * l2geth: prevent users from sending txs with too high of a fee * integration-tests: fix import * integration-tests: fix type * integration-tests: fix gas limits * lint: fix * l2geth: log error Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * Add static analysis action (ethereum-optimism#848) * Add static analysis github action setup python and install slither * Add nvmrc file for setting node to v14.17 * Update slither command run to link missing contract packages from monorepo root * Add steps for installing dependencies * Add yarn build step to github action * Enable colour in github action for static analysis * Disable certain detectors * Ensure slither does not fail build * Add instructions on running static analysis to monorepo readme * build(deps): bump ws from 7.4.4 to 7.4.6 in /ops/docker/hardhat (ethereum-optimism#987) Bumps [ws](https://github.com/websockets/ws) from 7.4.4 to 7.4.6. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@7.4.4...7.4.6) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix[l2geth]: fix accidental merge conflict (ethereum-optimism#994) * feat[message-relayer]: relay tx generator (ethereum-optimism#952) * feat[message-relayer]: relay tx generator * whoops, I burned our infura key * fix minor bug * add comments * add more comments and clean stuff up * add empty test descriptions * add tests * move smock to dev deps * chore: add changeset * minor cleanup to merkle tree proof function * use bignumber math to avoid nested await * use a better interface * minor fixes and simplifications * backwards compatible dtl syncing (ethereum-optimism#986) * kovan: fix attempt * kovan: db fix * kovan: types are strings from db * l2geth: parse things as strings * chore: add changeset * dtl: also stringify the range query * geth: dereference * geth: assign err * dtl: handle null * dtl: fix unit tests * fix[smock]: fix broken call assertions for overloaded functions (ethereum-optimism#996) * fix[smock]: fix broken call assertions for overloaded functions * chore: add changeset * minor correction and add a test * add a test for non-overloaded functions * fix[message-relayer]: fix failing test because of merge with develop (ethereum-optimism#1000) * fix[message-relayer]: remove spreadsheet mode (ethereum-optimism#998) * fix[message-relayer]: remove spreadsheet mode * chore: add changeset * Lower local rollup timestamp refresh (ethereum-optimism#985) * update rollup timestamp refresh * increase refresh time to 5s * feat: fees v3 (ethereum-optimism#999) * core-utils: fee impl v3 * l2geth: fees v3 impl * integration-tests: update for fees v3 * chore: add changeset * fix: typo * integration-tests: fix and generalize * fees: update fee scalar * l2geth: check gas in the mempool behind usingovm * tests: fix up * l2geth: remove dead var * truffle: fix config * fix: remove dead coders (ethereum-optimism#1001) * chore: delete dead coders * chore: add changeset * dtl: remove dead imports * core-utils: delete dead tests * batch-submitter: remove txtype * chore: add changeset * docs[message-relayer]: add a README and improve the interface for generating proofs (ethereum-optimism#1002) * docs[message-relayer]: add basic docs and clean up an interface * chore: add changeset * dtl: log error stack for failed http request (ethereum-optimism#995) * dtl: log error stack for failed http request * chore: add changeset * Add rpc-proxy service for whitelisting JSON RPC methods to the sequencer. (ethereum-optimism#945) * Add healthcheck endpoint for rpc-proxy Added ethereum-nginx-proxy source updated README and docker image build * Check ETH_CALLS_ALLOWED is set, clean up comments, remove old Dockerfile * Pass additional information across domains via token gateways (ethereum-optimism#824) * feat(contracts): add from and data args to L1ERC20Gateway fix(integration): add gasLimit to fundUser refactor(contracts): add data to gateway events add changeset fix(integration): provide data in outboundTransfer refactor(contracts): reset Abs_L2TokenGateway to Abs_L2DepositedToken refactor(contracts): fix mismatched names * feat[contracts]: add custom gas arg to gateway fix(contracts): take max of user vs. default gas * fix(integrations): update ovm-eth function call * fix(integration): remove unecessary explicit gasLimit * test(contracts): 32kb transfer, 9MM gas * fix(contracts): fixup comment, bytes arg last * fix(integration): args order in integrations * fix(contracts): remove unused L2 gas arg * fix(contracts): limit data that can be passed to L2 * fix(integration): better tests for data length * test: check for error on too large data * Experimental: specify gaslimit in before hook * fix(integration): add l2 gas argument * fix: increase gas on fundUser * fix(contracts): remove duplicate max size limit * fix(integration): fine tune gas amounts * lint * fix: large data test * fix(integration): set gas closer to real cost * fix(contracts): remove unused bridge variables These variables were the default gas amounts for cross domain messages * fix(contracts): Reorder args Place dynamic length args last * fix(integration): update estimateGas values * fix(integration): reset eth withdraw estimate to 21000 * fix(integration): update expected gas amount * fix(integration): reduce gas amount for ETH withdraw * More consistent style for Constant values (ethereum-optimism#991) * chore(contracts): make container addresses be constants chore(contracts): consistent style for constant vars * chore(contracts): add internal on predeploy constants * feat: deployment config for fee oracle contract (ethereum-optimism#936) * feat[contracts]: add GasPriceOracle w/o predeploy Based on ethereum-optimism#912 * feat[contracts]: congestion price oracle * chore: add changeset * contracts: gas price oracle (ethereum-optimism#917) * contracts: gas price oracle * tests: update * fees: fix tests * contracts: simplify gas price oracle * lint: fix * test: execution price is at the 1st storage slot * chore: rename predeploy to GasPriceOracle * chore: rename gas price oracle test name Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * Add an L2 deploy script for gas oracle contract * Add a kovan deployment artifact * Add deployment to readme * Add extra validation & initial execution price * Update README.md * Fix execution price logic * Perform new deployment with final contract * contracts: better require in ovm gas price oracle * Deploy L2GasPriceOracle * Update contract to use new fee logic & rename to gas * Deploy updated contract * Fix lint * gas price oracle: do not restrict gas price * gas price oracle: new deployment * tests: delete dead test Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * ops: expose debug namespace (ethereum-optimism#1007) * develop merge fixes * refactor[l2geth]: queue origin type (ethereum-optimism#975) * refactor: queueOrigin type * Convert queueOrigin to uint8 in encode * Add changeset * Regenerate json marshall * style: combine lines * Add Stringer for QueueOrigin * Turn QueueOrigin into uint8 * l2geth: gen tx meta fix * l2geth: gen tx meta fix * lint Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> * fix(sync-service): prevent underflows (ethereum-optimism#1015) * fix(sync-service): prevent underflows * chore: add changeset * chore: remove dead confirmation depth * chore: remove eth1conf depth from rollup config * test: remove duplicate value in array (ethereum-optimism#1014) * ci: tag docker image for canary with abbreviated GITHUB_SHA (ethereum-optimism#1006) * ci: tag docker image for canary with abbreviated GITHUB_SHA * ci: update from 6 bytes to 8 bytes of abbreviation * refactor: improve logging for transactions being submitted to chain with gasPrice (ethereum-optimism#1016) * refactor: improve logging for transactions being submitted to chain with gasPrice * lint: apply lint autofixes * dtl: remove stringify from db logic + more overflow protection (ethereum-optimism#1010) * dtl: remove stringify from db logic * l2geth: overflow protection * dtl: overflow protection * chore: add changeset * ci: upload logs for failed integration tests (ethereum-optimism#1020) * fix(dtl): improve slow blocking JSON parsing that occurs during l2 sync (ethereum-optimism#1019) The use of eth_getBlockRange returns a large response which is very slow to parse in ethersjs, and can block the event loop for upwards of multiple seconds. When this happens, incoming http requests will likely timeout and fail. Instead, we will parse the incoming http stream directly with the bfj package, which yields the event loop periodically so that we don't fail to serve requests. * fix: lint errors in dtl (ethereum-optimism#1025) * fix[dtl]: fix dtl bug breaking verifiers (ethereum-optimism#1011) * fix[dtl]: fix dtl bug breaking verifiers * tweaks so tests pass * chore: add changeset * fix: deterministic blockhashes (ethereum-optimism#1032) * config: set etherbase * l2geth: add deterministic clique key * l2geth: default value * chore: add changeset * test: add sync test for deterministic blockhash Co-authored-by: Kevin Ho <kevinjho1996@gmail.com> * Version Packages (ethereum-optimism#978) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * ci: add sync test's own workflow (ethereum-optimism#1031) * fix(dtl): incorrect parsing of eth_getBlockRange result (ethereum-optimism#1037) * Version Packages (ethereum-optimism#1045) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: no gas refund (ethereum-optimism#1043) * l2geth: remove the gas refund * chore: add changeset * refactor[contracts]: remove one-off GasPriceOracle deployment file (ethereum-optimism#1046) * refactor[contracts]: remove one-off gpo deployment * chore: add changeset * feat[contracts]: introduce new L1ChugSplashProxy contract (ethereum-optimism#1009) * feat[contracts]: add L1ChugSplashProxy * improve comments slightly * start adding tests * add more tests * make the system pausable * added another test * add some extra comments * Update packages/contracts/test/contracts/chugsplash/L1ChugSplashProxy.spec.ts Co-authored-by: Maurelian <maurelian@protonmail.ch> * Update packages/contracts/test/contracts/chugsplash/L1ChugSplashProxy.spec.ts Co-authored-by: Maurelian <maurelian@protonmail.ch> * chore: add changeset * address review feedback Co-authored-by: Maurelian <maurelian@protonmail.ch> * feat[contracts]: add sequencer fee wallet (ethereum-optimism#1029) * wip: first draft of the fee wallet * add fee wallet to dump * rename to sequencer vault * add L1 fee wallet to geth config * add unit tests * fix geth linting error * add a basic integration test * fix broken integration test * add test for correct storage slot * add integration test for fee withdrawal * fix typo in integration tests * fix a bug bin integration tests * Update OVM_SequencerFeeVault.sol * fix bug in contract tests * chore: add changeset * fix bug in contract tests * build(deps): bump glob-parent from 5.1.1 to 5.1.2 (ethereum-optimism#1036) Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2. - [Release notes](https://github.com/gulpjs/glob-parent/releases) - [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md) - [Commits](gulpjs/glob-parent@v5.1.1...v5.1.2) --- updated-dependencies: - dependency-name: glob-parent dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: Liam Horne <liam@lihorne.com> * fix: predeploy gasprice oracle (ethereum-optimism#1039) * l2geth: delete extra config options * l2geth: stop using extra config options * l2geth: more stop using extra config options * chore: add changeset * l2geth: add new config for gpo owner * chore: add changeset * l2geth: fix tests * tests: fix build * l2geth: optimize loops (ethereum-optimism#1027) * l2geth: optimize loops * l2geth: stop ticker when done * l2geth: don't wait for first tick * chore: add changeset * Enable custom tagging of release docker image (ethereum-optimism#1048) * ci: enable custom tagging of release docker image * ci: refactor to add prerelease prefix for secuirty * doc: typo * ci: fix indentation issue of canary workflow * ci: fix typo with GITHUB_SHA * fix: typo in USE_HARDHAT config (ethereum-optimism#1023) * fix: abi encoded tx (ethereum-optimism#1049) * contracts: don't double rlp decode * chore: add changeset * lint: fix * deps: update * linting: cleanup * feat: contracts: use selector * fix: contracts: use typescript * contracts: use interface * l2geth: bump to go 1.15 (ethereum-optimism#1058) * l2geth: bump to go 1.15 * chore: add changeset * Change monotonicity band-aid code to log warnings not errors (ethereum-optimism#1060) * refactor: change monotonicity band-aid code to log warnings not errors * build: add changeset * feat(contracts, l2geth): native ETH value support for ovmCALL (ethereum-optimism#1038) * feat(contracts): add ovmCALL-types with native value * add ovmCALLVALUE context * add ovmBALANCE * test success and revert cases * test empty contract case * chore: lint * test(integration-tests): ovmCALL-types with value (compiler and wrapper) * fix ovmDELEGATECALL type, update tests * add ovmSELFBALANCE * fix ovmDELEGATECALL jumping to CALL * chore: lint * fix(contracts): account for intrinsic gas of OVM_ETH sends * fix(contracts): merge conflict bug * fix(contracts): update gas benchmark * feat(contracts, integration-tests): use new value-compatible compiler * feat(contracts,l2geth): support value calls in OVM_ECDSAContractAccount * fix(contracts): ovmDELEGATECALL does not change message context * feat(contracts): sending value between EOAs * test(integration-tests): ovmDELEGATECALL preserves ovmCALLVALUE * test(integration-tests): assert ovmSELFBALANCEs correct * test(integration-tests): intrinsic gas for eth value calls * test(integration-tests): update gas values * chore(contracts): lint * feat(contracts, l2geth): eth_calls with nonzero value * chore: minor fixups and comments based on PR feedback * test(integration-tests): add requested tests from PR reviews * test(integration-tests): ovmSELFBALANCE is preserved in ovmDELEGATECALLs * fix(contracts): fix bug where ovmDELEGATECALL could fail if balance was lower than the ovmCALLVALUE * chore: add changeset * fix(contracts): update intrinsic gas for worst-case value sends * chore: address final PR nits/improvements Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> * Add erc1271 support to contract account (ethereum-optimism#1052) * add ERC1271 support, failing unit tests * add integration test for isValidSignature * remove .only * lint * add changeset * clean up 1271 tests and lint * switch back to using waffle wallet * lint * fix import * feat[contracts]: slightly better account funding for hardhat accounts (rebased) (ethereum-optimism#1065) * feat[contracts]: better account funding for hardhat accounts * add a sleep to avoid any potential problems * chore: add changeset * fix: bug with gas estimation in funding step * fix: limit to 20 accounts max Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> * Ensure Sentry is correctly set up for DTL and MR (ethereum-optimism#1054) * refactor: add logger and metrics to options for BaseService * refactor: thread sentryOptions through from message-relayer into BaseService * refactor: ensure DTL Logger is using Sentry for errors * style: lint base-service.ts * refactor: init Sentry on batch-submitter too * refactor: init Sentry on message-relayer too * refactor: pass in basic logger to MessageRelayerService * build: provide changeset * fix: correct usage of use-sentry boolean config * refactor: appropriately type loggingOptions * build: add @sentry/node * build: add @sentry/node to message-relayer and fix linting issue * Add more logging information to monotonicity violation logs (ethereum-optimism#1066) * refactor: log idx of monotonicity violation from batch * build: add changeset * temporarily disable hardhat example tests (ethereum-optimism#1071) * fix: monotonicity auto healer (ethereum-optimism#1070) * fix: monotonicity auto healer * add: changeset * Version Packages (ethereum-optimism#1053) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Standard token bridge (ethereum-optimism#988) * Remove abstract token gateway and deposited token implementations * Further simplification of bridge contracts * Standart token bridge and L2 token implementation * Fix spacing * Implement case when a bad deposit happens to a nonexistent L1<>L2 token pair * Use SafeMath in common token bridge accounting * test(contracts): fix finalizeWithdrawal test * fix(contracts): use SafeERC20 on token deposits * Rename OVM_L1ERC20Gateway to OVM_L1ERC20Bridge contract * Rename iOVM_L1ERC20Gateway to iOVM_L1ERC20Bridge contract * Cleanup gateway to bridge rename * Better name for the mapping holding l1->l2 deposit amounts * Use OZ SafeMath * Rename local variables in OVM_L2DepositedERC20 from gateway to bridge * Merge ETH and ERC20 bridge contracts * Rename OVM_L1ERC20Bridge to OVM_L1StandardBridge and fix tests from merging the ETH and ERC20 bridges * Better name for iAbs_BaseCrossDomainMessenger -> iOVM_CrossDomainMessenger * Correct the bounce back of deposit sender and recipient properties * Remove obsoleted event from OVM_L2DepositedERC20 * chore(contracts): change references from ETHGateway to Bridge * Fix a linting error * fix(contracts): add bridge to deployer * Split off ERC20Bridge interface for the purposes of being reused in custom ERC20 bridges * Split off interface natspec definitions * Draft version of OVM_L2DepositedERC20 splitted into a standard L2 erc20: L2StandardERC20 and a common L2 bridge: OVM_L2StandardBridge * style(contracts): define L1_ETH_ADDRESS as constant * test(integration): update interface to use depositETH * test(contracts): fix OVM_L1StandardBridge tests * test(contracts): fix L2 Standard Bridge tests * test(contracts): lint and remove an obsolete test case * Fix modifier check to comply with the L2 bridge distinction from L2 token * Simplify address <> interface casting in bridges * Ensure natspec comments are correct also add l1 and l2 token params to WithdrawalInitiated event for consistency * Fix issues in L1 and L2 bridges to ensure cross domain messages are sent only between the two bridges also adjusted withdrawals to send to either finalizeETHWithdrawal or finalizeERC20Withdrawal depending on which asset is being withdrawn * Remove AddressManager from the L1 standard bridge * REVERT ME: instruments cross domain enabled * fix(contracts): remove Address Manager from L1 Bridge * feat(contracts): make L2 Standard Bridge a predeploy * WIP: update deployments for standard bridges * WIP: update deployments for standard bridges * l2geth: TEMP log contract calls * chore(l2geth): replace eth gateway with standard bridge * fix(contracts): make contract-deployment/config work * WIP fix(integration): update integration tests for bridge * Remove ovmEth from L1 Standard bridge as obsoleted * Separate ERC20 standard implementation from L2 bridge * Formatting fixes * chore(l2geth): replace eth gateway with standard bridge * Revert "REVERT ME: instruments cross domain enabled" This reverts commit d5bb8f8. * fix: lint ts * Implement EIP-165 in the Standard L2 ERC20 token Also switch that to be based off the OpenZeppelin default implementation plus mint and burn Additionally remove the obsoleted iOVM_ERC20 * fix(contracts): add deployment check on bridge proxy fix(contracts): whitespace fix(contracts): init bridge implementation with non-zero address * Remove dependency on Ownable contract for the StandardERC20 token on L2 * fix(contracts): update deployment scripts * fix: lint * remove debugging code * fix: correct rpc get balance slot * restore l2 cross domain messenger * fix: lint * Add a test for a non compliant token deposit * Only allow EOAs to deposit ETH and ERC20 * Add comments and tests for ERC165 implementation * Decide against using explicit ETH MOCK address as we're not using it for checks * Fix linting issues * Add onlyEOAContract restriction to standard bridge withdrawals * Update codehashes in L2 Standard bridge * fix(ops): remove unintentionally added file * feat(contracts): add expectApproxGasCost function * fix(integration): proper arrayify input on fundUser * fix(integration): proper gas value checks * Revert "Add onlyEOAContract restriction to standard bridge withdrawals" This reverts commit 2713c06ceb2609e4f13718e1034a4d76210d9758. * fix(contracts): removed unused expectApproxGasCost for now * fix(contracts): update OVM_SequencerFeeVault for bridge changes * lint * Update deployment for L1 Bridge w/ ChugSplash * Revert "l2geth: TEMP log contract calls" This reverts commit 21d42259278449f221bf34605162229b3d9d4fa9. * Apply suggestions from code review * Apply suggestions from code review * fix(contracts): deploy with chugsplash proxy * fix(contracts): add working bridge and chugsplash proxy deployment * fix(contracts,integration): 500k gas for depositETH * comment(contracts): describe failed deposit handling on l2 * Apply suggestions from code review Co-authored-by: ben-chain <ben@pseudonym.party> * docs: add changeset * fix(integration): set working l2 gas amount on funduser * test(integration): add receive() test * fix(contracts): reset receive to 1.2MM l2 gas * test(examples): skip l1-l2 example test for now * fix(contracts): drop hardcoded gas to 500k in receive() * fix(contracts): use abi.encodeWithSignature * fix(contracts): resolve merge conflicts * feat(integration): add expectApprox for flexible gas testing * fix(integration): fix failing gas tests * fix: incorrect l2 gas for deposit * Update utils.ts * fix(workflow): disable l1-l2 example until npm imports are fixed * chore: final round of PR review nits and tests Co-authored-by: Maurelian <maurelian@protonmail.ch> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: ben-chain <ben@pseudonym.party> Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> * fix: comment out codeowners (ethereum-optimism#1073) * fix: use predeploy constant lib for em wrapper (ethereum-optimism#1075) * fix: use predeploy constant lib for em wrapper * chore: add changeset * fix[l2geth]: off-by-one sometimes breaking replica sync (ethereum-optimism#1082) * fix[l2geth]: off-by-one sometimes breaking replica sync * chore: add changeset * fix(l2geth): Log 'end of OVM execution' correctly (ethereum-optimism#1080) * refactor[contracts]: move account contracts to predeploy folder (ethereum-optimism#1085) * refactor[contracts]: move account contracts to predeploy folder * chore: add changeset * maintenance[contracts]: rename precompiles test folder to predeploys (ethereum-optimism#1086) * fix[bs]: disambiguate generic submission errors (ethereum-optimism#1051) * fix[bs]: disambiguate generic submission errors * add cases for errors * separate out errors from transaction reverts with reasons * remove extraneous errors * WETH deposit and withdraw on OVM_ETH (ethereum-optimism#1083) * feat(contracts): add no-op WETH9 functionality to OVM_ETH * working WETH deposit and withdraw + tests * add changeset * address PR feedback * update WETH9 contract implementation * add fallback to WETH9 * add fallback and revert withdraw test * update nit comment Co-authored-by: ben <ben@pseudonym.party> * Also move the accounts interface to iOVM/predeploys (ethereum-optimism#1087) * refactor[contracts]: move account interface to predeploy folder * chore: add changeset * Version Packages (ethereum-optimism#1089) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: use -z flag for var unset in canary * Use Eslint instead of Tslint (ethereum-optimism#1005) * removed tslint * forgot to commit files * made .eslintrc.js consistent for all subdirs and other cleanup * [removed] includes and files keys from tsconfig.json * removed file level linting exceptions and added details to line level * added changeset * fixed newly introduced linting errors from rebase * enable json import for batch submitter * removed ecdsa-coder * maybe a tsconfig issue? * Update deploy.ts Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: platocrat <37757724+platocrat@users.noreply.github.com> * metrics[batch-submitter]: add new batch submitter metrics (ethereum-optimism#1074) * metrics[batch-submitter]: add new batch submitter metrics * chore: changeset * account for failed submissions * Fix canary publishing (ethereum-optimism#1093) * ci: fix custom docker tag * ci: use new env file * ci: use outputs from previous job * ci: fix headers of jobs * ci: inherit canary tag from builder * feat[ci]: upload logs for sync tests if failure (ethereum-optimism#1098) * deploy: goerli 0.4.0 (ethereum-optimism#1099) * deployments: goerli 0.4.0 rc * readme: update * chore: add changeset * fix[dtl]: defend against RPC provider missing events (ethereum-optimism#1084) * fix[dtl]: defend against RPC provider missing events * chore: add changeset * respond to review comments * better error handling for missing handlers * deploy: kovan v.4.0 rc (ethereum-optimism#1101) * deploy: kovan v0.4.0 rc * chore: add changeset * readme: update * maintenance[monorepo]: first pass update to README (ethereum-optimism#1106) * maintenance[monorepo]: first pass update to README Doing some relatively minor updates to the README just to clean things up a bit. * replying to review comments * Move the metric prefix string to a label (ethereum-optimism#1047) Added changeset and fixes Changeset to patch * fix[smock]: add support for hardhat 2.4.0 (ethereum-optimism#1112) * fix[smock]: add support for hardhat 2.4.0 * chore: add changeset * lint: fix * build(deps): bump hosted-git-info from 2.8.8 to 2.8.9 (ethereum-optimism#1064) Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) --- updated-dependencies: - dependency-name: hosted-git-info dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * Misc. small improvements to README (ethereum-optimism#1115) * Update README.md * Update README.md * fix[dtl]: use the same L2 chain ID everywhere (ethereum-optimism#1122) * fix[dtl]: use the same L2 chain ID everywhere * chore: add changeset * fix: make sync tests only on workflow dispatch (ethereum-optimism#1123) * fix[dtl]: remove old stringification function (ethereum-optimism#1134) * fix[dtl]: remove old stringification function * chore: add changeset * fix[dtl]: log server errors as ERROR instead of INFO (ethereum-optimism#1133) * fix[dtl]: log server errors as ERROR instead of INFO * chore: add changeset * Contracts: connectL1Contracts & connectL2Contracts (ethereum-optimism#713) * Contracts: connect-contracts * Trying to resolve build problems * connect-contracts build working * Adds artifacts-ovm back to gitignore * Removes incorrect changes * Adds copy-artifacts script * Adds test file (not working yet) * fix: incorrect contract instantiation * Improves tests and removes old deployment versions * Single source of truth for predeploy addresses * Reverts deployments/README.md * Makes connect-contracts more DRY * Adds missing @ethersproject/abstract-signer dependency * Adds argument evaluation * Adds L1Contracts and L2Contracts types * Attempts removing artifacts-ovm again * Adds webpack config (not working yet) * build: add artifacts to dist (ethereum-optimism#776) * Updates lint rule * Adds l2 imports * Fixes dependency tree bug * Removes webpack stuff * Fixing package.json issues and adds .DS_Store to gitignore * Removes test-contracts script * Reverting script change * Adds comments * Adds comment * Renames deployments folders * Fixes linting errors * Generates markdown * build: add deployments directory to Dockerfiles * Removes unneeded contracts, improves error handling and tests * Adds changeset * yarn.lock * Removes console.log * Changes from minor to patch version * Fixes lint errors Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * fix: prevent overflow in abi encoding (ethereum-optimism#1135) * l2geth: prevent overflow in abi encoding to ovm codec tx * chore: add changeset * tests: replica syncing (ethereum-optimism#981) * [wip] add l2_dtl and replica images * passing basic dummy tx test * add erc20 test * add sync test to ci Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> * fix[relayer]: update exported files list in package.json (ethereum-optimism#1138) * fix[relayer]: update exported files * chore: add changeset * fix: import path (ethereum-optimism#1141) * fix: correct import path for altered contract path * chore: add changeset * refactor: improve logging for batch submission timeout scenarios (ethereum-optimism#1120) * Add highest L1 and L2 block number Gauge metrics to DTL (ethereum-optimism#1125) * build: add prom-client to data-transport-layer * refactor: thread metrics more carefully through data-transport-layer; add two new metrics * style: fix some style issues * refactor: make metrics mandatory * refactor: move metrics register code to top of file * style: apply linting * refactor: move promethesus initialization after express * refactor: move promBundle call up, provide registry * build: add changeset * Improve Watcher ability to find transactions (ethereum-optimism#1107) * remove listeners and use loop to find tx receipt * add yarn ready * moved filters inside loop * [added] changeset * Add minimal vscode settings and extensions (ethereum-optimism#1109) * chore: add minimal vscode settings and extensions * chore: Add "files.trimTrailingWhitespace" to vscode native config * chore: replace vscode prettier plugin with eslint plugin * fix[contracts]: remove part of MultiMessageRelayer deployment (ethereum-optimism#1144) * fix[contracts]: remove part of MultiMessageRelayer deployment * chore: add changeset * Define L1 Starting block via OwnershipTransferred rather than AddressSet (ethereum-optimism#1129) * Update service.ts * Create thirty-years-look.md Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * Easy fix for broken watchers (ethereum-optimism#1121) * Easy fix for broken watchers * Ran yarn changeset Co-authored-by: Liam Horne <liam@lihorne.com> * feat: go packages (ethereum-optimism#1111) * go: add utils module * readme: update * Version Packages (ethereum-optimism#1094) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * build: add husky pre-commit hook to lint (ethereum-optimism#1146) * feat[contracts]: add mainnet deploy script (ethereum-optimism#1147) * Add mainnet deploy script * Update mainnet.sh * Address PR review feedback * feat: mainnet contract deployment 0.4.0 (ethereum-optimism#1148) * feat: mainnet contract deployment 0.4.0 * feat: deployments readme * chore: add changeset * contracts: remove dead contract * contracts: remove dead config * tests: fix to not test for old contracts * feat: `rollup gasPrices` RPC endpoint (ethereum-optimism#1136) * feature: l2geth endpoint * chore: add changeset Co-authored-by: Liam Horne <liam@lihorne.com> * Adds l2 standard bridge to contracts markdown file (ethereum-optimism#1151) * Version Packages (ethereum-optimism#1150) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add more info about our branching strategy to the README (ethereum-optimism#1114) * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Remove references to OVM_L1ETHGateway in deployments and readme (ethereum-optimism#1119) Co-authored-by: Maurelian <maurelian@protonmail.ch> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: Elena Gesheva <elena@arenabg.com> Co-authored-by: ben-chain <ben@pseudonym.party> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> Co-authored-by: Karl Floersch <karl@karlfloersch.com> Co-authored-by: Rajiv Patel-O'Connor <rajiv.patel.oconnor@gmail.com> Co-authored-by: rajivpo <rajivpatel-oconnor@Rajivs-MacBook-Pro-2.local> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kevin Ho <kevinjho1996@gmail.com> Co-authored-by: Ben Wilson <82120899+optimisticben@users.noreply.github.com> Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: Tim Myers <timmyers09@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Annie Ke <annieke8@gmail.com> Co-authored-by: platocrat <37757724+platocrat@users.noreply.github.com> Co-authored-by: Matt Masurka <m.masurka@gmail.com> Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> Co-authored-by: Alejandro Santander <Palebluedot@gmail.com>

* optimism: bump gaslimit to 10million * chore: add changeset * optimism: bump max gaslimit to 10 mil * chore: add changeset * chore: remove unnecessary changeset * chore: remove unnecessary changeset Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>

* Fixed wallet integration test (#95) * Update watcher-utils.ts * Fixed contracts * remove GH actions that break due to missing permissions * naming consistency, added comments to code snippets that will need to be changed when the message-relayer-fast autodeploys Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * tests: replica syncing (#981) * [wip] add l2_dtl and replica images * passing basic dummy tx test * add erc20 test * add sync test to ci Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> * fix[relayer]: update exported files list in package.json (#1138) * fix[relayer]: update exported files * chore: add changeset * fix: import path (#1141) * fix: correct import path for altered contract path * chore: add changeset * refactor: improve logging for batch submission timeout scenarios (#1120) * Fixed CrossDomainMessenger name (#96) * Add highest L1 and L2 block number Gauge metrics to DTL (#1125) * build: add prom-client to data-transport-layer * refactor: thread metrics more carefully through data-transport-layer; add two new metrics * style: fix some style issues * refactor: make metrics mandatory * refactor: move metrics register code to top of file * style: apply linting * refactor: move promethesus initialization after express * refactor: move promBundle call up, provide registry * build: add changeset * Improve Watcher ability to find transactions (#1107) * remove listeners and use loop to find tx receipt * add yarn ready * moved filters inside loop * [added] changeset * Add minimal vscode settings and extensions (#1109) * chore: add minimal vscode settings and extensions * chore: Add "files.trimTrailingWhitespace" to vscode native config * chore: replace vscode prettier plugin with eslint plugin * fix[contracts]: remove part of MultiMessageRelayer deployment (#1144) * fix[contracts]: remove part of MultiMessageRelayer deployment * chore: add changeset * Define L1 Starting block via OwnershipTransferred rather than AddressSet (#1129) * Update service.ts * Create thirty-years-look.md Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * Easy fix for broken watchers (#1121) * Easy fix for broken watchers * Ran yarn changeset Co-authored-by: Liam Horne <liam@lihorne.com> * feat: go packages (#1111) * go: add utils module * readme: update * Version Packages (#1094) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * build: add husky pre-commit hook to lint (#1146) * feat[contracts]: add mainnet deploy script (#1147) * Add mainnet deploy script * Update mainnet.sh * Address PR review feedback * feat: mainnet contract deployment 0.4.0 (#1148) * feat: mainnet contract deployment 0.4.0 * feat: deployments readme * chore: add changeset * contracts: remove dead contract * contracts: remove dead config * tests: fix to not test for old contracts * feat: `rollup gasPrices` RPC endpoint (#1136) * feature: l2geth endpoint * chore: add changeset Co-authored-by: Liam Horne <liam@lihorne.com> * Adds l2 standard bridge to contracts markdown file (#1151) * Version Packages (#1150) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add more info about our branching strategy to the README (#1114) * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Remove references to OVM_L1ETHGateway in deployments and readme (#1119) * Keep the user logged in after changing chain (#99) * Keep the user logged in after changing chain * Update Nft.js * Detect if user is in the wrong chain Co-authored-by: cby3149 <cby3149@outlook.com> Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * Merge conflics resolve (#110) * wip * gethl2 * wip * batch submitter * core utils * DTL * message relayer * contracts * wip * Update service.ts * DTL * messaage-relayer * Update yarn.lock * final 5 files * [pull] develop from ethereum-optimism:develop (#91) * chore: reduce hardhat timeout to 20 seconds (#968) * fix: force LF line endings for scripts to avoid docker problems on Windows (#974) * fix: use correct line endings for windows * chore: add changeset * refactor[contracts]: Turn ExecutionManagerWrapper into a predeployed contract (#808) * wip: Started working on L2 contract testing revamp * test: clean tests for ProxyEOA * style: clean imports for ProxyEOA tests * test: port tests for ECDSAContractAccount * fix tests and add wrapper to dump * fix: add em wrapper to l2 deploy * ffix: add comments to wrapper contract * fix: add more comments * fix: add smock comment for unbind * Update packages/smock/src/smockit/binding.ts * maintenance[contracts]: use dashes in chain container names (#819) * maintenance: use dashes in chain container names * chore: add changeset * feat[contracts]: temporarily disable EOA upgrades (#857) * feat[contracts]: disable eoa upgrades temporarily * chore: add changeset * Update OVM_ProxyEOA.sol * fix: turn upgrade into a noop * lint: fix * feat[contracts]: Update Lib_AddressManager.AddressSet event to speed up data transport layer (#820) * feat: update and improve AddressSet event * chore: add changeset * Update Lib_AddressManager.sol * Reduce gas costs of deposits (#667) * Remove messageNonce from BaseCrossDomainMessenger and use CTC queue lenght instead Remove Abs_BaseCrossDomainMessenger and restore dedicated nonce generation in OVM_L2CrossDomainMessenger Fix typo * Remove sentMessages mapping from L1CrossDomainMessenger storage and use the nonce to check for existence of replayed transaction * Refactor out common library function for getting cross domain calldata * Post rebase fixes * Use the queueIndex to check the transaction was enqueued * Fix tests for L1CrossDomainMessenger.replayMessage Also make that test work with an actual CanonicalTransactionChain implementation rather than a smock * Lint fixes * Optimise the resolve calls into the AddressManager lib * Rename the nonce parameter to be clear * Update test name Co-authored-by: ben-chain <ben@pseudonym.party> * Rename getXDomainCalldata to encodeXDomainCalldata to match the new Lib_CrossDomainUtils Co-authored-by: ben-chain <ben@pseudonym.party> * optimism: bump gaslimit to 10 million #870 (#871) * optimism: bump gaslimit to 10million * chore: add changeset * optimism: bump max gaslimit to 10 mil * chore: add changeset * chore: remove unnecessary changeset * chore: remove unnecessary changeset Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * fix: use correct contract name in tests (#921) * fix: disable upgradability from ECDSA Account (#885) * l2geth: remove `SignatureHashType` (#752) * l2geth: remove tx type * l2geth: no longer parse type in rollup client * chore: add changeset * chore: remove extra sighash params * fix: do not check txtype in integration tests Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * feat[contracts]: introduce OVM_GasPriceOracle (#912) * feat[contracts]: congestion price oracle * chore: add changeset * contracts: gas price oracle (#917) * contracts: gas price oracle * tests: update * fees: fix tests * contracts: simplify gas price oracle * lint: fix * test: execution price is at the 1st storage slot * chore: rename predeploy to GasPriceOracle * chore: rename gas price oracle test name Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * fix: configure max gas limit to 11m (#928) Uniswap V3 contracts require that, otherwise they throw call exceptions at deployment * Consolidate Predeploy Addresses (#931) * added library for predeploy addresses * refactor tests and other packages to use exported predeploys * revert library usage in OVM_ECDSAContractAccount * lint * added newline * fixed address typos Co-authored-by: rajivpo <rajivpatel-oconnor@Rajivs-MacBook-Pro-2.local> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * chore: remove yarn-error.log and gitignore it (#956) * feat[contracts]: Replace Lib_RingBuffer with a much simpler Lib_Buffer (#821) * feat[contracts]: replace Lib_RingBuffer with a simpler Lib_Buffer * chore: changeset * test: add tests for Lib_Buffer * lint: fix * test: add extra coverage for Lib_Buffer * Update packages/contracts/contracts/optimistic-ethereum/libraries/utils/Lib_Buffer.sol Co-authored-by: ben-chain <ben@pseudonym.party> * add some extra comments Co-authored-by: ben-chain <ben@pseudonym.party> * fix(contracts): import predeploys (#982) * fix(contracts): import predeploys * fix: lint * feat: add hardhat deploy instructions to readme (#965) * feat: add deployment instructions to readme * Add changeset * fix style * Update README.md * feat: fees v2 (#976) * l2 geth: new fee logic * l2 geth: migrate to fees package * core-utils: new fee scheme * chore: add changeset * l2geth: delete dead code * integration-tests: fix typo * integration-tests: fixes * fees: use fee scalar * lint: fix * rollup: correct gas payment comparison * fix(integration-tests): do not hardcode gas price * core-utils: update with new scheme * l2geth: refactor rollup oracle * l2geth: clean up DoEstimateGas * l2geth: implement latest scheme * tests: fix up * lint: fix * l2geth: better sycn service test * optimism: rename to TxGasLimit * fee: fix docstring * tests: fix * variables: rename * l2geth: prevent users from sending txs with too high of a fee * integration-tests: fix import * integration-tests: fix type * integration-tests: fix gas limits * lint: fix * l2geth: log error Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * Add static analysis action (#848) * Add static analysis github action setup python and install slither * Add nvmrc file for setting node to v14.17 * Update slither command run to link missing contract packages from monorepo root * Add steps for installing dependencies * Add yarn build step to github action * Enable colour in github action for static analysis * Disable certain detectors * Ensure slither does not fail build * Add instructions on running static analysis to monorepo readme * build(deps): bump ws from 7.4.4 to 7.4.6 in /ops/docker/hardhat (#987) Bumps [ws](https://github.com/websockets/ws) from 7.4.4 to 7.4.6. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](https://github.com/websockets/ws/compare/7.4.4...7.4.6) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix[l2geth]: fix accidental merge conflict (#994) * feat[message-relayer]: relay tx generator (#952) * feat[message-relayer]: relay tx generator * whoops, I burned our infura key * fix minor bug * add comments * add more comments and clean stuff up * add empty test descriptions * add tests * move smock to dev deps * chore: add changeset * minor cleanup to merkle tree proof function * use bignumber math to avoid nested await * use a better interface * minor fixes and simplifications * backwards compatible dtl syncing (#986) * kovan: fix attempt * kovan: db fix * kovan: types are strings from db * l2geth: parse things as strings * chore: add changeset * dtl: also stringify the range query * geth: dereference * geth: assign err * dtl: handle null * dtl: fix unit tests * fix[smock]: fix broken call assertions for overloaded functions (#996) * fix[smock]: fix broken call assertions for overloaded functions * chore: add changeset * minor correction and add a test * add a test for non-overloaded functions * fix[message-relayer]: fix failing test because of merge with develop (#1000) * fix[message-relayer]: remove spreadsheet mode (#998) * fix[message-relayer]: remove spreadsheet mode * chore: add changeset * Lower local rollup timestamp refresh (#985) * update rollup timestamp refresh * increase refresh time to 5s * feat: fees v3 (#999) * core-utils: fee impl v3 * l2geth: fees v3 impl * integration-tests: update for fees v3 * chore: add changeset * fix: typo * integration-tests: fix and generalize * fees: update fee scalar * l2geth: check gas in the mempool behind usingovm * tests: fix up * l2geth: remove dead var * truffle: fix config * fix: remove dead coders (#1001) * chore: delete dead coders * chore: add changeset * dtl: remove dead imports * core-utils: delete dead tests * batch-submitter: remove txtype * chore: add changeset * docs[message-relayer]: add a README and improve the interface for generating proofs (#1002) * docs[message-relayer]: add basic docs and clean up an interface * chore: add changeset * dtl: log error stack for failed http request (#995) * dtl: log error stack for failed http request * chore: add changeset * Add rpc-proxy service for whitelisting JSON RPC methods to the sequencer. (#945) * Add healthcheck endpoint for rpc-proxy Added ethereum-nginx-proxy source updated README and docker image build * Check ETH_CALLS_ALLOWED is set, clean up comments, remove old Dockerfile * Pass additional information across domains via token gateways (#824) * feat(contracts): add from and data args to L1ERC20Gateway fix(integration): add gasLimit to fundUser refactor(contracts): add data to gateway events add changeset fix(integration): provide data in outboundTransfer refactor(contracts): reset Abs_L2TokenGateway to Abs_L2DepositedToken refactor(contracts): fix mismatched names * feat[contracts]: add custom gas arg to gateway fix(contracts): take max of user vs. default gas * fix(integrations): update ovm-eth function call * fix(integration): remove unecessary explicit gasLimit * test(contracts): 32kb transfer, 9MM gas * fix(contracts): fixup comment, bytes arg last * fix(integration): args order in integrations * fix(contracts): remove unused L2 gas arg * fix(contracts): limit data that can be passed to L2 * fix(integration): better tests for data length * test: check for error on too large data * Experimental: specify gaslimit in before hook * fix(integration): add l2 gas argument * fix: increase gas on fundUser * fix(contracts): remove duplicate max size limit * fix(integration): fine tune gas amounts * lint * fix: large data test * fix(integration): set gas closer to real cost * fix(contracts): remove unused bridge variables These variables were the default gas amounts for cross domain messages * fix(contracts): Reorder args Place dynamic length args last * fix(integration): update estimateGas values * fix(integration): reset eth withdraw estimate to 21000 * fix(integration): update expected gas amount * fix(integration): reduce gas amount for ETH withdraw * More consistent style for Constant values (#991) * chore(contracts): make container addresses be constants chore(contracts): consistent style for constant vars * chore(contracts): add internal on predeploy constants * feat: deployment config for fee oracle contract (#936) * feat[contracts]: add GasPriceOracle w/o predeploy Based on #912 * feat[contracts]: congestion price oracle * chore: add changeset * contracts: gas price oracle (#917) * contracts: gas price oracle * tests: update * fees: fix tests * contracts: simplify gas price oracle * lint: fix * test: execution price is at the 1st storage slot * chore: rename predeploy to GasPriceOracle * chore: rename gas price oracle test name Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * Add an L2 deploy script for gas oracle contract * Add a kovan deployment artifact * Add deployment to readme * Add extra validation & initial execution price * Update README.md * Fix execution price logic * Perform new deployment with final contract * contracts: better require in ovm gas price oracle * Deploy L2GasPriceOracle * Update contract to use new fee logic & rename to gas * Deploy updated contract * Fix lint * gas price oracle: do not restrict gas price * gas price oracle: new deployment * tests: delete dead test Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * ops: expose debug namespace (#1007) * develop merge fixes * refactor[l2geth]: queue origin type (#975) * refactor: queueOrigin type * Convert queueOrigin to uint8 in encode * Add changeset * Regenerate json marshall * style: combine lines * Add Stringer for QueueOrigin * Turn QueueOrigin into uint8 * l2geth: gen tx meta fix * l2geth: gen tx meta fix * lint Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> * fix(sync-service): prevent underflows (#1015) * fix(sync-service): prevent underflows * chore: add changeset * chore: remove dead confirmation depth * chore: remove eth1conf depth from rollup config * test: remove duplicate value in array (#1014) * ci: tag docker image for canary with abbreviated GITHUB_SHA (#1006) * ci: tag docker image for canary with abbreviated GITHUB_SHA * ci: update from 6 bytes to 8 bytes of abbreviation * refactor: improve logging for transactions being submitted to chain with gasPrice (#1016) * refactor: improve logging for transactions being submitted to chain with gasPrice * lint: apply lint autofixes * dtl: remove stringify from db logic + more overflow protection (#1010) * dtl: remove stringify from db logic * l2geth: overflow protection * dtl: overflow protection * chore: add changeset * ci: upload logs for failed integration tests (#1020) * fix(dtl): improve slow blocking JSON parsing that occurs during l2 sync (#1019) The use of eth_getBlockRange returns a large response which is very slow to parse in ethersjs, and can block the event loop for upwards of multiple seconds. When this happens, incoming http requests will likely timeout and fail. Instead, we will parse the incoming http stream directly with the bfj package, which yields the event loop periodically so that we don't fail to serve requests. * fix: lint errors in dtl (#1025) * fix[dtl]: fix dtl bug breaking verifiers (#1011) * fix[dtl]: fix dtl bug breaking verifiers * tweaks so tests pass * chore: add changeset * fix: deterministic blockhashes (#1032) * config: set etherbase * l2geth: add deterministic clique key * l2geth: default value * chore: add changeset * test: add sync test for deterministic blockhash Co-authored-by: Kevin Ho <kevinjho1996@gmail.com> * Version Packages (#978) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * ci: add sync test's own workflow (#1031) * fix(dtl): incorrect parsing of eth_getBlockRange result (#1037) * Version Packages (#1045) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: no gas refund (#1043) * l2geth: remove the gas refund * chore: add changeset * refactor[contracts]: remove one-off GasPriceOracle deployment file (#1046) * refactor[contracts]: remove one-off gpo deployment * chore: add changeset * feat[contracts]: introduce new L1ChugSplashProxy contract (#1009) * feat[contracts]: add L1ChugSplashProxy * improve comments slightly * start adding tests * add more tests * make the system pausable * added another test * add some extra comments * Update packages/contracts/test/contracts/chugsplash/L1ChugSplashProxy.spec.ts Co-authored-by: Maurelian <maurelian@protonmail.ch> * Update packages/contracts/test/contracts/chugsplash/L1ChugSplashProxy.spec.ts Co-authored-by: Maurelian <maurelian@protonmail.ch> * chore: add changeset * address review feedback Co-authored-by: Maurelian <maurelian@protonmail.ch> * feat[contracts]: add sequencer fee wallet (#1029) * wip: first draft of the fee wallet * add fee wallet to dump * rename to sequencer vault * add L1 fee wallet to geth config * add unit tests * fix geth linting error * add a basic integration test * fix broken integration test * add test for correct storage slot * add integration test for fee withdrawal * fix typo in integration tests * fix a bug bin integration tests * Update OVM_SequencerFeeVault.sol * fix bug in contract tests * chore: add changeset * fix bug in contract tests * build(deps): bump glob-parent from 5.1.1 to 5.1.2 (#1036) Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2. - [Release notes](https://github.com/gulpjs/glob-parent/releases) - [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md) - [Commits](https://github.com/gulpjs/glob-parent/compare/v5.1.1...v5.1.2) --- updated-dependencies: - dependency-name: glob-parent dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: Liam Horne <liam@lihorne.com> * fix: predeploy gasprice oracle (#1039) * l2geth: delete extra config options * l2geth: stop using extra config options * l2geth: more stop using extra config options * chore: add changeset * l2geth: add new config for gpo owner * chore: add changeset * l2geth: fix tests * tests: fix build * l2geth: optimize loops (#1027) * l2geth: optimize loops * l2geth: stop ticker when done * l2geth: don't wait for first tick * chore: add changeset * Enable custom tagging of release docker image (#1048) * ci: enable custom tagging of release docker image * ci: refactor to add prerelease prefix for secuirty * doc: typo * ci: fix indentation issue of canary workflow * ci: fix typo with GITHUB_SHA * fix: typo in USE_HARDHAT config (#1023) * fix: abi encoded tx (#1049) * contracts: don't double rlp decode * chore: add changeset * lint: fix * deps: update * linting: cleanup * feat: contracts: use selector * fix: contracts: use typescript * contracts: use interface * l2geth: bump to go 1.15 (#1058) * l2geth: bump to go 1.15 * chore: add changeset * Change monotonicity band-aid code to log warnings not errors (#1060) * refactor: change monotonicity band-aid code to log warnings not errors * build: add changeset * feat(contracts, l2geth): native ETH value support for ovmCALL (#1038) * feat(contracts): add ovmCALL-types with native value * add ovmCALLVALUE context * add ovmBALANCE * test success and revert cases * test empty contract case * chore: lint * test(integration-tests): ovmCALL-types with value (compiler and wrapper) * fix ovmDELEGATECALL type, update tests * add ovmSELFBALANCE * fix ovmDELEGATECALL jumping to CALL * chore: lint * fix(contracts): account for intrinsic gas of OVM_ETH sends * fix(contracts): merge conflict bug * fix(contracts): update gas benchmark * feat(contracts, integration-tests): use new value-compatible compiler * feat(contracts,l2geth): support value calls in OVM_ECDSAContractAccount * fix(contracts): ovmDELEGATECALL does not change message context * feat(contracts): sending value between EOAs * test(integration-tests): ovmDELEGATECALL preserves ovmCALLVALUE * test(integration-tests): assert ovmSELFBALANCEs correct * test(integration-tests): intrinsic gas for eth value calls * test(integration-tests): update gas values * chore(contracts): lint * feat(contracts, l2geth): eth_calls with nonzero value * chore: minor fixups and comments based on PR feedback * test(integration-tests): add requested tests from PR reviews * test(integration-tests): ovmSELFBALANCE is preserved in ovmDELEGATECALLs * fix(contracts): fix bug where ovmDELEGATECALL could fail if balance was lower than the ovmCALLVALUE * chore: add changeset * fix(contracts): update intrinsic gas for worst-case value sends * chore: address final PR nits/improvements Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> * Add erc1271 support to contract account (#1052) * add ERC1271 support, failing unit tests * add integration test for isValidSignature * remove .only * lint * add changeset * clean up 1271 tests and lint * switch back to using waffle wallet * lint * fix import * feat[contracts]: slightly better account funding for hardhat accounts (rebased) (#1065) * feat[contracts]: better account funding for hardhat accounts * add a sleep to avoid any potential problems * chore: add changeset * fix: bug with gas estimation in funding step * fix: limit to 20 accounts max Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> * Ensure Sentry is correctly set up for DTL and MR (#1054) * refactor: add logger and metrics to options for BaseService * refactor: thread sentryOptions through from message-relayer into BaseService * refactor: ensure DTL Logger is using Sentry for errors * style: lint base-service.ts * refactor: init Sentry on batch-submitter too * refactor: init Sentry on message-relayer too * refactor: pass in basic logger to MessageRelayerService * build: provide changeset * fix: correct usage of use-sentry boolean config * refactor: appropriately type loggingOptions * build: add @sentry/node * build: add @sentry/node to message-relayer and fix linting issue * Add more logging information to monotonicity violation logs (#1066) * refactor: log idx of monotonicity violation from batch * build: add changeset * temporarily disable hardhat example tests (#1071) * fix: monotonicity auto healer (#1070) * fix: monotonicity auto healer * add: changeset * Version Packages (#1053) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Standard token bridge (#988) * Remove abstract token gateway and deposited token implementations * Further simplification of bridge contracts * Standart token bridge and L2 token implementation * Fix spacing * Implement case when a bad deposit happens to a nonexistent L1<>L2 token pair * Use SafeMath in common token bridge accounting * test(contracts): fix finalizeWithdrawal test * fix(contracts): use SafeERC20 on token deposits * Rename OVM_L1ERC20Gateway to OVM_L1ERC20Bridge contract * Rename iOVM_L1ERC20Gateway to iOVM_L1ERC20Bridge contract * Cleanup gateway to bridge rename * Better name for the mapping holding l1->l2 deposit amounts * Use OZ SafeMath * Rename local variables in OVM_L2DepositedERC20 from gateway to bridge * Merge ETH and ERC20 bridge contracts * Rename OVM_L1ERC20Bridge to OVM_L1StandardBridge and fix tests from merging the ETH and ERC20 bridges * Better name for iAbs_BaseCrossDomainMessenger -> iOVM_CrossDomainMessenger * Correct the bounce back of deposit sender and recipient properties * Remove obsoleted event from OVM_L2DepositedERC20 * chore(contracts): change references from ETHGateway to Bridge * Fix a linting error * fix(contracts): add bridge to deployer * Split off ERC20Bridge interface for the purposes of being reused in custom ERC20 bridges * Split off interface natspec definitions * Draft version of OVM_L2DepositedERC20 splitted into a standard L2 erc20: L2StandardERC20 and a common L2 bridge: OVM_L2StandardBridge * style(contracts): define L1_ETH_ADDRESS as constant * test(integration): update interface to use depositETH * test(contracts): fix OVM_L1StandardBridge tests * test(contracts): fix L2 Standard Bridge tests * test(contracts): lint and remove an obsolete test case * Fix modifier check to comply with the L2 bridge distinction from L2 token * Simplify address <> interface casting in bridges * Ensure natspec comments are correct also add l1 and l2 token params to WithdrawalInitiated event for consistency * Fix issues in L1 and L2 bridges to ensure cross domain messages are sent only between the two bridges also adjusted withdrawals to send to either finalizeETHWithdrawal or finalizeERC20Withdrawal depending on which asset is being withdrawn * Remove AddressManager from the L1 standard bridge * REVERT ME: instruments cross domain enabled * fix(contracts): remove Address Manager from L1 Bridge * feat(contracts): make L2 Standard Bridge a predeploy * WIP: update deployments for standard bridges * WIP: update deployments for standard bridges * l2geth: TEMP log contract calls * chore(l2geth): replace eth gateway with standard bridge * fix(contracts): make contract-deployment/config work * WIP fix(integration): update integration tests for bridge * Remove ovmEth from L1 Standard bridge as obsoleted * Separate ERC20 standard implementation from L2 bridge * Formatting fixes * chore(l2geth): replace eth gateway with standard bridge * Revert "REVERT ME: instruments cross domain enabled" This reverts commit d5bb8f8f67974d0a3e65fc000f08858328a4bbbc. * fix: lint ts * Implement EIP-165 in the Standard L2 ERC20 token Also switch that to be based off the OpenZeppelin default implementation plus mint and burn Additionally remove the obsoleted iOVM_ERC20 * fix(contracts): add deployment check on bridge proxy fix(contracts): whitespace fix(contracts): init bridge implementation with non-zero address * Remove dependency on Ownable contract for the StandardERC20 token on L2 * fix(contracts): update deployment scripts * fix: lint * remove debugging code * fix: correct rpc get balance slot * restore l2 cross domain messenger * fix: lint * Add a test for a non compliant token deposit * Only allow EOAs to deposit ETH and ERC20 * Add comments and tests for ERC165 implementation * Decide against using explicit ETH MOCK address as we're not using it for checks * Fix linting issues * Add onlyEOAContract restriction to standard bridge withdrawals * Update codehashes in L2 Standard bridge * fix(ops): remove unintentionally added file * feat(contracts): add expectApproxGasCost function * fix(integration): proper arrayify input on fundUser * fix(integration): proper gas value checks * Revert "Add onlyEOAContract restriction to standard bridge withdrawals" This reverts commit 2713c06ceb2609e4f13718e1034a4d76210d9758. * fix(contracts): removed unused expectApproxGasCost for now * fix(contracts): update OVM_SequencerFeeVault for bridge changes * lint * Update deployment for L1 Bridge w/ ChugSplash * Revert "l2geth: TEMP log contract calls" This reverts commit 21d42259278449f221bf34605162229b3d9d4fa9. * Apply suggestions from code review * Apply suggestions from code review * fix(contracts): deploy with chugsplash proxy * fix(contracts): add working bridge and chugsplash proxy deployment * fix(contracts,integration): 500k gas for depositETH * comment(contracts): describe failed deposit handling on l2 * Apply suggestions from code review Co-authored-by: ben-chain <ben@pseudonym.party> * docs: add changeset * fix(integration): set working l2 gas amount on funduser * test(integration): add receive() test * fix(contracts): reset receive to 1.2MM l2 gas * test(examples): skip l1-l2 example test for now * fix(contracts): drop hardcoded gas to 500k in receive() * fix(contracts): use abi.encodeWithSignature * fix(contracts): resolve merge conflicts * feat(integration): add expectApprox for flexible gas testing * fix(integration): fix failing gas tests * fix: incorrect l2 gas for deposit * Update utils.ts * fix(workflow): disable l1-l2 example until npm imports are fixed * chore: final round of PR review nits and tests Co-authored-by: Maurelian <maurelian@protonmail.ch> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: ben-chain <ben@pseudonym.party> Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> * fix: comment out codeowners (#1073) * fix: use predeploy constant lib for em wrapper (#1075) * fix: use predeploy constant lib for em wrapper * chore: add changeset * fix[l2geth]: off-by-one sometimes breaking replica sync (#1082) * fix[l2geth]: off-by-one sometimes breaking replica sync * chore: add changeset * fix(l2geth): Log 'end of OVM execution' correctly (#1080) * refactor[contracts]: move account contracts to predeploy folder (#1085) * refactor[contracts]: move account contracts to predeploy folder * chore: add changeset * maintenance[contracts]: rename precompiles test folder to predeploys (#1086) * fix[bs]: disambiguate generic submission errors (#1051) * fix[bs]: disambiguate generic submission errors * add cases for errors * separate out errors from transaction reverts with reasons * remove extraneous errors * WETH deposit and withdraw on OVM_ETH (#1083) * feat(contracts): add no-op WETH9 functionality to OVM_ETH * working WETH deposit and withdraw + tests * add changeset * address PR feedback * update WETH9 contract implementation * add fallback to WETH9 * add fallback and revert withdraw test * update nit comment Co-authored-by: ben <ben@pseudonym.party> * Also move the accounts interface to iOVM/predeploys (#1087) * refactor[contracts]: move account interface to predeploy folder * chore: add changeset * Version Packages (#1089) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: use -z flag for var unset in canary * Use Eslint instead of Tslint (#1005) * removed tslint * forgot to commit files * made .eslintrc.js consistent for all subdirs and other cleanup * [removed] includes and files keys from tsconfig.json * removed file level linting exceptions and added details to line level * added changeset * fixed newly introduced linting errors from rebase * enable json import for batch submitter * removed ecdsa-coder * maybe a tsconfig issue? * Update deploy.ts Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: platocrat <37757724+platocrat@users.noreply.github.com> * metrics[batch-submitter]: add new batch submitter metrics (#1074) * metrics[batch-submitter]: add new batch submitter metrics * chore: changeset * account for failed submissions * Fix canary publishing (#1093) * ci: fix custom docker tag * ci: use new env file * ci: use outputs from previous job * ci: fix headers of jobs * ci: inherit canary tag from builder * feat[ci]: upload logs for sync tests if failure (#1098) * deploy: goerli 0.4.0 (#1099) * deployments: goerli 0.4.0 rc * readme: update * chore: add changeset * fix[dtl]: defend against RPC provider missing events (#1084) * fix[dtl]: defend against RPC provider missing events * chore: add changeset * respond to review comments * better error handling for missing handlers * deploy: kovan v.4.0 rc (#1101) * deploy: kovan v0.4.0 rc * chore: add changeset * readme: update * maintenance[monorepo]: first pass update to README (#1106) * maintenance[monorepo]: first pass update to README Doing some relatively minor updates to the README just to clean things up a bit. * replying to review comments * Move the metric prefix string to a label (#1047) Added changeset and fixes Changeset to patch * fix[smock]: add support for hardhat 2.4.0 (#1112) * fix[smock]: add support for hardhat 2.4.0 * chore: add changeset * lint: fix * build(deps): bump hosted-git-info from 2.8.8 to 2.8.9 (#1064) Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](https://github.com/npm/hosted-git-info/compare/v2.8.8...v2.8.9) --- updated-dependencies: - dependency-name: hosted-git-info dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * Misc. small improvements to README (#1115) * Update README.md * Update README.md * fix[dtl]: use the same L2 chain ID everywhere (#1122) * fix[dtl]: use the same L2 chain ID everywhere * chore: add changeset * fix: make sync tests only on workflow dispatch (#1123) * fix[dtl]: remove old stringification function (#1134) * fix[dtl]: remove old stringification function * chore: add changeset * fix[dtl]: log server errors as ERROR instead of INFO (#1133) * fix[dtl]: log server errors as ERROR instead of INFO * chore: add changeset * Contracts: connectL1Contracts & connectL2Contracts (#713) * Contracts: connect-contracts * Trying to resolve build problems * connect-contracts build working * Adds artifacts-ovm back to gitignore * Removes incorrect changes * Adds copy-artifacts script * Adds test file (not working yet) * fix: incorrect contract instantiation * Improves tests and removes old deployment versions * Single source of truth for predeploy addresses * Reverts deployments/README.md * Makes connect-contracts more DRY * Adds missing @ethersproject/abstract-signer dependency * Adds argument evaluation * Adds L1Contracts and L2Contracts types * Attempts removing artifacts-ovm again * Adds webpack config (not working yet) * build: add artifacts to dist (#776) * Updates lint rule * Adds l2 imports * Fixes dependency tree bug * Removes webpack stuff * Fixing package.json issues and adds .DS_Store to gitignore * Removes test-contracts script * Reverting script change * Adds comments * Adds comment * Renames deployments folders * Fixes linting errors * Generates markdown * build: add deployments directory to Dockerfiles * Removes unneeded contracts, improves error handling and tests * Adds changeset * yarn.lock * Removes console.log * Changes from minor to patch version * Fixes lint errors Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * fix: prevent overflow in abi encoding (#1135) * l2geth: prevent overflow in abi encoding to ovm codec tx * chore: add changeset * tests: replica syncing (#981) * [wip] add l2_dtl and replica images * passing basic dummy tx test * add erc20 test * add sync test to ci Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> * fix[relayer]: update exported files list in package.json (#1138) * fix[relayer]: update exported files * chore: add changeset * fix: import path (#1141) * fix: correct import path for altered contract path * chore: add changeset * refactor: improve logging for batch submission timeout scenarios (#1120) * Add highest L1 and L2 block number Gauge metrics to DTL (#1125) * build: add prom-client to data-transport-layer * refactor: thread metrics more carefully through data-transport-layer; add two new metrics * style: fix some style issues * refactor: make metrics mandatory * refactor: move metrics register code to top of file * style: apply linting * refactor: move promethesus initialization after express * refactor: move promBundle call up, provide registry * build: add changeset * Improve Watcher ability to find transactions (#1107) * remove listeners and use loop to find tx receipt * add yarn ready * moved filters inside loop * [added] changeset * Add minimal vscode settings and extensions (#1109) * chore: add minimal vscode settings and extensions * chore: Add "files.trimTrailingWhitespace" to vscode native config * chore: replace vscode prettier plugin with eslint plugin * fix[contracts]: remove part of MultiMessageRelayer deployment (#1144) * fix[contracts]: remove part of MultiMessageRelayer deployment * chore: add changeset * Define L1 Starting block via OwnershipTransferred rather than AddressSet (#1129) * Update service.ts * Create thirty-years-look.md Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * Easy fix for broken watchers (#1121) * Easy fix for broken watchers * Ran yarn changeset Co-authored-by: Liam Horne <liam@lihorne.com> * feat: go packages (#1111) * go: add utils module * readme: update * Version Packages (#1094) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * build: add husky pre-commit hook to lint (#1146) * feat[contracts]: add mainnet deploy script (#1147) * Add mainnet deploy script * Update mainnet.sh * Address PR review feedback * feat: mainnet contract deployment 0.4.0 (#1148) * feat: mainnet contract deployment 0.4.0 * feat: deployments readme * chore: add changeset * contracts: remove dead contract * contracts: remove dead config * tests: fix to not test for old contracts * feat: `rollup gasPrices` RPC endpoint (#1136) * feature: l2geth endpoint * chore: add changeset Co-authored-by: Liam Horne <liam@lihorne.com> * Adds l2 standard bridge to contracts markdown file (#1151) * Version Packages (#1150) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add more info about our branching strategy to the README (#1114) * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Remove references to OVM_L1ETHGateway in deployments and readme (#1119) Co-authored-by: Maurelian <maurelian@protonmail.ch> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: Elena Gesheva <elena@arenabg.com> Co-authored-by: ben-chain <ben@pseudonym.party> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> Co-authored-by: Karl Floersch <karl@karlfloersch.com> Co-authored-by: Rajiv Patel-O'Connor <rajiv.patel.oconnor@gmail.com> Co-authored-by: rajivpo <rajivpatel-oconnor@Rajivs-MacBook-Pro-2.local> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kevin Ho <kevinjho1996@gmail.com> Co-authored-by: Ben Wilson <82120899+optimisticben@users.noreply.github.com> Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: Tim Myers <timmyers09@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Annie Ke <annieke8@gmail.com> Co-authored-by: platocrat <37757724+platocrat@users.noreply.github.com> Co-authored-by: Matt Masurka <m.masurka@gmail.com> Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> Co-authored-by: Alejandro Santander <Palebluedot@gmail.com> * Re-apply key changes on top of optimism most current develop * Add docker-compose-replica.yml (#109) * Create docker-compose-replica.yml * Add replica service * Update docker-compose-omgx-replica.yml Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * fix linter; patch gethl2 * configure the deployer correctly * fix proposer / batch submitter * update chainIDs * update rpc test * Create README_OMGX.md * upstream - needs more work * Adds delay to watcher (#1159) * Adds delay to watcher * Simplifies delay * Adds changeset * Fix wallet test * Fix deployment test * Add Python * Update Dockerfile.omgx_monorepo * Remove package-lock * fix: bind dtl functions for missing event codepath (#1161) * dtl: bind this in L1 missing element error handlers * dtl: add additional logline * chore: add changeset * dtl: add more metrics * dtl: use counter instead of gauge Co-authored-by: Kevin Ho <kevinjho1996@gmail.com> * fix: remove 'editor.formatOnSave' from global settings' (#1163) * merge conflicts * Update pre-commit * Version Packages (#1167) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * minor * Update pre-commit * Fix wallet test (#119) * Fix wallet test * Fix deployment test * Add Python * Update Dockerfile.omgx_monorepo * Remove package-lock Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * Reapply standard changes on top of current develop * Update package.json * doc: add notes for releasing new versions with changesets (#1166) * Bind correct object to method handler in DTL (#1168) * fix: bind correct object to method handler * build: add changeset * Version Packages (#1169) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix web wallet * Fix integration test (#124) * Fix integration test (#125) * Fix integration test * Fix integration test * Fix wallet_react * Fix lint test * Remove package-lock * Update integration.yml * Fix wallet deployer * Collect docker log * Fix l1-l2-deposit-withdrawal test * Fix sync test * Add chainID to deployer config * make sync tests dispatch only Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * Add short contribution section to primary README (#1157) * Add short contribution section to primary README * Update README.md * fix: prevent batch submitter from submitting batches if low on ETH * build: add changeset * Eslint ignore the hardhat folder * Update README.md * Beginning to add working examples * hardhart and waffle example tests * document/check waffle * test l1-l2 example * add patch-package * Update package.json * build: ensure lint only staged files on commit * refactor: do not run --fix on lint-staged * refactor: *.{ts,js} for eslint regex * l2geth: rollup client explicitly checks for >= 400 errors * l2geth: sync service retries connection to remote server * l2geth: test errors returning from remote * chore: add changeset * syncservice: nit * feat[message-relayer]: add easy relay tool * chore: add changeset * upkeep[monorepo]: add changeset info to README * merge conflict squash * Daily sync up (#137) * build: ensure lint only staged files on commit * refactor: do not run --fix on lint-staged * refactor: *.{ts,js} for eslint regex * l2geth: rollup client explicitly checks for >= 400 errors * l2geth: sync service retries connection to remote server * l2geth: test errors returning from remote * chore: add changeset * syncservice: nit * feat[message-relayer]: add easy relay tool * chore: add changeset * upkeep[monorepo]: add changeset info to README Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Kelvin Fichter <kelvin@optimism.io> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * build: set up eslint prettier correctly * style: run yarn lint --fix at root * build: add necessary packages to workspace root * build: remove --format stylish * build: set semvery ranges to match across packages * build: set up prettierrc.js for monorepo * refactor: rename Range to BlockRange * build: set up correct working directories * build: set up lint:fix to use eslint not prettier * style: run lint:fix on all code * build: remove prettier extension recommendation * style: update configuration to include babel-eslint for .js linting * build: set concurrency to 1 to prevent git add errors on lerna lint * github actions: bump geth CI golang version * fix(contracts): prevent L2->L1 calls to system contracts * Update message relayer fast contracts (#139) * prepare for wallet reorg * Create yarn.lock * fix hardhat bug * merge conflict resolve * daily sync up (#141) * build: set up eslint prettier correctly * style: run yarn lint --fix at root * build: add necessary packages to workspace root * build: remove --format stylish * build: set semvery ranges to match across packages * build: set up prettierrc.js for monorepo * refactor: rename Range to BlockRange * build: set up correct working directories * build: set up lint:fix to use eslint not prettier * style: run lint:fix on all code * build: remove prettier extension recommendation * style: update configuration to include babel-eslint for .js linting * build: set concurrency to 1 to prevent git add errors on lerna lint * fix(contracts): prevent L2->L1 calls to system contracts Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: ben <ben@pseudonym.party> * Add Factory contract for creating standard ERC20 tokens compliant with the standard bridge * Disallow 0 address for l1 token when creating l2 standard token * Fix linting issue * Add deployment script for the L2 token factory * Fix deploy script OVM_L2StandardTokenFactory constructor params * Add changeset * Cleanup deployment script for OVM_L2StandardTokenFactory and fix a solidity linting error * refactor(integration): Add clarity to the expectApprox function signature * fix: skip codechecks for PRs from external repos * DRAFT move react wallet and the contracts to more clear folders (#138) * DRAFT move react wallet and the contracts to more clear folders * merging the axios integration chagnes * updated the message-relayer-fast contracts * integrate message-relayer-fast into standard dockers * Dockerize the message-relayer-fast * update Readme.md * remove duplicated contracts - just keep everything in /contracts * add deploy for fast messenger * message-relayer-fast testing * Update serve.sh * Delete yarn.lock * Update constants.ts * Create yarn.lock * Update constants.ts * Update function-manipulation.spec.ts * increase the retries and other minor fixes * Improved documentation * fix omgx integration tests * Update omgx-integration.yml * integration test remove duplicated tests * Fix units test configuration * Update docker-compose-omgx-services.yml * integration test setup fixes * fix wallet integration test * fix for crash on return * integration tests for `message-relayer-fast` * Update env.ts * Autodeploy Token Bridges * Update wallet contracts * Update utils.ts * improve omgx integration tests * Add address manager address to GH actions for now Co-authored-by: sahil kashetwar <> Co-authored-by: Sahil k <sahil@enya.ai> Co-authored-by: cby3149 <cby3149@outlook.com> * merge conflicts * GH actions regular changes * husky * Daily sync up (#144) * build: set up eslint prettier correctly * style: run yarn lint --fix at root * build: add necessary packages to workspace root * build: remove --format stylish * build: set semvery ranges to match across packages * build: set up prettierrc.js for monorepo * refactor: rename Range to BlockRange * build: set up correct working directories * build: set up lint:fix to use eslint not prettier * style: run lint:fix on all code * build: remove prettier extension recommendation * style: update configuration to include babel-eslint for .js linting * build: set concurrency to 1 to prevent git add errors on lerna lint * github actions: bump geth CI golang version * fix(contracts): prevent L2->L1 calls to system contracts * Add Factory contract for creating standard ERC20 tokens compliant with the standard bridge * Disallow 0 address for l1 token when creating l2 standard token * Fix linting issue * Add deployment script for the L2 token factory * Fix deploy script OVM_L2StandardTokenFactory constructor params * Add changeset * Cleanup deployment script for OVM_L2StandardTokenFactory and fix a solidity linting error * refactor(integration): Add clarity to the expectApprox function signature * fix: skip codechecks for PRs from external repos Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: ben <ben@pseudonym.party> Co-authored-by: elenadimitrova <elena@arenabg.com> Co-authored-by: Reggie Gomez <reggieag@gmail.com> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * docker: pin to alpine 3.13 for l2geth A bug has appeared when older versions of Docker are used to build alpine based images in alpine version 3.14. To prevent this problem from happening to the users, this PR pins the version to 3.13. The observed problem is that `make` cannot run any command and the error message states `Operation not permitted.` Removing `make` was one way to solve the problem but that would increase the diff from upstream geth. See these links for details: https://github.com/alpinelinux/docker-alpine/issues/182 https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.14.0 * fix: update statement for skipping codechecks * contracts: add set-l2-gasprice task This task allows a user to update the L2 gas price using hardhat. An example of doing so would be: ```bash $ export CONTRACTS_DEPLOYER_KEY=0x.. $ CONTRACTS_RPC_URL=https://kovan.optimism.io npx hardhat set-l2-gasprice \ --l2-gas-price 1 ``` This hardcodes the predeploy address of the `OVM_GasPriceOracle` smart contract and the Owner must be used to do the updating, otherwise the transaction will revert. * removed unused functions from core utils * [added] changeset * next gen integration tests for the OMGX stack (#149) * next gen integration tests for the OMGX stack * finish first pass integration test outline * move LP tests to the `message-relayer-fast` * Update omgx-integration.yml * add more tests to message-relayer-fast * connect up the .env variables * hard code URIs * Update utils.ts * Update omgx-integration.yml * fix - should have been 8080 * Update omgx-integration.yml * which address to use? * Update omgx-integration.yml * removing not needed code * remove superfluous logging code * Update utils.ts * Update utils.ts * additional comments and formatting improvements * fix: use older changes on tests (#152) * fix: use older structure * correct messenger * LP fees on the correct side * correct messenger * rearrange depl order Co-authored-by: Souradeep Das <dsouradeep2@gmail.com> * Update README_OMGX.md (#150) Refactored some changes and added some comments I thought might be helpful for people. Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * tests: re-enable all tests (#155) * re-enable all tests * re-enable all tests * Add solhint to contracts package * Turn off compiler-version rule in solhint * Add suggestions by @maurelian https://github.com/ethereum-optimism/optimism/pull/1033#issuecomment-866146467 * Change solhint output formatting to table * Disable contract-name-camelcase rule in solhint * Fix max-line-length linting issues in contracts * Fix quotes linting issues in contracts * Remove private-vars-leading-underscore rule in solhint * Add contracts linting to github action * Fix for hardhat account balance parsing * Disable generating the bytecodeHash in hardhat contract artifacts * Review fixes * Fix review notes * Fix smockit for a change in hardhat ^2.4.0 which changes the way it parses errors from returndata Fix provided by @smartcontracts * dtl: configurable gas price backend Adds a new config option `--l1-gas-price-backend` or `DATA_TRANSPORT_LAYER_L1_GAS_PRICE_BACKEND` that can be set to `l1` or `l2`. This impacts the behavior of the HTTP endpoint `GET /eth/gasprice` by changing what is queried to return the L1 gas price. The L1 gas price is required to compute the L2 fee since the L2 fee consists of `L1 gas price * L1 gas used + L1 gas price * L2 gas limit`. If the L1 gas price differs too much between different L2 providers, then users using `eth_estimateGas` may submit transactions with too low of a fee and be unable to submit transactions to the sequencer. By configuring the DTL to use L2 as the L1 gas price backend, it will call the Sequencer's RPC endpoint `rollup_gasPrices` which returns the L1 and L2 gas prices from the point of view of the sequencer. The L2 gas price exists in the state, so that will always be the same between the sequencer and any replicas. The L1 gas price does not live on chain, so querying for it from the sequencer directly will ensure that users send transactions with a fee that is large enough. Also adds eth/gasprice info to README. * Remove bl wl service (#154) * replace `bl-wl` with direct calls the `omgx_deployer` * Update docker-compose-omgx-services.yml * Update up_local.sh * Add CORS headers to http servers * updated frontend to use the two new HTTP servers for the addresses * update webwallet to work with both local and rinkeby * Add missing .env variables to GH actions * re-enable docker tages * re-enable wallet transaction history * Update up_local.sh * Update up_local.sh * Add flag to omgx_deployer to only serve addresses w/o deploying new contracts * Update docker-compose-omgx-services.yml * Add back tagging system and improved reliability of GH actions * removed commented out service * add rinkeby token addresses (#161) Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * fix: lint deploy-l2 folder in contracts * Add AWS integration (#159) * Add AWS integration * Remove artifacts * updated ops_omgx/README.md and added .github/workflows/deploy2aws-integration.yml and .github/workflows/push2aws.yml * add automated provision and deletion of an ec2 instance for running the integration tests Co-authored-by: Petar Denev <pdenev@gmail.com> * fix: update CI to avoid running out of memory * Version Packages * ci: release latest image tags on release * feat: update README to include info about rebasing * Add op_exporter for sequencer metrics and health endoint Added metric for sequencer health Added Dockerfile for op_exporter; Fixed Dockerfile path * merge conflicts * re-comment out the usual GH actions * feat[integration-tests]: make tests work for prod networks * chore: add changeset * Increase client_body_buffer_size for rpc-proxy Added client_max_body_size to rpc-proxy config * l2geth: use `hexutil.Big` to prevent overflows The `RollupClient` decodes the JSON from the DTL as a uint64, this updates it to be a `big.Int` Includes a test for the value field that ensures it does not overflow * ci(contracts): only run codecov if contracts package is modified In order to skip running the CodeCov job when it isn't relevant, a new job was added to the ts-packges workflow. For a PR, this job identifies all the files modified between the base branch and the tip of the PR branch, and writes to a variable which can be used to decide if subsequent jobs should run. Github Actions provides an easy method for achieving this at the level of a workflow, but not for specific jobs within a workflow. * Version Packages * chore(ci): Skip codecov on push events * feat: add workflow for running SNX test suite * go: implement gasprices package The `gasprices` package implements the logic that updates L2 gasprices on the Optimistic Ethereum Network. Co-authored-by: Karl Floersch <karl@karlfloersch.com> * gas-oracle: implement and test This commit adds the `gas-oracle` which is an offchain entity that sends transactions to L2 to update the gas price. It must be configured with a private key as the `OVM_GasPriceOracle` is owned. The `gas-oracle` is added to the changesets setup. Tests are included as well as CI. Dockerizing will happen in a follow up PR. * gas-oracle: ci + docker build/publish Adds a dockerfile for the `gas-oracle` as well as adding it as a service in the `docker-compose.yaml`. It is not enabled by default due to memory issues in CI already happening occasionally where the integration tests are oom killed. The `gas-oracle` is configured with a key that owns the `OVM_GasPriceOracle`. This PR adds the `gas-oracle` to the Github Actions workflow that is responsible for publishing the docker images. * Add replica (#169) * fix: update erc20 deposits (#166) * fix: update erc20 deposits * fix: auto default token Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * resolve merge conflicts * Update docker-compose.yml * Update docker-compose.yml * [pull] develop from ethereum-optimism:develop (#164) * contracts: add set-l2-gasprice task This task allows a user to update the L2 gas price using hardhat. An example of doing so would be: ```bash $ export CONTRACTS_DEPLOYER_KEY=0x.. $ CONTRACTS_RPC_URL=https://kovan.optimism.io npx hardhat set-l2-gasprice \ --l2-gas-price 1 ``` This hardcodes the predeploy address of the `OVM_GasPriceOracle` smart contract and the Owner must be used to do the updating, otherwise the transaction will revert. * Add op_exporter for sequencer metrics and health endoint Added metric for sequencer health Added Dockerfile for op_exporter; Fixed Dockerfile path * feat[integration-tests]: make tests work for prod networks * chore: add changeset * Increase client_body_buffer_size for rpc-proxy Added client_max_body_size to rpc-proxy config * l2geth: use `hexutil.Big` to prevent overflows The `RollupClient` decodes the JSON from the DTL as a uint64, this updates it to be a `big.Int` Includes a test for the value field that ensures it does not overflow * ci(contracts): only run codecov if contracts package is modified In order to skip running the CodeCov job when it isn't relevant, a new job was added to the ts-packges workflow. For a PR, this job identifies all the files modified between the base branch and the tip of the PR branch, and writes to a variable which can be used to decide if subsequent jobs should run. Github Actions provides an easy method for achieving this at the level of a workflow, but not for specific jobs within a workflow. * Version Packages * chore(ci): Skip codecov on push events * feat: add workflow for running SNX test suite * go: implement gasprices package The `gasprices` package implements the logic that updates L2 gasprices on the Optimistic Ethereum Network. Co-authored-by: Karl Floersch <karl@karlfloersch.com> * gas-oracle: implement and test This commit adds the `gas-oracle` which is an offchain entity that sends transactions to L2 to update the gas price. It must be configured with a private key as the `OVM_GasPriceOracle` is owned. The `gas-oracle` is added to the changesets setup. Tests are included as well as CI. Dockerizing will happen in a follow up PR. * gas-oracle: ci + docker build/publish Adds a dockerfile for the `gas-oracle` as well as adding it as a service in the `docker-compose.yaml`. It is not enabled by default due to memory issues in CI already happening occasionally where the integration tests are oom killed. The `gas-oracle` is configured with a key that owns the `OVM_GasPriceOracle`. This PR adds the `gas-oracle` to the Github Actions workflow that is responsible for publishing the docker images. Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Ben Wilson <bwilson@optimism.io> Co-authored-by: Kelvin Fichter <kelvin@optimism.io> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: Ben Wilson <82120899+optimisticben@users.noreply.github.com> Co-authored-by: Kevin Ho <kevinjho1996@gmail.com> Co-authored-by: Liam Horne <li…

* tests: replica syncing (#981) * [wip] add l2_dtl and replica images * passing basic dummy tx test * add erc20 test * add sync test to ci Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> * fix[relayer]: update exported files list in package.json (#1138) * fix[relayer]: update exported files * chore: add changeset * fix: import path (#1141) * fix: correct import path for altered contract path * chore: add changeset * refactor: improve logging for batch submission timeout scenarios (#1120) * Fixed CrossDomainMessenger name (#96) * Add highest L1 and L2 block number Gauge metrics to DTL (#1125) * build: add prom-client to data-transport-layer * refactor: thread metrics more carefully through data-transport-layer; add two new metrics * style: fix some style issues * refactor: make metrics mandatory * refactor: move metrics register code to top of file * style: apply linting * refactor: move promethesus initialization after express * refactor: move promBundle call up, provide registry * build: add changeset * Improve Watcher ability to find transactions (#1107) * remove listeners and use loop to find tx receipt * add yarn ready * moved filters inside loop * [added] changeset * Add minimal vscode settings and extensions (#1109) * chore: add minimal vscode settings and extensions * chore: Add "files.trimTrailingWhitespace" to vscode native config * chore: replace vscode prettier plugin with eslint plugin * fix[contracts]: remove part of MultiMessageRelayer deployment (#1144) * fix[contracts]: remove part of MultiMessageRelayer deployment * chore: add changeset * Define L1 Starting block via OwnershipTransferred rather than AddressSet (#1129) * Update service.ts * Create thirty-years-look.md Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * Easy fix for broken watchers (#1121) * Easy fix for broken watchers * Ran yarn changeset Co-authored-by: Liam Horne <liam@lihorne.com> * feat: go packages (#1111) * go: add utils module * readme: update * Version Packages (#1094) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * build: add husky pre-commit hook to lint (#1146) * feat[contracts]: add mainnet deploy script (#1147) * Add mainnet deploy script * Update mainnet.sh * Address PR review feedback * feat: mainnet contract deployment 0.4.0 (#1148) * feat: mainnet contract deployment 0.4.0 * feat: deployments readme * chore: add changeset * contracts: remove dead contract * contracts: remove dead config * tests: fix to not test for old contracts * feat: `rollup gasPrices` RPC endpoint (#1136) * feature: l2geth endpoint * chore: add changeset Co-authored-by: Liam Horne <liam@lihorne.com> * Adds l2 standard bridge to contracts markdown file (#1151) * Version Packages (#1150) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add more info about our branching strategy to the README (#1114) * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Remove references to OVM_L1ETHGateway in deployments and readme (#1119) * Keep the user logged in after changing chain (#99) * Keep the user logged in after changing chain * Update Nft.js * Detect if user is in the wrong chain Co-authored-by: cby3149 <cby3149@outlook.com> Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * Merge conflics resolve (#110) * wip * gethl2 * wip * batch submitter * core utils * DTL * message relayer * contracts * wip * Update service.ts * DTL * messaage-relayer * Update yarn.lock * final 5 files * [pull] develop from ethereum-optimism:develop (#91) * chore: reduce hardhat timeout to 20 seconds (#968) * fix: force LF line endings for scripts to avoid docker problems on Windows (#974) * fix: use correct line endings for windows * chore: add changeset * refactor[contracts]: Turn ExecutionManagerWrapper into a predeployed contract (#808) * wip: Started working on L2 contract testing revamp * test: clean tests for ProxyEOA * style: clean imports for ProxyEOA tests * test: port tests for ECDSAContractAccount * fix tests and add wrapper to dump * fix: add em wrapper to l2 deploy * ffix: add comments to wrapper contract * fix: add more comments * fix: add smock comment for unbind * Update packages/smock/src/smockit/binding.ts * maintenance[contracts]: use dashes in chain container names (#819) * maintenance: use dashes in chain container names * chore: add changeset * feat[contracts]: temporarily disable EOA upgrades (#857) * feat[contracts]: disable eoa upgrades temporarily * chore: add changeset * Update OVM_ProxyEOA.sol * fix: turn upgrade into a noop * lint: fix * feat[contracts]: Update Lib_AddressManager.AddressSet event to speed up data transport layer (#820) * feat: update and improve AddressSet event * chore: add changeset * Update Lib_AddressManager.sol * Reduce gas costs of deposits (#667) * Remove messageNonce from BaseCrossDomainMessenger and use CTC queue lenght instead Remove Abs_BaseCrossDomainMessenger and restore dedicated nonce generation in OVM_L2CrossDomainMessenger Fix typo * Remove sentMessages mapping from L1CrossDomainMessenger storage and use the nonce to check for existence of replayed transaction * Refactor out common library function for getting cross domain calldata * Post rebase fixes * Use the queueIndex to check the transaction was enqueued * Fix tests for L1CrossDomainMessenger.replayMessage Also make that test work with an actual CanonicalTransactionChain implementation rather than a smock * Lint fixes * Optimise the resolve calls into the AddressManager lib * Rename the nonce parameter to be clear * Update test name Co-authored-by: ben-chain <ben@pseudonym.party> * Rename getXDomainCalldata to encodeXDomainCalldata to match the new Lib_CrossDomainUtils Co-authored-by: ben-chain <ben@pseudonym.party> * optimism: bump gaslimit to 10 million #870 (#871) * optimism: bump gaslimit to 10million * chore: add changeset * optimism: bump max gaslimit to 10 mil * chore: add changeset * chore: remove unnecessary changeset * chore: remove unnecessary changeset Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * fix: use correct contract name in tests (#921) * fix: disable upgradability from ECDSA Account (#885) * l2geth: remove `SignatureHashType` (#752) * l2geth: remove tx type * l2geth: no longer parse type in rollup client * chore: add changeset * chore: remove extra sighash params * fix: do not check txtype in integration tests Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * feat[contracts]: introduce OVM_GasPriceOracle (#912) * feat[contracts]: congestion price oracle * chore: add changeset * contracts: gas price oracle (#917) * contracts: gas price oracle * tests: update * fees: fix tests * contracts: simplify gas price oracle * lint: fix * test: execution price is at the 1st storage slot * chore: rename predeploy to GasPriceOracle * chore: rename gas price oracle test name Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * fix: configure max gas limit to 11m (#928) Uniswap V3 contracts require that, otherwise they throw call exceptions at deployment * Consolidate Predeploy Addresses (#931) * added library for predeploy addresses * refactor tests and other packages to use exported predeploys * revert library usage in OVM_ECDSAContractAccount * lint * added newline * fixed address typos Co-authored-by: rajivpo <rajivpatel-oconnor@Rajivs-MacBook-Pro-2.local> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * chore: remove yarn-error.log and gitignore it (#956) * feat[contracts]: Replace Lib_RingBuffer with a much simpler Lib_Buffer (#821) * feat[contracts]: replace Lib_RingBuffer with a simpler Lib_Buffer * chore: changeset * test: add tests for Lib_Buffer * lint: fix * test: add extra coverage for Lib_Buffer * Update packages/contracts/contracts/optimistic-ethereum/libraries/utils/Lib_Buffer.sol Co-authored-by: ben-chain <ben@pseudonym.party> * add some extra comments Co-authored-by: ben-chain <ben@pseudonym.party> * fix(contracts): import predeploys (#982) * fix(contracts): import predeploys * fix: lint * feat: add hardhat deploy instructions to readme (#965) * feat: add deployment instructions to readme * Add changeset * fix style * Update README.md * feat: fees v2 (#976) * l2 geth: new fee logic * l2 geth: migrate to fees package * core-utils: new fee scheme * chore: add changeset * l2geth: delete dead code * integration-tests: fix typo * integration-tests: fixes * fees: use fee scalar * lint: fix * rollup: correct gas payment comparison * fix(integration-tests): do not hardcode gas price * core-utils: update with new scheme * l2geth: refactor rollup oracle * l2geth: clean up DoEstimateGas * l2geth: implement latest scheme * tests: fix up * lint: fix * l2geth: better sycn service test * optimism: rename to TxGasLimit * fee: fix docstring * tests: fix * variables: rename * l2geth: prevent users from sending txs with too high of a fee * integration-tests: fix import * integration-tests: fix type * integration-tests: fix gas limits * lint: fix * l2geth: log error Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * Add static analysis action (#848) * Add static analysis github action setup python and install slither * Add nvmrc file for setting node to v14.17 * Update slither command run to link missing contract packages from monorepo root * Add steps for installing dependencies * Add yarn build step to github action * Enable colour in github action for static analysis * Disable certain detectors * Ensure slither does not fail build * Add instructions on running static analysis to monorepo readme * build(deps): bump ws from 7.4.4 to 7.4.6 in /ops/docker/hardhat (#987) Bumps [ws](https://github.com/websockets/ws) from 7.4.4 to 7.4.6. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](https://github.com/websockets/ws/compare/7.4.4...7.4.6) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix[l2geth]: fix accidental merge conflict (#994) * feat[message-relayer]: relay tx generator (#952) * feat[message-relayer]: relay tx generator * whoops, I burned our infura key * fix minor bug * add comments * add more comments and clean stuff up * add empty test descriptions * add tests * move smock to dev deps * chore: add changeset * minor cleanup to merkle tree proof function * use bignumber math to avoid nested await * use a better interface * minor fixes and simplifications * backwards compatible dtl syncing (#986) * kovan: fix attempt * kovan: db fix * kovan: types are strings from db * l2geth: parse things as strings * chore: add changeset * dtl: also stringify the range query * geth: dereference * geth: assign err * dtl: handle null * dtl: fix unit tests * fix[smock]: fix broken call assertions for overloaded functions (#996) * fix[smock]: fix broken call assertions for overloaded functions * chore: add changeset * minor correction and add a test * add a test for non-overloaded functions * fix[message-relayer]: fix failing test because of merge with develop (#1000) * fix[message-relayer]: remove spreadsheet mode (#998) * fix[message-relayer]: remove spreadsheet mode * chore: add changeset * Lower local rollup timestamp refresh (#985) * update rollup timestamp refresh * increase refresh time to 5s * feat: fees v3 (#999) * core-utils: fee impl v3 * l2geth: fees v3 impl * integration-tests: update for fees v3 * chore: add changeset * fix: typo * integration-tests: fix and generalize * fees: update fee scalar * l2geth: check gas in the mempool behind usingovm * tests: fix up * l2geth: remove dead var * truffle: fix config * fix: remove dead coders (#1001) * chore: delete dead coders * chore: add changeset * dtl: remove dead imports * core-utils: delete dead tests * batch-submitter: remove txtype * chore: add changeset * docs[message-relayer]: add a README and improve the interface for generating proofs (#1002) * docs[message-relayer]: add basic docs and clean up an interface * chore: add changeset * dtl: log error stack for failed http request (#995) * dtl: log error stack for failed http request * chore: add changeset * Add rpc-proxy service for whitelisting JSON RPC methods to the sequencer. (#945) * Add healthcheck endpoint for rpc-proxy Added ethereum-nginx-proxy source updated README and docker image build * Check ETH_CALLS_ALLOWED is set, clean up comments, remove old Dockerfile * Pass additional information across domains via token gateways (#824) * feat(contracts): add from and data args to L1ERC20Gateway fix(integration): add gasLimit to fundUser refactor(contracts): add data to gateway events add changeset fix(integration): provide data in outboundTransfer refactor(contracts): reset Abs_L2TokenGateway to Abs_L2DepositedToken refactor(contracts): fix mismatched names * feat[contracts]: add custom gas arg to gateway fix(contracts): take max of user vs. default gas * fix(integrations): update ovm-eth function call * fix(integration): remove unecessary explicit gasLimit * test(contracts): 32kb transfer, 9MM gas * fix(contracts): fixup comment, bytes arg last * fix(integration): args order in integrations * fix(contracts): remove unused L2 gas arg * fix(contracts): limit data that can be passed to L2 * fix(integration): better tests for data length * test: check for error on too large data * Experimental: specify gaslimit in before hook * fix(integration): add l2 gas argument * fix: increase gas on fundUser * fix(contracts): remove duplicate max size limit * fix(integration): fine tune gas amounts * lint * fix: large data test * fix(integration): set gas closer to real cost * fix(contracts): remove unused bridge variables These variables were the default gas amounts for cross domain messages * fix(contracts): Reorder args Place dynamic length args last * fix(integration): update estimateGas values * fix(integration): reset eth withdraw estimate to 21000 * fix(integration): update expected gas amount * fix(integration): reduce gas amount for ETH withdraw * More consistent style for Constant values (#991) * chore(contracts): make container addresses be constants chore(contracts): consistent style for constant vars * chore(contracts): add internal on predeploy constants * feat: deployment config for fee oracle contract (#936) * feat[contracts]: add GasPriceOracle w/o predeploy Based on #912 * feat[contracts]: congestion price oracle * chore: add changeset * contracts: gas price oracle (#917) * contracts: gas price oracle * tests: update * fees: fix tests * contracts: simplify gas price oracle * lint: fix * test: execution price is at the 1st storage slot * chore: rename predeploy to GasPriceOracle * chore: rename gas price oracle test name Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * Add an L2 deploy script for gas oracle contract * Add a kovan deployment artifact * Add deployment to readme * Add extra validation & initial execution price * Update README.md * Fix execution price logic * Perform new deployment with final contract * contracts: better require in ovm gas price oracle * Deploy L2GasPriceOracle * Update contract to use new fee logic & rename to gas * Deploy updated contract * Fix lint * gas price oracle: do not restrict gas price * gas price oracle: new deployment * tests: delete dead test Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * ops: expose debug namespace (#1007) * develop merge fixes * refactor[l2geth]: queue origin type (#975) * refactor: queueOrigin type * Convert queueOrigin to uint8 in encode * Add changeset * Regenerate json marshall * style: combine lines * Add Stringer for QueueOrigin * Turn QueueOrigin into uint8 * l2geth: gen tx meta fix * l2geth: gen tx meta fix * lint Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> * fix(sync-service): prevent underflows (#1015) * fix(sync-service): prevent underflows * chore: add changeset * chore: remove dead confirmation depth * chore: remove eth1conf depth from rollup config * test: remove duplicate value in array (#1014) * ci: tag docker image for canary with abbreviated GITHUB_SHA (#1006) * ci: tag docker image for canary with abbreviated GITHUB_SHA * ci: update from 6 bytes to 8 bytes of abbreviation * refactor: improve logging for transactions being submitted to chain with gasPrice (#1016) * refactor: improve logging for transactions being submitted to chain with gasPrice * lint: apply lint autofixes * dtl: remove stringify from db logic + more overflow protection (#1010) * dtl: remove stringify from db logic * l2geth: overflow protection * dtl: overflow protection * chore: add changeset * ci: upload logs for failed integration tests (#1020) * fix(dtl): improve slow blocking JSON parsing that occurs during l2 sync (#1019) The use of eth_getBlockRange returns a large response which is very slow to parse in ethersjs, and can block the event loop for upwards of multiple seconds. When this happens, incoming http requests will likely timeout and fail. Instead, we will parse the incoming http stream directly with the bfj package, which yields the event loop periodically so that we don't fail to serve requests. * fix: lint errors in dtl (#1025) * fix[dtl]: fix dtl bug breaking verifiers (#1011) * fix[dtl]: fix dtl bug breaking verifiers * tweaks so tests pass * chore: add changeset * fix: deterministic blockhashes (#1032) * config: set etherbase * l2geth: add deterministic clique key * l2geth: default value * chore: add changeset * test: add sync test for deterministic blockhash Co-authored-by: Kevin Ho <kevinjho1996@gmail.com> * Version Packages (#978) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * ci: add sync test's own workflow (#1031) * fix(dtl): incorrect parsing of eth_getBlockRange result (#1037) * Version Packages (#1045) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: no gas refund (#1043) * l2geth: remove the gas refund * chore: add changeset * refactor[contracts]: remove one-off GasPriceOracle deployment file (#1046) * refactor[contracts]: remove one-off gpo deployment * chore: add changeset * feat[contracts]: introduce new L1ChugSplashProxy contract (#1009) * feat[contracts]: add L1ChugSplashProxy * improve comments slightly * start adding tests * add more tests * make the system pausable * added another test * add some extra comments * Update packages/contracts/test/contracts/chugsplash/L1ChugSplashProxy.spec.ts Co-authored-by: Maurelian <maurelian@protonmail.ch> * Update packages/contracts/test/contracts/chugsplash/L1ChugSplashProxy.spec.ts Co-authored-by: Maurelian <maurelian@protonmail.ch> * chore: add changeset * address review feedback Co-authored-by: Maurelian <maurelian@protonmail.ch> * feat[contracts]: add sequencer fee wallet (#1029) * wip: first draft of the fee wallet * add fee wallet to dump * rename to sequencer vault * add L1 fee wallet to geth config * add unit tests * fix geth linting error * add a basic integration test * fix broken integration test * add test for correct storage slot * add integration test for fee withdrawal * fix typo in integration tests * fix a bug bin integration tests * Update OVM_SequencerFeeVault.sol * fix bug in contract tests * chore: add changeset * fix bug in contract tests * build(deps): bump glob-parent from 5.1.1 to 5.1.2 (#1036) Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2. - [Release notes](https://github.com/gulpjs/glob-parent/releases) - [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md) - [Commits](https://github.com/gulpjs/glob-parent/compare/v5.1.1...v5.1.2) --- updated-dependencies: - dependency-name: glob-parent dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: Liam Horne <liam@lihorne.com> * fix: predeploy gasprice oracle (#1039) * l2geth: delete extra config options * l2geth: stop using extra config options * l2geth: more stop using extra config options * chore: add changeset * l2geth: add new config for gpo owner * chore: add changeset * l2geth: fix tests * tests: fix build * l2geth: optimize loops (#1027) * l2geth: optimize loops * l2geth: stop ticker when done * l2geth: don't wait for first tick * chore: add changeset * Enable custom tagging of release docker image (#1048) * ci: enable custom tagging of release docker image * ci: refactor to add prerelease prefix for secuirty * doc: typo * ci: fix indentation issue of canary workflow * ci: fix typo with GITHUB_SHA * fix: typo in USE_HARDHAT config (#1023) * fix: abi encoded tx (#1049) * contracts: don't double rlp decode * chore: add changeset * lint: fix * deps: update * linting: cleanup * feat: contracts: use selector * fix: contracts: use typescript * contracts: use interface * l2geth: bump to go 1.15 (#1058) * l2geth: bump to go 1.15 * chore: add changeset * Change monotonicity band-aid code to log warnings not errors (#1060) * refactor: change monotonicity band-aid code to log warnings not errors * build: add changeset * feat(contracts, l2geth): native ETH value support for ovmCALL (#1038) * feat(contracts): add ovmCALL-types with native value * add ovmCALLVALUE context * add ovmBALANCE * test success and revert cases * test empty contract case * chore: lint * test(integration-tests): ovmCALL-types with value (compiler and wrapper) * fix ovmDELEGATECALL type, update tests * add ovmSELFBALANCE * fix ovmDELEGATECALL jumping to CALL * chore: lint * fix(contracts): account for intrinsic gas of OVM_ETH sends * fix(contracts): merge conflict bug * fix(contracts): update gas benchmark * feat(contracts, integration-tests): use new value-compatible compiler * feat(contracts,l2geth): support value calls in OVM_ECDSAContractAccount * fix(contracts): ovmDELEGATECALL does not change message context * feat(contracts): sending value between EOAs * test(integration-tests): ovmDELEGATECALL preserves ovmCALLVALUE * test(integration-tests): assert ovmSELFBALANCEs correct * test(integration-tests): intrinsic gas for eth value calls * test(integration-tests): update gas values * chore(contracts): lint * feat(contracts, l2geth): eth_calls with nonzero value * chore: minor fixups and comments based on PR feedback * test(integration-tests): add requested tests from PR reviews * test(integration-tests): ovmSELFBALANCE is preserved in ovmDELEGATECALLs * fix(contracts): fix bug where ovmDELEGATECALL could fail if balance was lower than the ovmCALLVALUE * chore: add changeset * fix(contracts): update intrinsic gas for worst-case value sends * chore: address final PR nits/improvements Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> * Add erc1271 support to contract account (#1052) * add ERC1271 support, failing unit tests * add integration test for isValidSignature * remove .only * lint * add changeset * clean up 1271 tests and lint * switch back to using waffle wallet * lint * fix import * feat[contracts]: slightly better account funding for hardhat accounts (rebased) (#1065) * feat[contracts]: better account funding for hardhat accounts * add a sleep to avoid any potential problems * chore: add changeset * fix: bug with gas estimation in funding step * fix: limit to 20 accounts max Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> * Ensure Sentry is correctly set up for DTL and MR (#1054) * refactor: add logger and metrics to options for BaseService * refactor: thread sentryOptions through from message-relayer into BaseService * refactor: ensure DTL Logger is using Sentry for errors * style: lint base-service.ts * refactor: init Sentry on batch-submitter too * refactor: init Sentry on message-relayer too * refactor: pass in basic logger to MessageRelayerService * build: provide changeset * fix: correct usage of use-sentry boolean config * refactor: appropriately type loggingOptions * build: add @sentry/node * build: add @sentry/node to message-relayer and fix linting issue * Add more logging information to monotonicity violation logs (#1066) * refactor: log idx of monotonicity violation from batch * build: add changeset * temporarily disable hardhat example tests (#1071) * fix: monotonicity auto healer (#1070) * fix: monotonicity auto healer * add: changeset * Version Packages (#1053) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Standard token bridge (#988) * Remove abstract token gateway and deposited token implementations * Further simplification of bridge contracts * Standart token bridge and L2 token implementation * Fix spacing * Implement case when a bad deposit happens to a nonexistent L1<>L2 token pair * Use SafeMath in common token bridge accounting * test(contracts): fix finalizeWithdrawal test * fix(contracts): use SafeERC20 on token deposits * Rename OVM_L1ERC20Gateway to OVM_L1ERC20Bridge contract * Rename iOVM_L1ERC20Gateway to iOVM_L1ERC20Bridge contract * Cleanup gateway to bridge rename * Better name for the mapping holding l1->l2 deposit amounts * Use OZ SafeMath * Rename local variables in OVM_L2DepositedERC20 from gateway to bridge * Merge ETH and ERC20 bridge contracts * Rename OVM_L1ERC20Bridge to OVM_L1StandardBridge and fix tests from merging the ETH and ERC20 bridges * Better name for iAbs_BaseCrossDomainMessenger -> iOVM_CrossDomainMessenger * Correct the bounce back of deposit sender and recipient properties * Remove obsoleted event from OVM_L2DepositedERC20 * chore(contracts): change references from ETHGateway to Bridge * Fix a linting error * fix(contracts): add bridge to deployer * Split off ERC20Bridge interface for the purposes of being reused in custom ERC20 bridges * Split off interface natspec definitions * Draft version of OVM_L2DepositedERC20 splitted into a standard L2 erc20: L2StandardERC20 and a common L2 bridge: OVM_L2StandardBridge * style(contracts): define L1_ETH_ADDRESS as constant * test(integration): update interface to use depositETH * test(contracts): fix OVM_L1StandardBridge tests * test(contracts): fix L2 Standard Bridge tests * test(contracts): lint and remove an obsolete test case * Fix modifier check to comply with the L2 bridge distinction from L2 token * Simplify address <> interface casting in bridges * Ensure natspec comments are correct also add l1 and l2 token params to WithdrawalInitiated event for consistency * Fix issues in L1 and L2 bridges to ensure cross domain messages are sent only between the two bridges also adjusted withdrawals to send to either finalizeETHWithdrawal or finalizeERC20Withdrawal depending on which asset is being withdrawn * Remove AddressManager from the L1 standard bridge * REVERT ME: instruments cross domain enabled * fix(contracts): remove Address Manager from L1 Bridge * feat(contracts): make L2 Standard Bridge a predeploy * WIP: update deployments for standard bridges * WIP: update deployments for standard bridges * l2geth: TEMP log contract calls * chore(l2geth): replace eth gateway with standard bridge * fix(contracts): make contract-deployment/config work * WIP fix(integration): update integration tests for bridge * Remove ovmEth from L1 Standard bridge as obsoleted * Separate ERC20 standard implementation from L2 bridge * Formatting fixes * chore(l2geth): replace eth gateway with standard bridge * Revert "REVERT ME: instruments cross domain enabled" This reverts commit d5bb8f8f67974d0a3e65fc000f08858328a4bbbc. * fix: lint ts * Implement EIP-165 in the Standard L2 ERC20 token Also switch that to be based off the OpenZeppelin default implementation plus mint and burn Additionally remove the obsoleted iOVM_ERC20 * fix(contracts): add deployment check on bridge proxy fix(contracts): whitespace fix(contracts): init bridge implementation with non-zero address * Remove dependency on Ownable contract for the StandardERC20 token on L2 * fix(contracts): update deployment scripts * fix: lint * remove debugging code * fix: correct rpc get balance slot * restore l2 cross domain messenger * fix: lint * Add a test for a non compliant token deposit * Only allow EOAs to deposit ETH and ERC20 * Add comments and tests for ERC165 implementation * Decide against using explicit ETH MOCK address as we're not using it for checks * Fix linting issues * Add onlyEOAContract restriction to standard bridge withdrawals * Update codehashes in L2 Standard bridge * fix(ops): remove unintentionally added file * feat(contracts): add expectApproxGasCost function * fix(integration): proper arrayify input on fundUser * fix(integration): proper gas value checks * Revert "Add onlyEOAContract restriction to standard bridge withdrawals" This reverts commit 2713c06ceb2609e4f13718e1034a4d76210d9758. * fix(contracts): removed unused expectApproxGasCost for now * fix(contracts): update OVM_SequencerFeeVault for bridge changes * lint * Update deployment for L1 Bridge w/ ChugSplash * Revert "l2geth: TEMP log contract calls" This reverts commit 21d42259278449f221bf34605162229b3d9d4fa9. * Apply suggestions from code review * Apply suggestions from code review * fix(contracts): deploy with chugsplash proxy * fix(contracts): add working bridge and chugsplash proxy deployment * fix(contracts,integration): 500k gas for depositETH * comment(contracts): describe failed deposit handling on l2 * Apply suggestions from code review Co-authored-by: ben-chain <ben@pseudonym.party> * docs: add changeset * fix(integration): set working l2 gas amount on funduser * test(integration): add receive() test * fix(contracts): reset receive to 1.2MM l2 gas * test(examples): skip l1-l2 example test for now * fix(contracts): drop hardcoded gas to 500k in receive() * fix(contracts): use abi.encodeWithSignature * fix(contracts): resolve merge conflicts * feat(integration): add expectApprox for flexible gas testing * fix(integration): fix failing gas tests * fix: incorrect l2 gas for deposit * Update utils.ts * fix(workflow): disable l1-l2 example until npm imports are fixed * chore: final round of PR review nits and tests Co-authored-by: Maurelian <maurelian@protonmail.ch> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: ben-chain <ben@pseudonym.party> Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> * fix: comment out codeowners (#1073) * fix: use predeploy constant lib for em wrapper (#1075) * fix: use predeploy constant lib for em wrapper * chore: add changeset * fix[l2geth]: off-by-one sometimes breaking replica sync (#1082) * fix[l2geth]: off-by-one sometimes breaking replica sync * chore: add changeset * fix(l2geth): Log 'end of OVM execution' correctly (#1080) * refactor[contracts]: move account contracts to predeploy folder (#1085) * refactor[contracts]: move account contracts to predeploy folder * chore: add changeset * maintenance[contracts]: rename precompiles test folder to predeploys (#1086) * fix[bs]: disambiguate generic submission errors (#1051) * fix[bs]: disambiguate generic submission errors * add cases for errors * separate out errors from transaction reverts with reasons * remove extraneous errors * WETH deposit and withdraw on OVM_ETH (#1083) * feat(contracts): add no-op WETH9 functionality to OVM_ETH * working WETH deposit and withdraw + tests * add changeset * address PR feedback * update WETH9 contract implementation * add fallback to WETH9 * add fallback and revert withdraw test * update nit comment Co-authored-by: ben <ben@pseudonym.party> * Also move the accounts interface to iOVM/predeploys (#1087) * refactor[contracts]: move account interface to predeploy folder * chore: add changeset * Version Packages (#1089) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: use -z flag for var unset in canary * Use Eslint instead of Tslint (#1005) * removed tslint * forgot to commit files * made .eslintrc.js consistent for all subdirs and other cleanup * [removed] includes and files keys from tsconfig.json * removed file level linting exceptions and added details to line level * added changeset * fixed newly introduced linting errors from rebase * enable json import for batch submitter * removed ecdsa-coder * maybe a tsconfig issue? * Update deploy.ts Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: platocrat <37757724+platocrat@users.noreply.github.com> * metrics[batch-submitter]: add new batch submitter metrics (#1074) * metrics[batch-submitter]: add new batch submitter metrics * chore: changeset * account for failed submissions * Fix canary publishing (#1093) * ci: fix custom docker tag * ci: use new env file * ci: use outputs from previous job * ci: fix headers of jobs * ci: inherit canary tag from builder * feat[ci]: upload logs for sync tests if failure (#1098) * deploy: goerli 0.4.0 (#1099) * deployments: goerli 0.4.0 rc * readme: update * chore: add changeset * fix[dtl]: defend against RPC provider missing events (#1084) * fix[dtl]: defend against RPC provider missing events * chore: add changeset * respond to review comments * better error handling for missing handlers * deploy: kovan v.4.0 rc (#1101) * deploy: kovan v0.4.0 rc * chore: add changeset * readme: update * maintenance[monorepo]: first pass update to README (#1106) * maintenance[monorepo]: first pass update to README Doing some relatively minor updates to the README just to clean things up a bit. * replying to review comments * Move the metric prefix string to a label (#1047) Added changeset and fixes Changeset to patch * fix[smock]: add support for hardhat 2.4.0 (#1112) * fix[smock]: add support for hardhat 2.4.0 * chore: add changeset * lint: fix * build(deps): bump hosted-git-info from 2.8.8 to 2.8.9 (#1064) Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](https://github.com/npm/hosted-git-info/compare/v2.8.8...v2.8.9) --- updated-dependencies: - dependency-name: hosted-git-info dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * Misc. small improvements to README (#1115) * Update README.md * Update README.md * fix[dtl]: use the same L2 chain ID everywhere (#1122) * fix[dtl]: use the same L2 chain ID everywhere * chore: add changeset * fix: make sync tests only on workflow dispatch (#1123) * fix[dtl]: remove old stringification function (#1134) * fix[dtl]: remove old stringification function * chore: add changeset * fix[dtl]: log server errors as ERROR instead of INFO (#1133) * fix[dtl]: log server errors as ERROR instead of INFO * chore: add changeset * Contracts: connectL1Contracts & connectL2Contracts (#713) * Contracts: connect-contracts * Trying to resolve build problems * connect-contracts build working * Adds artifacts-ovm back to gitignore * Removes incorrect changes * Adds copy-artifacts script * Adds test file (not working yet) * fix: incorrect contract instantiation * Improves tests and removes old deployment versions * Single source of truth for predeploy addresses * Reverts deployments/README.md * Makes connect-contracts more DRY * Adds missing @ethersproject/abstract-signer dependency * Adds argument evaluation * Adds L1Contracts and L2Contracts types * Attempts removing artifacts-ovm again * Adds webpack config (not working yet) * build: add artifacts to dist (#776) * Updates lint rule * Adds l2 imports * Fixes dependency tree bug * Removes webpack stuff * Fixing package.json issues and adds .DS_Store to gitignore * Removes test-contracts script * Reverting script change * Adds comments * Adds comment * Renames deployments folders * Fixes linting errors * Generates markdown * build: add deployments directory to Dockerfiles * Removes unneeded contracts, improves error handling and tests * Adds changeset * yarn.lock * Removes console.log * Changes from minor to patch version * Fixes lint errors Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * fix: prevent overflow in abi encoding (#1135) * l2geth: prevent overflow in abi encoding to ovm codec tx * chore: add changeset * tests: replica syncing (#981) * [wip] add l2_dtl and replica images * passing basic dummy tx test * add erc20 test * add sync test to ci Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> * fix[relayer]: update exported files list in package.json (#1138) * fix[relayer]: update exported files * chore: add changeset * fix: import path (#1141) * fix: correct import path for altered contract path * chore: add changeset * refactor: improve logging for batch submission timeout scenarios (#1120) * Add highest L1 and L2 block number Gauge metrics to DTL (#1125) * build: add prom-client to data-transport-layer * refactor: thread metrics more carefully through data-transport-layer; add two new metrics * style: fix some style issues * refactor: make metrics mandatory * refactor: move metrics register code to top of file * style: apply linting * refactor: move promethesus initialization after express * refactor: move promBundle call up, provide registry * build: add changeset * Improve Watcher ability to find transactions (#1107) * remove listeners and use loop to find tx receipt * add yarn ready * moved filters inside loop * [added] changeset * Add minimal vscode settings and extensions (#1109) * chore: add minimal vscode settings and extensions * chore: Add "files.trimTrailingWhitespace" to vscode native config * chore: replace vscode prettier plugin with eslint plugin * fix[contracts]: remove part of MultiMessageRelayer deployment (#1144) * fix[contracts]: remove part of MultiMessageRelayer deployment * chore: add changeset * Define L1 Starting block via OwnershipTransferred rather than AddressSet (#1129) * Update service.ts * Create thirty-years-look.md Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * Easy fix for broken watchers (#1121) * Easy fix for broken watchers * Ran yarn changeset Co-authored-by: Liam Horne <liam@lihorne.com> * feat: go packages (#1111) * go: add utils module * readme: update * Version Packages (#1094) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * build: add husky pre-commit hook to lint (#1146) * feat[contracts]: add mainnet deploy script (#1147) * Add mainnet deploy script * Update mainnet.sh * Address PR review feedback * feat: mainnet contract deployment 0.4.0 (#1148) * feat: mainnet contract deployment 0.4.0 * feat: deployments readme * chore: add changeset * contracts: remove dead contract * contracts: remove dead config * tests: fix to not test for old contracts * feat: `rollup gasPrices` RPC endpoint (#1136) * feature: l2geth endpoint * chore: add changeset Co-authored-by: Liam Horne <liam@lihorne.com> * Adds l2 standard bridge to contracts markdown file (#1151) * Version Packages (#1150) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add more info about our branching strategy to the README (#1114) * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Remove references to OVM_L1ETHGateway in deployments and readme (#1119) Co-authored-by: Maurelian <maurelian@protonmail.ch> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: Elena Gesheva <elena@arenabg.com> Co-authored-by: ben-chain <ben@pseudonym.party> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> Co-authored-by: Karl Floersch <karl@karlfloersch.com> Co-authored-by: Rajiv Patel-O'Connor <rajiv.patel.oconnor@gmail.com> Co-authored-by: rajivpo <rajivpatel-oconnor@Rajivs-MacBook-Pro-2.local> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kevin Ho <kevinjho1996@gmail.com> Co-authored-by: Ben Wilson <82120899+optimisticben@users.noreply.github.com> Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: Tim Myers <timmyers09@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Annie Ke <annieke8@gmail.com> Co-authored-by: platocrat <37757724+platocrat@users.noreply.github.com> Co-authored-by: Matt Masurka <m.masurka@gmail.com> Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> Co-authored-by: Alejandro Santander <Palebluedot@gmail.com> * Re-apply key changes on top of optimism most current develop * Add docker-compose-replica.yml (#109) * Create docker-compose-replica.yml * Add replica service * Update docker-compose-omgx-replica.yml Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * fix linter; patch gethl2 * configure the deployer correctly * fix proposer / batch submitter * update chainIDs * update rpc test * Create README_OMGX.md * upstream - needs more work * Adds delay to watcher (#1159) * Adds delay to watcher * Simplifies delay * Adds changeset * Fix wallet test * Fix deployment test * Add Python * Update Dockerfile.omgx_monorepo * Remove package-lock * fix: bind dtl functions for missing event codepath (#1161) * dtl: bind this in L1 missing element error handlers * dtl: add additional logline * chore: add changeset * dtl: add more metrics * dtl: use counter instead of gauge Co-authored-by: Kevin Ho <kevinjho1996@gmail.com> * fix: remove 'editor.formatOnSave' from global settings' (#1163) * merge conflicts * Update pre-commit * Version Packages (#1167) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * minor * Update pre-commit * Fix wallet test (#119) * Fix wallet test * Fix deployment test * Add Python * Update Dockerfile.omgx_monorepo * Remove package-lock Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * Reapply standard changes on top of current develop * Update package.json * doc: add notes for releasing new versions with changesets (#1166) * Bind correct object to method handler in DTL (#1168) * fix: bind correct object to method handler * build: add changeset * Version Packages (#1169) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix web wallet * Fix integration test (#124) * Fix integration test (#125) * Fix integration test * Fix integration test * Fix wallet_react * Fix lint test * Remove package-lock * Update integration.yml * Fix wallet deployer * Collect docker log * Fix l1-l2-deposit-withdrawal test * Fix sync test * Add chainID to deployer config * make sync tests dispatch only Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * Add short contribution section to primary README (#1157) * Add short contribution section to primary README * Update README.md * fix: prevent batch submitter from submitting batches if low on ETH * build: add changeset * Eslint ignore the hardhat folder * Update README.md * Beginning to add working examples * hardhart and waffle example tests * document/check waffle * test l1-l2 example * add patch-package * Update package.json * build: ensure lint only staged files on commit * refactor: do not run --fix on lint-staged * refactor: *.{ts,js} for eslint regex * l2geth: rollup client explicitly checks for >= 400 errors * l2geth: sync service retries connection to remote server * l2geth: test errors returning from remote * chore: add changeset * syncservice: nit * feat[message-relayer]: add easy relay tool * chore: add changeset * upkeep[monorepo]: add changeset info to README * merge conflict squash * Daily sync up (#137) * build: ensure lint only staged files on commit * refactor: do not run --fix on lint-staged * refactor: *.{ts,js} for eslint regex * l2geth: rollup client explicitly checks for >= 400 errors * l2geth: sync service retries connection to remote server * l2geth: test errors returning from remote * chore: add changeset * syncservice: nit * feat[message-relayer]: add easy relay tool * chore: add changeset * upkeep[monorepo]: add changeset info to README Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Kelvin Fichter <kelvin@optimism.io> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * build: set up eslint prettier correctly * style: run yarn lint --fix at root * build: add necessary packages to workspace root * build: remove --format stylish * build: set semvery ranges to match across packages * build: set up prettierrc.js for monorepo * refactor: rename Range to BlockRange * build: set up correct working directories * build: set up lint:fix to use eslint not prettier * style: run lint:fix on all code * build: remove prettier extension recommendation * style: update configuration to include babel-eslint for .js linting * build: set concurrency to 1 to prevent git add errors on lerna lint * github actions: bump geth CI golang version * fix(contracts): prevent L2->L1 calls to system contracts * Update message relayer fast contracts (#139) * prepare for wallet reorg * Create yarn.lock * fix hardhat bug * merge conflict resolve * daily sync up (#141) * build: set up eslint prettier correctly * style: run yarn lint --fix at root * build: add necessary packages to workspace root * build: remove --format stylish * build: set semvery ranges to match across packages * build: set up prettierrc.js for monorepo * refactor: rename Range to BlockRange * build: set up correct working directories * build: set up lint:fix to use eslint not prettier * style: run lint:fix on all code * build: remove prettier extension recommendation * style: update configuration to include babel-eslint for .js linting * build: set concurrency to 1 to prevent git add errors on lerna lint * fix(contracts): prevent L2->L1 calls to system contracts Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: ben <ben@pseudonym.party> * Add Factory contract for creating standard ERC20 tokens compliant with the standard bridge * Disallow 0 address for l1 token when creating l2 standard token * Fix linting issue * Add deployment script for the L2 token factory * Fix deploy script OVM_L2StandardTokenFactory constructor params * Add changeset * Cleanup deployment script for OVM_L2StandardTokenFactory and fix a solidity linting error * refactor(integration): Add clarity to the expectApprox function signature * fix: skip codechecks for PRs from external repos * DRAFT move react wallet and the contracts to more clear folders (#138) * DRAFT move react wallet and the contracts to more clear folders * merging the axios integration chagnes * updated the message-relayer-fast contracts * integrate message-relayer-fast into standard dockers * Dockerize the message-relayer-fast * update Readme.md * remove duplicated contracts - just keep everything in /contracts * add deploy for fast messenger * message-relayer-fast testing * Update serve.sh * Delete yarn.lock * Update constants.ts * Create yarn.lock * Update constants.ts * Update function-manipulation.spec.ts * increase the retries and other minor fixes * Improved documentation * fix omgx integration tests * Update omgx-integration.yml * integration test remove duplicated tests * Fix units test configuration * Update docker-compose-omgx-services.yml * integration test setup fixes * fix wallet integration test * fix for crash on return * integration tests for `message-relayer-fast` * Update env.ts * Autodeploy Token Bridges * Update wallet contracts * Update utils.ts * improve omgx integration tests * Add address manager address to GH actions for now Co-authored-by: sahil kashetwar <> Co-authored-by: Sahil k <sahil@enya.ai> Co-authored-by: cby3149 <cby3149@outlook.com> * merge conflicts * GH actions regular changes * husky * Daily sync up (#144) * build: set up eslint prettier correctly * style: run yarn lint --fix at root * build: add necessary packages to workspace root * build: remove --format stylish * build: set semvery ranges to match across packages * build: set up prettierrc.js for monorepo * refactor: rename Range to BlockRange * build: set up correct working directories * build: set up lint:fix to use eslint not prettier * style: run lint:fix on all code * build: remove prettier extension recommendation * style: update configuration to include babel-eslint for .js linting * build: set concurrency to 1 to prevent git add errors on lerna lint * github actions: bump geth CI golang version * fix(contracts): prevent L2->L1 calls to system contracts * Add Factory contract for creating standard ERC20 tokens compliant with the standard bridge * Disallow 0 address for l1 token when creating l2 standard token * Fix linting issue * Add deployment script for the L2 token factory * Fix deploy script OVM_L2StandardTokenFactory constructor params * Add changeset * Cleanup deployment script for OVM_L2StandardTokenFactory and fix a solidity linting error * refactor(integration): Add clarity to the expectApprox function signature * fix: skip codechecks for PRs from external repos Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: ben <ben@pseudonym.party> Co-authored-by: elenadimitrova <elena@arenabg.com> Co-authored-by: Reggie Gomez <reggieag@gmail.com> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * docker: pin to alpine 3.13 for l2geth A bug has appeared when older versions of Docker are used to build alpine based images in alpine version 3.14. To prevent this problem from happening to the users, this PR pins the version to 3.13. The observed problem is that `make` cannot run any command and the error message states `Operation not permitted.` Removing `make` was one way to solve the problem but that would increase the diff from upstream geth. See these links for details: https://github.com/alpinelinux/docker-alpine/issues/182 https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.14.0 * fix: update statement for skipping codechecks * contracts: add set-l2-gasprice task This task allows a user to update the L2 gas price using hardhat. An example of doing so would be: ```bash $ export CONTRACTS_DEPLOYER_KEY=0x.. $ CONTRACTS_RPC_URL=https://kovan.optimism.io npx hardhat set-l2-gasprice \ --l2-gas-price 1 ``` This hardcodes the predeploy address of the `OVM_GasPriceOracle` smart contract and the Owner must be used to do the updating, otherwise the transaction will revert. * removed unused functions from core utils * [added] changeset * next gen integration tests for the OMGX stack (#149) * next gen integration tests for the OMGX stack * finish first pass integration test outline * move LP tests to the `message-relayer-fast` * Update omgx-integration.yml * add more tests to message-relayer-fast * connect up the .env variables * hard code URIs * Update utils.ts * Update omgx-integration.yml * fix - should have been 8080 * Update omgx-integration.yml * which address to use? * Update omgx-integration.yml * removing not needed code * remove superfluous logging code * Update utils.ts * Update utils.ts * additional comments and formatting improvements * fix: use older changes on tests (#152) * fix: use older structure * correct messenger * LP fees on the correct side * correct messenger * rearrange depl order Co-authored-by: Souradeep Das <dsouradeep2@gmail.com> * Update README_OMGX.md (#150) Refactored some changes and added some comments I thought might be helpful for people. Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * tests: re-enable all tests (#155) * re-enable all tests * re-enable all tests * Add solhint to contracts package * Turn off compiler-version rule in solhint * Add suggestions by @maurelian https://github.com/ethereum-optimism/optimism/pull/1033#issuecomment-866146467 * Change solhint output formatting to table * Disable contract-name-camelcase rule in solhint * Fix max-line-length linting issues in contracts * Fix quotes linting issues in contracts * Remove private-vars-leading-underscore rule in solhint * Add contracts linting to github action * Fix for hardhat account balance parsing * Disable generating the bytecodeHash in hardhat contract artifacts * Review fixes * Fix review notes * Fix smockit for a change in hardhat ^2.4.0 which changes the way it parses errors from returndata Fix provided by @smartcontracts * dtl: configurable gas price backend Adds a new config option `--l1-gas-price-backend` or `DATA_TRANSPORT_LAYER_L1_GAS_PRICE_BACKEND` that can be set to `l1` or `l2`. This impacts the behavior of the HTTP endpoint `GET /eth/gasprice` by changing what is queried to return the L1 gas price. The L1 gas price is required to compute the L2 fee since the L2 fee consists of `L1 gas price * L1 gas used + L1 gas price * L2 gas limit`. If the L1 gas price differs too much between different L2 providers, then users using `eth_estimateGas` may submit transactions with too low of a fee and be unable to submit transactions to the sequencer. By configuring the DTL to use L2 as the L1 gas price backend, it will call the Sequencer's RPC endpoint `rollup_gasPrices` which returns the L1 and L2 gas prices from the point of view of the sequencer. The L2 gas price exists in the state, so that will always be the same between the sequencer and any replicas. The L1 gas price does not live on chain, so querying for it from the sequencer directly will ensure that users send transactions with a fee that is large enough. Also adds eth/gasprice info to README. * Remove bl wl service (#154) * replace `bl-wl` with direct calls the `omgx_deployer` * Update docker-compose-omgx-services.yml * Update up_local.sh * Add CORS headers to http servers * updated frontend to use the two new HTTP servers for the addresses * update webwallet to work with both local and rinkeby * Add missing .env variables to GH actions * re-enable docker tages * re-enable wallet transaction history * Update up_local.sh * Update up_local.sh * Add flag to omgx_deployer to only serve addresses w/o deploying new contracts * Update docker-compose-omgx-services.yml * Add back tagging system and improved reliability of GH actions * removed commented out service * add rinkeby token addresses (#161) Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * fix: lint deploy-l2 folder in contracts * Add AWS integration (#159) * Add AWS integration * Remove artifacts * updated ops_omgx/README.md and added .github/workflows/deploy2aws-integration.yml and .github/workflows/push2aws.yml * add automated provision and deletion of an ec2 instance for running the integration tests Co-authored-by: Petar Denev <pdenev@gmail.com> * fix: update CI to avoid running out of memory * Version Packages * ci: release latest image tags on release * feat: update README to include info about rebasing * Add op_exporter for sequencer metrics and health endoint Added metric for sequencer health Added Dockerfile for op_exporter; Fixed Dockerfile path * merge conflicts * re-comment out the usual GH actions * feat[integration-tests]: make tests work for prod networks * chore: add changeset * Increase client_body_buffer_size for rpc-proxy Added client_max_body_size to rpc-proxy config * l2geth: use `hexutil.Big` to prevent overflows The `RollupClient` decodes the JSON from the DTL as a uint64, this updates it to be a `big.Int` Includes a test for the value field that ensures it does not overflow * ci(contracts): only run codecov if contracts package is modified In order to skip running the CodeCov job when it isn't relevant, a new job was added to the ts-packges workflow. For a PR, this job identifies all the files modified between the base branch and the tip of the PR branch, and writes to a variable which can be used to decide if subsequent jobs should run. Github Actions provides an easy method for achieving this at the level of a workflow, but not for specific jobs within a workflow. * Version Packages * chore(ci): Skip codecov on push events * feat: add workflow for running SNX test suite * go: implement gasprices package The `gasprices` package implements the logic that updates L2 gasprices on the Optimistic Ethereum Network. Co-authored-by: Karl Floersch <karl@karlfloersch.com> * gas-oracle: implement and test This commit adds the `gas-oracle` which is an offchain entity that sends transactions to L2 to update the gas price. It must be configured with a private key as the `OVM_GasPriceOracle` is owned. The `gas-oracle` is added to the changesets setup. Tests are included as well as CI. Dockerizing will happen in a follow up PR. * gas-oracle: ci + docker build/publish Adds a dockerfile for the `gas-oracle` as well as adding it as a service in the `docker-compose.yaml`. It is not enabled by default due to memory issues in CI already happening occasionally where the integration tests are oom killed. The `gas-oracle` is configured with a key that owns the `OVM_GasPriceOracle`. This PR adds the `gas-oracle` to the Github Actions workflow that is responsible for publishing the docker images. * Add replica (#169) * fix: update erc20 deposits (#166) * fix: update erc20 deposits * fix: auto default token Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * resolve merge conflicts * Update docker-compose.yml * Update docker-compose.yml * [pull] develop from ethereum-optimism:develop (#164) * contracts: add set-l2-gasprice task This task allows a user to update the L2 gas price using hardhat. An example of doing so would be: ```bash $ export CONTRACTS_DEPLOYER_KEY=0x.. $ CONTRACTS_RPC_URL=https://kovan.optimism.io npx hardhat set-l2-gasprice \ --l2-gas-price 1 ``` This hardcodes the predeploy address of the `OVM_GasPriceOracle` smart contract and the Owner must be used to do the updating, otherwise the transaction will revert. * Add op_exporter for sequencer metrics and health endoint Added metric for sequencer health Added Dockerfile for op_exporter; Fixed Dockerfile path * feat[integration-tests]: make tests work for prod networks * chore: add changeset * Increase client_body_buffer_size for rpc-proxy Added client_max_body_size to rpc-proxy config * l2geth: use `hexutil.Big` to prevent overflows The `RollupClient` decodes the JSON from the DTL as a uint64, this updates it to be a `big.Int` Includes a test for the value field that ensures it does not overflow * ci(contracts): only run codecov if contracts package is modified In order to skip running the CodeCov job when it isn't relevant, a new job was added to the ts-packges workflow. For a PR, this job identifies all the files modified between the base branch and the tip of the PR branch, and writes to a variable which can be used to decide if subsequent jobs should run. Github Actions provides an easy method for achieving this at the level of a workflow, but not for specific jobs within a workflow. * Version Packages * chore(ci): Skip codecov on push events * feat: add workflow for running SNX test suite * go: implement gasprices package The `gasprices` package implements the logic that updates L2 gasprices on the Optimistic Ethereum Network. Co-authored-by: Karl Floersch <karl@karlfloersch.com> * gas-oracle: implement and test This commit adds the `gas-oracle` which is an offchain entity that sends transactions to L2 to update the gas price. It must be configured with a private key as the `OVM_GasPriceOracle` is owned. The `gas-oracle` is added to the changesets setup. Tests are included as well as CI. Dockerizing will happen in a follow up PR. * gas-oracle: ci + docker build/publish Adds a dockerfile for the `gas-oracle` as well as adding it as a service in the `docker-compose.yaml`. It is not enabled by default due to memory issues in CI already happening occasionally where the integration tests are oom killed. The `gas-oracle` is configured with a key that owns the `OVM_GasPriceOracle`. This PR adds the `gas-oracle` to the Github Actions workflow that is responsible for publishing the docker images. Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Ben Wilson <bwilson@optimism.io> Co-authored-by: Kelvin Fichter <kelvin@optimism.io> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: Ben Wilson <82120899+optimisticben@users.noreply.github.com> Co-authored-by: Kevin Ho <kevinjho1996@gmail.com> Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: Maurelian <maurelian@protonmail.ch> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Karl Floersch <karl@karlfloersch.com> * Update docker-compose.yml * adding l1-l2 test ecs scheduled task that does verify communication between L1 and L2 and L2 to L1 (#167) Co-…

* fix[relayer]: update exported files list in package.json (#1138) * fix[relayer]: update exported files * chore: add changeset * fix: import path (#1141) * fix: correct import path for altered contract path * chore: add changeset * refactor: improve logging for batch submission timeout scenarios (#1120) * Fixed CrossDomainMessenger name (#96) * Add highest L1 and L2 block number Gauge metrics to DTL (#1125) * build: add prom-client to data-transport-layer * refactor: thread metrics more carefully through data-transport-layer; add two new metrics * style: fix some style issues * refactor: make metrics mandatory * refactor: move metrics register code to top of file * style: apply linting * refactor: move promethesus initialization after express * refactor: move promBundle call up, provide registry * build: add changeset * Improve Watcher ability to find transactions (#1107) * remove listeners and use loop to find tx receipt * add yarn ready * moved filters inside loop * [added] changeset * Add minimal vscode settings and extensions (#1109) * chore: add minimal vscode settings and extensions * chore: Add "files.trimTrailingWhitespace" to vscode native config * chore: replace vscode prettier plugin with eslint plugin * fix[contracts]: remove part of MultiMessageRelayer deployment (#1144) * fix[contracts]: remove part of MultiMessageRelayer deployment * chore: add changeset * Define L1 Starting block via OwnershipTransferred rather than AddressSet (#1129) * Update service.ts * Create thirty-years-look.md Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * Easy fix for broken watchers (#1121) * Easy fix for broken watchers * Ran yarn changeset Co-authored-by: Liam Horne <liam@lihorne.com> * feat: go packages (#1111) * go: add utils module * readme: update * Version Packages (#1094) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * build: add husky pre-commit hook to lint (#1146) * feat[contracts]: add mainnet deploy script (#1147) * Add mainnet deploy script * Update mainnet.sh * Address PR review feedback * feat: mainnet contract deployment 0.4.0 (#1148) * feat: mainnet contract deployment 0.4.0 * feat: deployments readme * chore: add changeset * contracts: remove dead contract * contracts: remove dead config * tests: fix to not test for old contracts * feat: `rollup gasPrices` RPC endpoint (#1136) * feature: l2geth endpoint * chore: add changeset Co-authored-by: Liam Horne <liam@lihorne.com> * Adds l2 standard bridge to contracts markdown file (#1151) * Version Packages (#1150) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add more info about our branching strategy to the README (#1114) * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Remove references to OVM_L1ETHGateway in deployments and readme (#1119) * Keep the user logged in after changing chain (#99) * Keep the user logged in after changing chain * Update Nft.js * Detect if user is in the wrong chain Co-authored-by: cby3149 <cby3149@outlook.com> Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * Merge conflics resolve (#110) * wip * gethl2 * wip * batch submitter * core utils * DTL * message relayer * contracts * wip * Update service.ts * DTL * messaage-relayer * Update yarn.lock * final 5 files * [pull] develop from ethereum-optimism:develop (#91) * chore: reduce hardhat timeout to 20 seconds (#968) * fix: force LF line endings for scripts to avoid docker problems on Windows (#974) * fix: use correct line endings for windows * chore: add changeset * refactor[contracts]: Turn ExecutionManagerWrapper into a predeployed contract (#808) * wip: Started working on L2 contract testing revamp * test: clean tests for ProxyEOA * style: clean imports for ProxyEOA tests * test: port tests for ECDSAContractAccount * fix tests and add wrapper to dump * fix: add em wrapper to l2 deploy * ffix: add comments to wrapper contract * fix: add more comments * fix: add smock comment for unbind * Update packages/smock/src/smockit/binding.ts * maintenance[contracts]: use dashes in chain container names (#819) * maintenance: use dashes in chain container names * chore: add changeset * feat[contracts]: temporarily disable EOA upgrades (#857) * feat[contracts]: disable eoa upgrades temporarily * chore: add changeset * Update OVM_ProxyEOA.sol * fix: turn upgrade into a noop * lint: fix * feat[contracts]: Update Lib_AddressManager.AddressSet event to speed up data transport layer (#820) * feat: update and improve AddressSet event * chore: add changeset * Update Lib_AddressManager.sol * Reduce gas costs of deposits (#667) * Remove messageNonce from BaseCrossDomainMessenger and use CTC queue lenght instead Remove Abs_BaseCrossDomainMessenger and restore dedicated nonce generation in OVM_L2CrossDomainMessenger Fix typo * Remove sentMessages mapping from L1CrossDomainMessenger storage and use the nonce to check for existence of replayed transaction * Refactor out common library function for getting cross domain calldata * Post rebase fixes * Use the queueIndex to check the transaction was enqueued * Fix tests for L1CrossDomainMessenger.replayMessage Also make that test work with an actual CanonicalTransactionChain implementation rather than a smock * Lint fixes * Optimise the resolve calls into the AddressManager lib * Rename the nonce parameter to be clear * Update test name Co-authored-by: ben-chain <ben@pseudonym.party> * Rename getXDomainCalldata to encodeXDomainCalldata to match the new Lib_CrossDomainUtils Co-authored-by: ben-chain <ben@pseudonym.party> * optimism: bump gaslimit to 10 million #870 (#871) * optimism: bump gaslimit to 10million * chore: add changeset * optimism: bump max gaslimit to 10 mil * chore: add changeset * chore: remove unnecessary changeset * chore: remove unnecessary changeset Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * fix: use correct contract name in tests (#921) * fix: disable upgradability from ECDSA Account (#885) * l2geth: remove `SignatureHashType` (#752) * l2geth: remove tx type * l2geth: no longer parse type in rollup client * chore: add changeset * chore: remove extra sighash params * fix: do not check txtype in integration tests Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * feat[contracts]: introduce OVM_GasPriceOracle (#912) * feat[contracts]: congestion price oracle * chore: add changeset * contracts: gas price oracle (#917) * contracts: gas price oracle * tests: update * fees: fix tests * contracts: simplify gas price oracle * lint: fix * test: execution price is at the 1st storage slot * chore: rename predeploy to GasPriceOracle * chore: rename gas price oracle test name Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * fix: configure max gas limit to 11m (#928) Uniswap V3 contracts require that, otherwise they throw call exceptions at deployment * Consolidate Predeploy Addresses (#931) * added library for predeploy addresses * refactor tests and other packages to use exported predeploys * revert library usage in OVM_ECDSAContractAccount * lint * added newline * fixed address typos Co-authored-by: rajivpo <rajivpatel-oconnor@Rajivs-MacBook-Pro-2.local> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * chore: remove yarn-error.log and gitignore it (#956) * feat[contracts]: Replace Lib_RingBuffer with a much simpler Lib_Buffer (#821) * feat[contracts]: replace Lib_RingBuffer with a simpler Lib_Buffer * chore: changeset * test: add tests for Lib_Buffer * lint: fix * test: add extra coverage for Lib_Buffer * Update packages/contracts/contracts/optimistic-ethereum/libraries/utils/Lib_Buffer.sol Co-authored-by: ben-chain <ben@pseudonym.party> * add some extra comments Co-authored-by: ben-chain <ben@pseudonym.party> * fix(contracts): import predeploys (#982) * fix(contracts): import predeploys * fix: lint * feat: add hardhat deploy instructions to readme (#965) * feat: add deployment instructions to readme * Add changeset * fix style * Update README.md * feat: fees v2 (#976) * l2 geth: new fee logic * l2 geth: migrate to fees package * core-utils: new fee scheme * chore: add changeset * l2geth: delete dead code * integration-tests: fix typo * integration-tests: fixes * fees: use fee scalar * lint: fix * rollup: correct gas payment comparison * fix(integration-tests): do not hardcode gas price * core-utils: update with new scheme * l2geth: refactor rollup oracle * l2geth: clean up DoEstimateGas * l2geth: implement latest scheme * tests: fix up * lint: fix * l2geth: better sycn service test * optimism: rename to TxGasLimit * fee: fix docstring * tests: fix * variables: rename * l2geth: prevent users from sending txs with too high of a fee * integration-tests: fix import * integration-tests: fix type * integration-tests: fix gas limits * lint: fix * l2geth: log error Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * Add static analysis action (#848) * Add static analysis github action setup python and install slither * Add nvmrc file for setting node to v14.17 * Update slither command run to link missing contract packages from monorepo root * Add steps for installing dependencies * Add yarn build step to github action * Enable colour in github action for static analysis * Disable certain detectors * Ensure slither does not fail build * Add instructions on running static analysis to monorepo readme * build(deps): bump ws from 7.4.4 to 7.4.6 in /ops/docker/hardhat (#987) Bumps [ws](https://github.com/websockets/ws) from 7.4.4 to 7.4.6. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](https://github.com/websockets/ws/compare/7.4.4...7.4.6) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix[l2geth]: fix accidental merge conflict (#994) * feat[message-relayer]: relay tx generator (#952) * feat[message-relayer]: relay tx generator * whoops, I burned our infura key * fix minor bug * add comments * add more comments and clean stuff up * add empty test descriptions * add tests * move smock to dev deps * chore: add changeset * minor cleanup to merkle tree proof function * use bignumber math to avoid nested await * use a better interface * minor fixes and simplifications * backwards compatible dtl syncing (#986) * kovan: fix attempt * kovan: db fix * kovan: types are strings from db * l2geth: parse things as strings * chore: add changeset * dtl: also stringify the range query * geth: dereference * geth: assign err * dtl: handle null * dtl: fix unit tests * fix[smock]: fix broken call assertions for overloaded functions (#996) * fix[smock]: fix broken call assertions for overloaded functions * chore: add changeset * minor correction and add a test * add a test for non-overloaded functions * fix[message-relayer]: fix failing test because of merge with develop (#1000) * fix[message-relayer]: remove spreadsheet mode (#998) * fix[message-relayer]: remove spreadsheet mode * chore: add changeset * Lower local rollup timestamp refresh (#985) * update rollup timestamp refresh * increase refresh time to 5s * feat: fees v3 (#999) * core-utils: fee impl v3 * l2geth: fees v3 impl * integration-tests: update for fees v3 * chore: add changeset * fix: typo * integration-tests: fix and generalize * fees: update fee scalar * l2geth: check gas in the mempool behind usingovm * tests: fix up * l2geth: remove dead var * truffle: fix config * fix: remove dead coders (#1001) * chore: delete dead coders * chore: add changeset * dtl: remove dead imports * core-utils: delete dead tests * batch-submitter: remove txtype * chore: add changeset * docs[message-relayer]: add a README and improve the interface for generating proofs (#1002) * docs[message-relayer]: add basic docs and clean up an interface * chore: add changeset * dtl: log error stack for failed http request (#995) * dtl: log error stack for failed http request * chore: add changeset * Add rpc-proxy service for whitelisting JSON RPC methods to the sequencer. (#945) * Add healthcheck endpoint for rpc-proxy Added ethereum-nginx-proxy source updated README and docker image build * Check ETH_CALLS_ALLOWED is set, clean up comments, remove old Dockerfile * Pass additional information across domains via token gateways (#824) * feat(contracts): add from and data args to L1ERC20Gateway fix(integration): add gasLimit to fundUser refactor(contracts): add data to gateway events add changeset fix(integration): provide data in outboundTransfer refactor(contracts): reset Abs_L2TokenGateway to Abs_L2DepositedToken refactor(contracts): fix mismatched names * feat[contracts]: add custom gas arg to gateway fix(contracts): take max of user vs. default gas * fix(integrations): update ovm-eth function call * fix(integration): remove unecessary explicit gasLimit * test(contracts): 32kb transfer, 9MM gas * fix(contracts): fixup comment, bytes arg last * fix(integration): args order in integrations * fix(contracts): remove unused L2 gas arg * fix(contracts): limit data that can be passed to L2 * fix(integration): better tests for data length * test: check for error on too large data * Experimental: specify gaslimit in before hook * fix(integration): add l2 gas argument * fix: increase gas on fundUser * fix(contracts): remove duplicate max size limit * fix(integration): fine tune gas amounts * lint * fix: large data test * fix(integration): set gas closer to real cost * fix(contracts): remove unused bridge variables These variables were the default gas amounts for cross domain messages * fix(contracts): Reorder args Place dynamic length args last * fix(integration): update estimateGas values * fix(integration): reset eth withdraw estimate to 21000 * fix(integration): update expected gas amount * fix(integration): reduce gas amount for ETH withdraw * More consistent style for Constant values (#991) * chore(contracts): make container addresses be constants chore(contracts): consistent style for constant vars * chore(contracts): add internal on predeploy constants * feat: deployment config for fee oracle contract (#936) * feat[contracts]: add GasPriceOracle w/o predeploy Based on #912 * feat[contracts]: congestion price oracle * chore: add changeset * contracts: gas price oracle (#917) * contracts: gas price oracle * tests: update * fees: fix tests * contracts: simplify gas price oracle * lint: fix * test: execution price is at the 1st storage slot * chore: rename predeploy to GasPriceOracle * chore: rename gas price oracle test name Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * Add an L2 deploy script for gas oracle contract * Add a kovan deployment artifact * Add deployment to readme * Add extra validation & initial execution price * Update README.md * Fix execution price logic * Perform new deployment with final contract * contracts: better require in ovm gas price oracle * Deploy L2GasPriceOracle * Update contract to use new fee logic & rename to gas * Deploy updated contract * Fix lint * gas price oracle: do not restrict gas price * gas price oracle: new deployment * tests: delete dead test Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * ops: expose debug namespace (#1007) * develop merge fixes * refactor[l2geth]: queue origin type (#975) * refactor: queueOrigin type * Convert queueOrigin to uint8 in encode * Add changeset * Regenerate json marshall * style: combine lines * Add Stringer for QueueOrigin * Turn QueueOrigin into uint8 * l2geth: gen tx meta fix * l2geth: gen tx meta fix * lint Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> * fix(sync-service): prevent underflows (#1015) * fix(sync-service): prevent underflows * chore: add changeset * chore: remove dead confirmation depth * chore: remove eth1conf depth from rollup config * test: remove duplicate value in array (#1014) * ci: tag docker image for canary with abbreviated GITHUB_SHA (#1006) * ci: tag docker image for canary with abbreviated GITHUB_SHA * ci: update from 6 bytes to 8 bytes of abbreviation * refactor: improve logging for transactions being submitted to chain with gasPrice (#1016) * refactor: improve logging for transactions being submitted to chain with gasPrice * lint: apply lint autofixes * dtl: remove stringify from db logic + more overflow protection (#1010) * dtl: remove stringify from db logic * l2geth: overflow protection * dtl: overflow protection * chore: add changeset * ci: upload logs for failed integration tests (#1020) * fix(dtl): improve slow blocking JSON parsing that occurs during l2 sync (#1019) The use of eth_getBlockRange returns a large response which is very slow to parse in ethersjs, and can block the event loop for upwards of multiple seconds. When this happens, incoming http requests will likely timeout and fail. Instead, we will parse the incoming http stream directly with the bfj package, which yields the event loop periodically so that we don't fail to serve requests. * fix: lint errors in dtl (#1025) * fix[dtl]: fix dtl bug breaking verifiers (#1011) * fix[dtl]: fix dtl bug breaking verifiers * tweaks so tests pass * chore: add changeset * fix: deterministic blockhashes (#1032) * config: set etherbase * l2geth: add deterministic clique key * l2geth: default value * chore: add changeset * test: add sync test for deterministic blockhash Co-authored-by: Kevin Ho <kevinjho1996@gmail.com> * Version Packages (#978) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * ci: add sync test's own workflow (#1031) * fix(dtl): incorrect parsing of eth_getBlockRange result (#1037) * Version Packages (#1045) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: no gas refund (#1043) * l2geth: remove the gas refund * chore: add changeset * refactor[contracts]: remove one-off GasPriceOracle deployment file (#1046) * refactor[contracts]: remove one-off gpo deployment * chore: add changeset * feat[contracts]: introduce new L1ChugSplashProxy contract (#1009) * feat[contracts]: add L1ChugSplashProxy * improve comments slightly * start adding tests * add more tests * make the system pausable * added another test * add some extra comments * Update packages/contracts/test/contracts/chugsplash/L1ChugSplashProxy.spec.ts Co-authored-by: Maurelian <maurelian@protonmail.ch> * Update packages/contracts/test/contracts/chugsplash/L1ChugSplashProxy.spec.ts Co-authored-by: Maurelian <maurelian@protonmail.ch> * chore: add changeset * address review feedback Co-authored-by: Maurelian <maurelian@protonmail.ch> * feat[contracts]: add sequencer fee wallet (#1029) * wip: first draft of the fee wallet * add fee wallet to dump * rename to sequencer vault * add L1 fee wallet to geth config * add unit tests * fix geth linting error * add a basic integration test * fix broken integration test * add test for correct storage slot * add integration test for fee withdrawal * fix typo in integration tests * fix a bug bin integration tests * Update OVM_SequencerFeeVault.sol * fix bug in contract tests * chore: add changeset * fix bug in contract tests * build(deps): bump glob-parent from 5.1.1 to 5.1.2 (#1036) Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2. - [Release notes](https://github.com/gulpjs/glob-parent/releases) - [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md) - [Commits](https://github.com/gulpjs/glob-parent/compare/v5.1.1...v5.1.2) --- updated-dependencies: - dependency-name: glob-parent dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: Liam Horne <liam@lihorne.com> * fix: predeploy gasprice oracle (#1039) * l2geth: delete extra config options * l2geth: stop using extra config options * l2geth: more stop using extra config options * chore: add changeset * l2geth: add new config for gpo owner * chore: add changeset * l2geth: fix tests * tests: fix build * l2geth: optimize loops (#1027) * l2geth: optimize loops * l2geth: stop ticker when done * l2geth: don't wait for first tick * chore: add changeset * Enable custom tagging of release docker image (#1048) * ci: enable custom tagging of release docker image * ci: refactor to add prerelease prefix for secuirty * doc: typo * ci: fix indentation issue of canary workflow * ci: fix typo with GITHUB_SHA * fix: typo in USE_HARDHAT config (#1023) * fix: abi encoded tx (#1049) * contracts: don't double rlp decode * chore: add changeset * lint: fix * deps: update * linting: cleanup * feat: contracts: use selector * fix: contracts: use typescript * contracts: use interface * l2geth: bump to go 1.15 (#1058) * l2geth: bump to go 1.15 * chore: add changeset * Change monotonicity band-aid code to log warnings not errors (#1060) * refactor: change monotonicity band-aid code to log warnings not errors * build: add changeset * feat(contracts, l2geth): native ETH value support for ovmCALL (#1038) * feat(contracts): add ovmCALL-types with native value * add ovmCALLVALUE context * add ovmBALANCE * test success and revert cases * test empty contract case * chore: lint * test(integration-tests): ovmCALL-types with value (compiler and wrapper) * fix ovmDELEGATECALL type, update tests * add ovmSELFBALANCE * fix ovmDELEGATECALL jumping to CALL * chore: lint * fix(contracts): account for intrinsic gas of OVM_ETH sends * fix(contracts): merge conflict bug * fix(contracts): update gas benchmark * feat(contracts, integration-tests): use new value-compatible compiler * feat(contracts,l2geth): support value calls in OVM_ECDSAContractAccount * fix(contracts): ovmDELEGATECALL does not change message context * feat(contracts): sending value between EOAs * test(integration-tests): ovmDELEGATECALL preserves ovmCALLVALUE * test(integration-tests): assert ovmSELFBALANCEs correct * test(integration-tests): intrinsic gas for eth value calls * test(integration-tests): update gas values * chore(contracts): lint * feat(contracts, l2geth): eth_calls with nonzero value * chore: minor fixups and comments based on PR feedback * test(integration-tests): add requested tests from PR reviews * test(integration-tests): ovmSELFBALANCE is preserved in ovmDELEGATECALLs * fix(contracts): fix bug where ovmDELEGATECALL could fail if balance was lower than the ovmCALLVALUE * chore: add changeset * fix(contracts): update intrinsic gas for worst-case value sends * chore: address final PR nits/improvements Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> * Add erc1271 support to contract account (#1052) * add ERC1271 support, failing unit tests * add integration test for isValidSignature * remove .only * lint * add changeset * clean up 1271 tests and lint * switch back to using waffle wallet * lint * fix import * feat[contracts]: slightly better account funding for hardhat accounts (rebased) (#1065) * feat[contracts]: better account funding for hardhat accounts * add a sleep to avoid any potential problems * chore: add changeset * fix: bug with gas estimation in funding step * fix: limit to 20 accounts max Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> * Ensure Sentry is correctly set up for DTL and MR (#1054) * refactor: add logger and metrics to options for BaseService * refactor: thread sentryOptions through from message-relayer into BaseService * refactor: ensure DTL Logger is using Sentry for errors * style: lint base-service.ts * refactor: init Sentry on batch-submitter too * refactor: init Sentry on message-relayer too * refactor: pass in basic logger to MessageRelayerService * build: provide changeset * fix: correct usage of use-sentry boolean config * refactor: appropriately type loggingOptions * build: add @sentry/node * build: add @sentry/node to message-relayer and fix linting issue * Add more logging information to monotonicity violation logs (#1066) * refactor: log idx of monotonicity violation from batch * build: add changeset * temporarily disable hardhat example tests (#1071) * fix: monotonicity auto healer (#1070) * fix: monotonicity auto healer * add: changeset * Version Packages (#1053) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Standard token bridge (#988) * Remove abstract token gateway and deposited token implementations * Further simplification of bridge contracts * Standart token bridge and L2 token implementation * Fix spacing * Implement case when a bad deposit happens to a nonexistent L1<>L2 token pair * Use SafeMath in common token bridge accounting * test(contracts): fix finalizeWithdrawal test * fix(contracts): use SafeERC20 on token deposits * Rename OVM_L1ERC20Gateway to OVM_L1ERC20Bridge contract * Rename iOVM_L1ERC20Gateway to iOVM_L1ERC20Bridge contract * Cleanup gateway to bridge rename * Better name for the mapping holding l1->l2 deposit amounts * Use OZ SafeMath * Rename local variables in OVM_L2DepositedERC20 from gateway to bridge * Merge ETH and ERC20 bridge contracts * Rename OVM_L1ERC20Bridge to OVM_L1StandardBridge and fix tests from merging the ETH and ERC20 bridges * Better name for iAbs_BaseCrossDomainMessenger -> iOVM_CrossDomainMessenger * Correct the bounce back of deposit sender and recipient properties * Remove obsoleted event from OVM_L2DepositedERC20 * chore(contracts): change references from ETHGateway to Bridge * Fix a linting error * fix(contracts): add bridge to deployer * Split off ERC20Bridge interface for the purposes of being reused in custom ERC20 bridges * Split off interface natspec definitions * Draft version of OVM_L2DepositedERC20 splitted into a standard L2 erc20: L2StandardERC20 and a common L2 bridge: OVM_L2StandardBridge * style(contracts): define L1_ETH_ADDRESS as constant * test(integration): update interface to use depositETH * test(contracts): fix OVM_L1StandardBridge tests * test(contracts): fix L2 Standard Bridge tests * test(contracts): lint and remove an obsolete test case * Fix modifier check to comply with the L2 bridge distinction from L2 token * Simplify address <> interface casting in bridges * Ensure natspec comments are correct also add l1 and l2 token params to WithdrawalInitiated event for consistency * Fix issues in L1 and L2 bridges to ensure cross domain messages are sent only between the two bridges also adjusted withdrawals to send to either finalizeETHWithdrawal or finalizeERC20Withdrawal depending on which asset is being withdrawn * Remove AddressManager from the L1 standard bridge * REVERT ME: instruments cross domain enabled * fix(contracts): remove Address Manager from L1 Bridge * feat(contracts): make L2 Standard Bridge a predeploy * WIP: update deployments for standard bridges * WIP: update deployments for standard bridges * l2geth: TEMP log contract calls * chore(l2geth): replace eth gateway with standard bridge * fix(contracts): make contract-deployment/config work * WIP fix(integration): update integration tests for bridge * Remove ovmEth from L1 Standard bridge as obsoleted * Separate ERC20 standard implementation from L2 bridge * Formatting fixes * chore(l2geth): replace eth gateway with standard bridge * Revert "REVERT ME: instruments cross domain enabled" This reverts commit d5bb8f8f67974d0a3e65fc000f08858328a4bbbc. * fix: lint ts * Implement EIP-165 in the Standard L2 ERC20 token Also switch that to be based off the OpenZeppelin default implementation plus mint and burn Additionally remove the obsoleted iOVM_ERC20 * fix(contracts): add deployment check on bridge proxy fix(contracts): whitespace fix(contracts): init bridge implementation with non-zero address * Remove dependency on Ownable contract for the StandardERC20 token on L2 * fix(contracts): update deployment scripts * fix: lint * remove debugging code * fix: correct rpc get balance slot * restore l2 cross domain messenger * fix: lint * Add a test for a non compliant token deposit * Only allow EOAs to deposit ETH and ERC20 * Add comments and tests for ERC165 implementation * Decide against using explicit ETH MOCK address as we're not using it for checks * Fix linting issues * Add onlyEOAContract restriction to standard bridge withdrawals * Update codehashes in L2 Standard bridge * fix(ops): remove unintentionally added file * feat(contracts): add expectApproxGasCost function * fix(integration): proper arrayify input on fundUser * fix(integration): proper gas value checks * Revert "Add onlyEOAContract restriction to standard bridge withdrawals" This reverts commit 2713c06ceb2609e4f13718e1034a4d76210d9758. * fix(contracts): removed unused expectApproxGasCost for now * fix(contracts): update OVM_SequencerFeeVault for bridge changes * lint * Update deployment for L1 Bridge w/ ChugSplash * Revert "l2geth: TEMP log contract calls" This reverts commit 21d42259278449f221bf34605162229b3d9d4fa9. * Apply suggestions from code review * Apply suggestions from code review * fix(contracts): deploy with chugsplash proxy * fix(contracts): add working bridge and chugsplash proxy deployment * fix(contracts,integration): 500k gas for depositETH * comment(contracts): describe failed deposit handling on l2 * Apply suggestions from code review Co-authored-by: ben-chain <ben@pseudonym.party> * docs: add changeset * fix(integration): set working l2 gas amount on funduser * test(integration): add receive() test * fix(contracts): reset receive to 1.2MM l2 gas * test(examples): skip l1-l2 example test for now * fix(contracts): drop hardcoded gas to 500k in receive() * fix(contracts): use abi.encodeWithSignature * fix(contracts): resolve merge conflicts * feat(integration): add expectApprox for flexible gas testing * fix(integration): fix failing gas tests * fix: incorrect l2 gas for deposit * Update utils.ts * fix(workflow): disable l1-l2 example until npm imports are fixed * chore: final round of PR review nits and tests Co-authored-by: Maurelian <maurelian@protonmail.ch> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: ben-chain <ben@pseudonym.party> Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> * fix: comment out codeowners (#1073) * fix: use predeploy constant lib for em wrapper (#1075) * fix: use predeploy constant lib for em wrapper * chore: add changeset * fix[l2geth]: off-by-one sometimes breaking replica sync (#1082) * fix[l2geth]: off-by-one sometimes breaking replica sync * chore: add changeset * fix(l2geth): Log 'end of OVM execution' correctly (#1080) * refactor[contracts]: move account contracts to predeploy folder (#1085) * refactor[contracts]: move account contracts to predeploy folder * chore: add changeset * maintenance[contracts]: rename precompiles test folder to predeploys (#1086) * fix[bs]: disambiguate generic submission errors (#1051) * fix[bs]: disambiguate generic submission errors * add cases for errors * separate out errors from transaction reverts with reasons * remove extraneous errors * WETH deposit and withdraw on OVM_ETH (#1083) * feat(contracts): add no-op WETH9 functionality to OVM_ETH * working WETH deposit and withdraw + tests * add changeset * address PR feedback * update WETH9 contract implementation * add fallback to WETH9 * add fallback and revert withdraw test * update nit comment Co-authored-by: ben <ben@pseudonym.party> * Also move the accounts interface to iOVM/predeploys (#1087) * refactor[contracts]: move account interface to predeploy folder * chore: add changeset * Version Packages (#1089) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: use -z flag for var unset in canary * Use Eslint instead of Tslint (#1005) * removed tslint * forgot to commit files * made .eslintrc.js consistent for all subdirs and other cleanup * [removed] includes and files keys from tsconfig.json * removed file level linting exceptions and added details to line level * added changeset * fixed newly introduced linting errors from rebase * enable json import for batch submitter * removed ecdsa-coder * maybe a tsconfig issue? * Update deploy.ts Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: platocrat <37757724+platocrat@users.noreply.github.com> * metrics[batch-submitter]: add new batch submitter metrics (#1074) * metrics[batch-submitter]: add new batch submitter metrics * chore: changeset * account for failed submissions * Fix canary publishing (#1093) * ci: fix custom docker tag * ci: use new env file * ci: use outputs from previous job * ci: fix headers of jobs * ci: inherit canary tag from builder * feat[ci]: upload logs for sync tests if failure (#1098) * deploy: goerli 0.4.0 (#1099) * deployments: goerli 0.4.0 rc * readme: update * chore: add changeset * fix[dtl]: defend against RPC provider missing events (#1084) * fix[dtl]: defend against RPC provider missing events * chore: add changeset * respond to review comments * better error handling for missing handlers * deploy: kovan v.4.0 rc (#1101) * deploy: kovan v0.4.0 rc * chore: add changeset * readme: update * maintenance[monorepo]: first pass update to README (#1106) * maintenance[monorepo]: first pass update to README Doing some relatively minor updates to the README just to clean things up a bit. * replying to review comments * Move the metric prefix string to a label (#1047) Added changeset and fixes Changeset to patch * fix[smock]: add support for hardhat 2.4.0 (#1112) * fix[smock]: add support for hardhat 2.4.0 * chore: add changeset * lint: fix * build(deps): bump hosted-git-info from 2.8.8 to 2.8.9 (#1064) Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](https://github.com/npm/hosted-git-info/compare/v2.8.8...v2.8.9) --- updated-dependencies: - dependency-name: hosted-git-info dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * Misc. small improvements to README (#1115) * Update README.md * Update README.md * fix[dtl]: use the same L2 chain ID everywhere (#1122) * fix[dtl]: use the same L2 chain ID everywhere * chore: add changeset * fix: make sync tests only on workflow dispatch (#1123) * fix[dtl]: remove old stringification function (#1134) * fix[dtl]: remove old stringification function * chore: add changeset * fix[dtl]: log server errors as ERROR instead of INFO (#1133) * fix[dtl]: log server errors as ERROR instead of INFO * chore: add changeset * Contracts: connectL1Contracts & connectL2Contracts (#713) * Contracts: connect-contracts * Trying to resolve build problems * connect-contracts build working * Adds artifacts-ovm back to gitignore * Removes incorrect changes * Adds copy-artifacts script * Adds test file (not working yet) * fix: incorrect contract instantiation * Improves tests and removes old deployment versions * Single source of truth for predeploy addresses * Reverts deployments/README.md * Makes connect-contracts more DRY * Adds missing @ethersproject/abstract-signer dependency * Adds argument evaluation * Adds L1Contracts and L2Contracts types * Attempts removing artifacts-ovm again * Adds webpack config (not working yet) * build: add artifacts to dist (#776) * Updates lint rule * Adds l2 imports * Fixes dependency tree bug * Removes webpack stuff * Fixing package.json issues and adds .DS_Store to gitignore * Removes test-contracts script * Reverting script change * Adds comments * Adds comment * Renames deployments folders * Fixes linting errors * Generates markdown * build: add deployments directory to Dockerfiles * Removes unneeded contracts, improves error handling and tests * Adds changeset * yarn.lock * Removes console.log * Changes from minor to patch version * Fixes lint errors Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * fix: prevent overflow in abi encoding (#1135) * l2geth: prevent overflow in abi encoding to ovm codec tx * chore: add changeset * tests: replica syncing (#981) * [wip] add l2_dtl and replica images * passing basic dummy tx test * add erc20 test * add sync test to ci Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> * fix[relayer]: update exported files list in package.json (#1138) * fix[relayer]: update exported files * chore: add changeset * fix: import path (#1141) * fix: correct import path for altered contract path * chore: add changeset * refactor: improve logging for batch submission timeout scenarios (#1120) * Add highest L1 and L2 block number Gauge metrics to DTL (#1125) * build: add prom-client to data-transport-layer * refactor: thread metrics more carefully through data-transport-layer; add two new metrics * style: fix some style issues * refactor: make metrics mandatory * refactor: move metrics register code to top of file * style: apply linting * refactor: move promethesus initialization after express * refactor: move promBundle call up, provide registry * build: add changeset * Improve Watcher ability to find transactions (#1107) * remove listeners and use loop to find tx receipt * add yarn ready * moved filters inside loop * [added] changeset * Add minimal vscode settings and extensions (#1109) * chore: add minimal vscode settings and extensions * chore: Add "files.trimTrailingWhitespace" to vscode native config * chore: replace vscode prettier plugin with eslint plugin * fix[contracts]: remove part of MultiMessageRelayer deployment (#1144) * fix[contracts]: remove part of MultiMessageRelayer deployment * chore: add changeset * Define L1 Starting block via OwnershipTransferred rather than AddressSet (#1129) * Update service.ts * Create thirty-years-look.md Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * Easy fix for broken watchers (#1121) * Easy fix for broken watchers * Ran yarn changeset Co-authored-by: Liam Horne <liam@lihorne.com> * feat: go packages (#1111) * go: add utils module * readme: update * Version Packages (#1094) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * build: add husky pre-commit hook to lint (#1146) * feat[contracts]: add mainnet deploy script (#1147) * Add mainnet deploy script * Update mainnet.sh * Address PR review feedback * feat: mainnet contract deployment 0.4.0 (#1148) * feat: mainnet contract deployment 0.4.0 * feat: deployments readme * chore: add changeset * contracts: remove dead contract * contracts: remove dead config * tests: fix to not test for old contracts * feat: `rollup gasPrices` RPC endpoint (#1136) * feature: l2geth endpoint * chore: add changeset Co-authored-by: Liam Horne <liam@lihorne.com> * Adds l2 standard bridge to contracts markdown file (#1151) * Version Packages (#1150) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add more info about our branching strategy to the README (#1114) * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Remove references to OVM_L1ETHGateway in deployments and readme (#1119) Co-authored-by: Maurelian <maurelian@protonmail.ch> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: Elena Gesheva <elena@arenabg.com> Co-authored-by: ben-chain <ben@pseudonym.party> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> Co-authored-by: Karl Floersch <karl@karlfloersch.com> Co-authored-by: Rajiv Patel-O'Connor <rajiv.patel.oconnor@gmail.com> Co-authored-by: rajivpo <rajivpatel-oconnor@Rajivs-MacBook-Pro-2.local> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kevin Ho <kevinjho1996@gmail.com> Co-authored-by: Ben Wilson <82120899+optimisticben@users.noreply.github.com> Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: Tim Myers <timmyers09@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Annie Ke <annieke8@gmail.com> Co-authored-by: platocrat <37757724+platocrat@users.noreply.github.com> Co-authored-by: Matt Masurka <m.masurka@gmail.com> Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> Co-authored-by: Alejandro Santander <Palebluedot@gmail.com> * Re-apply key changes on top of optimism most current develop * Add docker-compose-replica.yml (#109) * Create docker-compose-replica.yml * Add replica service * Update docker-compose-omgx-replica.yml Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * fix linter; patch gethl2 * configure the deployer correctly * fix proposer / batch submitter * update chainIDs * update rpc test * Create README_OMGX.md * upstream - needs more work * Adds delay to watcher (#1159) * Adds delay to watcher * Simplifies delay * Adds changeset * Fix wallet test * Fix deployment test * Add Python * Update Dockerfile.omgx_monorepo * Remove package-lock * fix: bind dtl functions for missing event codepath (#1161) * dtl: bind this in L1 missing element error handlers * dtl: add additional logline * chore: add changeset * dtl: add more metrics * dtl: use counter instead of gauge Co-authored-by: Kevin Ho <kevinjho1996@gmail.com> * fix: remove 'editor.formatOnSave' from global settings' (#1163) * merge conflicts * Update pre-commit * Version Packages (#1167) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * minor * Update pre-commit * Fix wallet test (#119) * Fix wallet test * Fix deployment test * Add Python * Update Dockerfile.omgx_monorepo * Remove package-lock Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * Reapply standard changes on top of current develop * Update package.json * doc: add notes for releasing new versions with changesets (#1166) * Bind correct object to method handler in DTL (#1168) * fix: bind correct object to method handler * build: add changeset * Version Packages (#1169) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix web wallet * Fix integration test (#124) * Fix integration test (#125) * Fix integration test * Fix integration test * Fix wallet_react * Fix lint test * Remove package-lock * Update integration.yml * Fix wallet deployer * Collect docker log * Fix l1-l2-deposit-withdrawal test * Fix sync test * Add chainID to deployer config * make sync tests dispatch only Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * Add short contribution section to primary README (#1157) * Add short contribution section to primary README * Update README.md * fix: prevent batch submitter from submitting batches if low on ETH * build: add changeset * Eslint ignore the hardhat folder * Update README.md * Beginning to add working examples * hardhart and waffle example tests * document/check waffle * test l1-l2 example * add patch-package * Update package.json * build: ensure lint only staged files on commit * refactor: do not run --fix on lint-staged * refactor: *.{ts,js} for eslint regex * l2geth: rollup client explicitly checks for >= 400 errors * l2geth: sync service retries connection to remote server * l2geth: test errors returning from remote * chore: add changeset * syncservice: nit * feat[message-relayer]: add easy relay tool * chore: add changeset * upkeep[monorepo]: add changeset info to README * merge conflict squash * Daily sync up (#137) * build: ensure lint only staged files on commit * refactor: do not run --fix on lint-staged * refactor: *.{ts,js} for eslint regex * l2geth: rollup client explicitly checks for >= 400 errors * l2geth: sync service retries connection to remote server * l2geth: test errors returning from remote * chore: add changeset * syncservice: nit * feat[message-relayer]: add easy relay tool * chore: add changeset * upkeep[monorepo]: add changeset info to README Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Kelvin Fichter <kelvin@optimism.io> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * build: set up eslint prettier correctly * style: run yarn lint --fix at root * build: add necessary packages to workspace root * build: remove --format stylish * build: set semvery ranges to match across packages * build: set up prettierrc.js for monorepo * refactor: rename Range to BlockRange * build: set up correct working directories * build: set up lint:fix to use eslint not prettier * style: run lint:fix on all code * build: remove prettier extension recommendation * style: update configuration to include babel-eslint for .js linting * build: set concurrency to 1 to prevent git add errors on lerna lint * github actions: bump geth CI golang version * fix(contracts): prevent L2->L1 calls to system contracts * Update message relayer fast contracts (#139) * prepare for wallet reorg * Create yarn.lock * fix hardhat bug * merge conflict resolve * daily sync up (#141) * build: set up eslint prettier correctly * style: run yarn lint --fix at root * build: add necessary packages to workspace root * build: remove --format stylish * build: set semvery ranges to match across packages * build: set up prettierrc.js for monorepo * refactor: rename Range to BlockRange * build: set up correct working directories * build: set up lint:fix to use eslint not prettier * style: run lint:fix on all code * build: remove prettier extension recommendation * style: update configuration to include babel-eslint for .js linting * build: set concurrency to 1 to prevent git add errors on lerna lint * fix(contracts): prevent L2->L1 calls to system contracts Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: ben <ben@pseudonym.party> * Add Factory contract for creating standard ERC20 tokens compliant with the standard bridge * Disallow 0 address for l1 token when creating l2 standard token * Fix linting issue * Add deployment script for the L2 token factory * Fix deploy script OVM_L2StandardTokenFactory constructor params * Add changeset * Cleanup deployment script for OVM_L2StandardTokenFactory and fix a solidity linting error * refactor(integration): Add clarity to the expectApprox function signature * fix: skip codechecks for PRs from external repos * DRAFT move react wallet and the contracts to more clear folders (#138) * DRAFT move react wallet and the contracts to more clear folders * merging the axios integration chagnes * updated the message-relayer-fast contracts * integrate message-relayer-fast into standard dockers * Dockerize the message-relayer-fast * update Readme.md * remove duplicated contracts - just keep everything in /contracts * add deploy for fast messenger * message-relayer-fast testing * Update serve.sh * Delete yarn.lock * Update constants.ts * Create yarn.lock * Update constants.ts * Update function-manipulation.spec.ts * increase the retries and other minor fixes * Improved documentation * fix omgx integration tests * Update omgx-integration.yml * integration test remove duplicated tests * Fix units test configuration * Update docker-compose-omgx-services.yml * integration test setup fixes * fix wallet integration test * fix for crash on return * integration tests for `message-relayer-fast` * Update env.ts * Autodeploy Token Bridges * Update wallet contracts * Update utils.ts * improve omgx integration tests * Add address manager address to GH actions for now Co-authored-by: sahil kashetwar <> Co-authored-by: Sahil k <sahil@enya.ai> Co-authored-by: cby3149 <cby3149@outlook.com> * merge conflicts * GH actions regular changes * husky * Daily sync up (#144) * build: set up eslint prettier correctly * style: run yarn lint --fix at root * build: add necessary packages to workspace root * build: remove --format stylish * build: set semvery ranges to match across packages * build: set up prettierrc.js for monorepo * refactor: rename Range to BlockRange * build: set up correct working directories * build: set up lint:fix to use eslint not prettier * style: run lint:fix on all code * build: remove prettier extension recommendation * style: update configuration to include babel-eslint for .js linting * build: set concurrency to 1 to prevent git add errors on lerna lint * github actions: bump geth CI golang version * fix(contracts): prevent L2->L1 calls to system contracts * Add Factory contract for creating standard ERC20 tokens compliant with the standard bridge * Disallow 0 address for l1 token when creating l2 standard token * Fix linting issue * Add deployment script for the L2 token factory * Fix deploy script OVM_L2StandardTokenFactory constructor params * Add changeset * Cleanup deployment script for OVM_L2StandardTokenFactory and fix a solidity linting error * refactor(integration): Add clarity to the expectApprox function signature * fix: skip codechecks for PRs from external repos Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: ben <ben@pseudonym.party> Co-authored-by: elenadimitrova <elena@arenabg.com> Co-authored-by: Reggie Gomez <reggieag@gmail.com> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * docker: pin to alpine 3.13 for l2geth A bug has appeared when older versions of Docker are used to build alpine based images in alpine version 3.14. To prevent this problem from happening to the users, this PR pins the version to 3.13. The observed problem is that `make` cannot run any command and the error message states `Operation not permitted.` Removing `make` was one way to solve the problem but that would increase the diff from upstream geth. See these links for details: https://github.com/alpinelinux/docker-alpine/issues/182 https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.14.0 * fix: update statement for skipping codechecks * contracts: add set-l2-gasprice task This task allows a user to update the L2 gas price using hardhat. An example of doing so would be: ```bash $ export CONTRACTS_DEPLOYER_KEY=0x.. $ CONTRACTS_RPC_URL=https://kovan.optimism.io npx hardhat set-l2-gasprice \ --l2-gas-price 1 ``` This hardcodes the predeploy address of the `OVM_GasPriceOracle` smart contract and the Owner must be used to do the updating, otherwise the transaction will revert. * removed unused functions from core utils * [added] changeset * next gen integration tests for the OMGX stack (#149) * next gen integration tests for the OMGX stack * finish first pass integration test outline * move LP tests to the `message-relayer-fast` * Update omgx-integration.yml * add more tests to message-relayer-fast * connect up the .env variables * hard code URIs * Update utils.ts * Update omgx-integration.yml * fix - should have been 8080 * Update omgx-integration.yml * which address to use? * Update omgx-integration.yml * removing not needed code * remove superfluous logging code * Update utils.ts * Update utils.ts * additional comments and formatting improvements * fix: use older changes on tests (#152) * fix: use older structure * correct messenger * LP fees on the correct side * correct messenger * rearrange depl order Co-authored-by: Souradeep Das <dsouradeep2@gmail.com> * Update README_OMGX.md (#150) Refactored some changes and added some comments I thought might be helpful for people. Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * tests: re-enable all tests (#155) * re-enable all tests * re-enable all tests * Add solhint to contracts package * Turn off compiler-version rule in solhint * Add suggestions by @maurelian https://github.com/ethereum-optimism/optimism/pull/1033#issuecomment-866146467 * Change solhint output formatting to table * Disable contract-name-camelcase rule in solhint * Fix max-line-length linting issues in contracts * Fix quotes linting issues in contracts * Remove private-vars-leading-underscore rule in solhint * Add contracts linting to github action * Fix for hardhat account balance parsing * Disable generating the bytecodeHash in hardhat contract artifacts * Review fixes * Fix review notes * Fix smockit for a change in hardhat ^2.4.0 which changes the way it parses errors from returndata Fix provided by @smartcontracts * dtl: configurable gas price backend Adds a new config option `--l1-gas-price-backend` or `DATA_TRANSPORT_LAYER_L1_GAS_PRICE_BACKEND` that can be set to `l1` or `l2`. This impacts the behavior of the HTTP endpoint `GET /eth/gasprice` by changing what is queried to return the L1 gas price. The L1 gas price is required to compute the L2 fee since the L2 fee consists of `L1 gas price * L1 gas used + L1 gas price * L2 gas limit`. If the L1 gas price differs too much between different L2 providers, then users using `eth_estimateGas` may submit transactions with too low of a fee and be unable to submit transactions to the sequencer. By configuring the DTL to use L2 as the L1 gas price backend, it will call the Sequencer's RPC endpoint `rollup_gasPrices` which returns the L1 and L2 gas prices from the point of view of the sequencer. The L2 gas price exists in the state, so that will always be the same between the sequencer and any replicas. The L1 gas price does not live on chain, so querying for it from the sequencer directly will ensure that users send transactions with a fee that is large enough. Also adds eth/gasprice info to README. * Remove bl wl service (#154) * replace `bl-wl` with direct calls the `omgx_deployer` * Update docker-compose-omgx-services.yml * Update up_local.sh * Add CORS headers to http servers * updated frontend to use the two new HTTP servers for the addresses * update webwallet to work with both local and rinkeby * Add missing .env variables to GH actions * re-enable docker tages * re-enable wallet transaction history * Update up_local.sh * Update up_local.sh * Add flag to omgx_deployer to only serve addresses w/o deploying new contracts * Update docker-compose-omgx-services.yml * Add back tagging system and improved reliability of GH actions * removed commented out service * add rinkeby token addresses (#161) Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * fix: lint deploy-l2 folder in contracts * Add AWS integration (#159) * Add AWS integration * Remove artifacts * updated ops_omgx/README.md and added .github/workflows/deploy2aws-integration.yml and .github/workflows/push2aws.yml * add automated provision and deletion of an ec2 instance for running the integration tests Co-authored-by: Petar Denev <pdenev@gmail.com> * fix: update CI to avoid running out of memory * Version Packages * ci: release latest image tags on release * feat: update README to include info about rebasing * Add op_exporter for sequencer metrics and health endoint Added metric for sequencer health Added Dockerfile for op_exporter; Fixed Dockerfile path * merge conflicts * re-comment out the usual GH actions * feat[integration-tests]: make tests work for prod networks * chore: add changeset * Increase client_body_buffer_size for rpc-proxy Added client_max_body_size to rpc-proxy config * l2geth: use `hexutil.Big` to prevent overflows The `RollupClient` decodes the JSON from the DTL as a uint64, this updates it to be a `big.Int` Includes a test for the value field that ensures it does not overflow * ci(contracts): only run codecov if contracts package is modified In order to skip running the CodeCov job when it isn't relevant, a new job was added to the ts-packges workflow. For a PR, this job identifies all the files modified between the base branch and the tip of the PR branch, and writes to a variable which can be used to decide if subsequent jobs should run. Github Actions provides an easy method for achieving this at the level of a workflow, but not for specific jobs within a workflow. * Version Packages * chore(ci): Skip codecov on push events * feat: add workflow for running SNX test suite * go: implement gasprices package The `gasprices` package implements the logic that updates L2 gasprices on the Optimistic Ethereum Network. Co-authored-by: Karl Floersch <karl@karlfloersch.com> * gas-oracle: implement and test This commit adds the `gas-oracle` which is an offchain entity that sends transactions to L2 to update the gas price. It must be configured with a private key as the `OVM_GasPriceOracle` is owned. The `gas-oracle` is added to the changesets setup. Tests are included as well as CI. Dockerizing will happen in a follow up PR. * gas-oracle: ci + docker build/publish Adds a dockerfile for the `gas-oracle` as well as adding it as a service in the `docker-compose.yaml`. It is not enabled by default due to memory issues in CI already happening occasionally where the integration tests are oom killed. The `gas-oracle` is configured with a key that owns the `OVM_GasPriceOracle`. This PR adds the `gas-oracle` to the Github Actions workflow that is responsible for publishing the docker images. * Add replica (#169) * fix: update erc20 deposits (#166) * fix: update erc20 deposits * fix: auto default token Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * resolve merge conflicts * Update docker-compose.yml * Update docker-compose.yml * [pull] develop from ethereum-optimism:develop (#164) * contracts: add set-l2-gasprice task This task allows a user to update the L2 gas price using hardhat. An example of doing so would be: ```bash $ export CONTRACTS_DEPLOYER_KEY=0x.. $ CONTRACTS_RPC_URL=https://kovan.optimism.io npx hardhat set-l2-gasprice \ --l2-gas-price 1 ``` This hardcodes the predeploy address of the `OVM_GasPriceOracle` smart contract and the Owner must be used to do the updating, otherwise the transaction will revert. * Add op_exporter for sequencer metrics and health endoint Added metric for sequencer health Added Dockerfile for op_exporter; Fixed Dockerfile path * feat[integration-tests]: make tests work for prod networks * chore: add changeset * Increase client_body_buffer_size for rpc-proxy Added client_max_body_size to rpc-proxy config * l2geth: use `hexutil.Big` to prevent overflows The `RollupClient` decodes the JSON from the DTL as a uint64, this updates it to be a `big.Int` Includes a test for the value field that ensures it does not overflow * ci(contracts): only run codecov if contracts package is modified In order to skip running the CodeCov job when it isn't relevant, a new job was added to the ts-packges workflow. For a PR, this job identifies all the files modified between the base branch and the tip of the PR branch, and writes to a variable which can be used to decide if subsequent jobs should run. Github Actions provides an easy method for achieving this at the level of a workflow, but not for specific jobs within a workflow. * Version Packages * chore(ci): Skip codecov on push events * feat: add workflow for running SNX test suite * go: implement gasprices package The `gasprices` package implements the logic that updates L2 gasprices on the Optimistic Ethereum Network. Co-authored-by: Karl Floersch <karl@karlfloersch.com> * gas-oracle: implement and test This commit adds the `gas-oracle` which is an offchain entity that sends transactions to L2 to update the gas price. It must be configured with a private key as the `OVM_GasPriceOracle` is owned. The `gas-oracle` is added to the changesets setup. Tests are included as well as CI. Dockerizing will happen in a follow up PR. * gas-oracle: ci + docker build/publish Adds a dockerfile for the `gas-oracle` as well as adding it as a service in the `docker-compose.yaml`. It is not enabled by default due to memory issues in CI already happening occasionally where the integration tests are oom killed. The `gas-oracle` is configured with a key that owns the `OVM_GasPriceOracle`. This PR adds the `gas-oracle` to the Github Actions workflow that is responsible for publishing the docker images. Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Ben Wilson <bwilson@optimism.io> Co-authored-by: Kelvin Fichter <kelvin@optimism.io> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: Ben Wilson <82120899+optimisticben@users.noreply.github.com> Co-authored-by: Kevin Ho <kevinjho1996@gmail.com> Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: Maurelian <maurelian@protonmail.ch> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Karl Floersch <karl@karlfloersch.com> * Update docker-compose.yml * adding l1-l2 test ecs scheduled task that does verify communication between L1 and L2 and L2 to L1 (#167) Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * Update docker-compose.yml * daily update (#170) * contracts: add set-l2-gasprice task This task allows a user to update the L2 …

* fix: import path (#1141) * fix: correct import path for altered contract path * chore: add changeset * refactor: improve logging for batch submission timeout scenarios (#1120) * Fixed CrossDomainMessenger name (#96) * Add highest L1 and L2 block number Gauge metrics to DTL (#1125) * build: add prom-client to data-transport-layer * refactor: thread metrics more carefully through data-transport-layer; add two new metrics * style: fix some style issues * refactor: make metrics mandatory * refactor: move metrics register code to top of file * style: apply linting * refactor: move promethesus initialization after express * refactor: move promBundle call up, provide registry * build: add changeset * Improve Watcher ability to find transactions (#1107) * remove listeners and use loop to find tx receipt * add yarn ready * moved filters inside loop * [added] changeset * Add minimal vscode settings and extensions (#1109) * chore: add minimal vscode settings and extensions * chore: Add "files.trimTrailingWhitespace" to vscode native config * chore: replace vscode prettier plugin with eslint plugin * fix[contracts]: remove part of MultiMessageRelayer deployment (#1144) * fix[contracts]: remove part of MultiMessageRelayer deployment * chore: add changeset * Define L1 Starting block via OwnershipTransferred rather than AddressSet (#1129) * Update service.ts * Create thirty-years-look.md Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * Easy fix for broken watchers (#1121) * Easy fix for broken watchers * Ran yarn changeset Co-authored-by: Liam Horne <liam@lihorne.com> * feat: go packages (#1111) * go: add utils module * readme: update * Version Packages (#1094) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * build: add husky pre-commit hook to lint (#1146) * feat[contracts]: add mainnet deploy script (#1147) * Add mainnet deploy script * Update mainnet.sh * Address PR review feedback * feat: mainnet contract deployment 0.4.0 (#1148) * feat: mainnet contract deployment 0.4.0 * feat: deployments readme * chore: add changeset * contracts: remove dead contract * contracts: remove dead config * tests: fix to not test for old contracts * feat: `rollup gasPrices` RPC endpoint (#1136) * feature: l2geth endpoint * chore: add changeset Co-authored-by: Liam Horne <liam@lihorne.com> * Adds l2 standard bridge to contracts markdown file (#1151) * Version Packages (#1150) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add more info about our branching strategy to the README (#1114) * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Remove references to OVM_L1ETHGateway in deployments and readme (#1119) * Keep the user logged in after changing chain (#99) * Keep the user logged in after changing chain * Update Nft.js * Detect if user is in the wrong chain Co-authored-by: cby3149 <cby3149@outlook.com> Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * Merge conflics resolve (#110) * wip * gethl2 * wip * batch submitter * core utils * DTL * message relayer * contracts * wip * Update service.ts * DTL * messaage-relayer * Update yarn.lock * final 5 files * [pull] develop from ethereum-optimism:develop (#91) * chore: reduce hardhat timeout to 20 seconds (#968) * fix: force LF line endings for scripts to avoid docker problems on Windows (#974) * fix: use correct line endings for windows * chore: add changeset * refactor[contracts]: Turn ExecutionManagerWrapper into a predeployed contract (#808) * wip: Started working on L2 contract testing revamp * test: clean tests for ProxyEOA * style: clean imports for ProxyEOA tests * test: port tests for ECDSAContractAccount * fix tests and add wrapper to dump * fix: add em wrapper to l2 deploy * ffix: add comments to wrapper contract * fix: add more comments * fix: add smock comment for unbind * Update packages/smock/src/smockit/binding.ts * maintenance[contracts]: use dashes in chain container names (#819) * maintenance: use dashes in chain container names * chore: add changeset * feat[contracts]: temporarily disable EOA upgrades (#857) * feat[contracts]: disable eoa upgrades temporarily * chore: add changeset * Update OVM_ProxyEOA.sol * fix: turn upgrade into a noop * lint: fix * feat[contracts]: Update Lib_AddressManager.AddressSet event to speed up data transport layer (#820) * feat: update and improve AddressSet event * chore: add changeset * Update Lib_AddressManager.sol * Reduce gas costs of deposits (#667) * Remove messageNonce from BaseCrossDomainMessenger and use CTC queue lenght instead Remove Abs_BaseCrossDomainMessenger and restore dedicated nonce generation in OVM_L2CrossDomainMessenger Fix typo * Remove sentMessages mapping from L1CrossDomainMessenger storage and use the nonce to check for existence of replayed transaction * Refactor out common library function for getting cross domain calldata * Post rebase fixes * Use the queueIndex to check the transaction was enqueued * Fix tests for L1CrossDomainMessenger.replayMessage Also make that test work with an actual CanonicalTransactionChain implementation rather than a smock * Lint fixes * Optimise the resolve calls into the AddressManager lib * Rename the nonce parameter to be clear * Update test name Co-authored-by: ben-chain <ben@pseudonym.party> * Rename getXDomainCalldata to encodeXDomainCalldata to match the new Lib_CrossDomainUtils Co-authored-by: ben-chain <ben@pseudonym.party> * optimism: bump gaslimit to 10 million #870 (#871) * optimism: bump gaslimit to 10million * chore: add changeset * optimism: bump max gaslimit to 10 mil * chore: add changeset * chore: remove unnecessary changeset * chore: remove unnecessary changeset Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * fix: use correct contract name in tests (#921) * fix: disable upgradability from ECDSA Account (#885) * l2geth: remove `SignatureHashType` (#752) * l2geth: remove tx type * l2geth: no longer parse type in rollup client * chore: add changeset * chore: remove extra sighash params * fix: do not check txtype in integration tests Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * feat[contracts]: introduce OVM_GasPriceOracle (#912) * feat[contracts]: congestion price oracle * chore: add changeset * contracts: gas price oracle (#917) * contracts: gas price oracle * tests: update * fees: fix tests * contracts: simplify gas price oracle * lint: fix * test: execution price is at the 1st storage slot * chore: rename predeploy to GasPriceOracle * chore: rename gas price oracle test name Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * fix: configure max gas limit to 11m (#928) Uniswap V3 contracts require that, otherwise they throw call exceptions at deployment * Consolidate Predeploy Addresses (#931) * added library for predeploy addresses * refactor tests and other packages to use exported predeploys * revert library usage in OVM_ECDSAContractAccount * lint * added newline * fixed address typos Co-authored-by: rajivpo <rajivpatel-oconnor@Rajivs-MacBook-Pro-2.local> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * chore: remove yarn-error.log and gitignore it (#956) * feat[contracts]: Replace Lib_RingBuffer with a much simpler Lib_Buffer (#821) * feat[contracts]: replace Lib_RingBuffer with a simpler Lib_Buffer * chore: changeset * test: add tests for Lib_Buffer * lint: fix * test: add extra coverage for Lib_Buffer * Update packages/contracts/contracts/optimistic-ethereum/libraries/utils/Lib_Buffer.sol Co-authored-by: ben-chain <ben@pseudonym.party> * add some extra comments Co-authored-by: ben-chain <ben@pseudonym.party> * fix(contracts): import predeploys (#982) * fix(contracts): import predeploys * fix: lint * feat: add hardhat deploy instructions to readme (#965) * feat: add deployment instructions to readme * Add changeset * fix style * Update README.md * feat: fees v2 (#976) * l2 geth: new fee logic * l2 geth: migrate to fees package * core-utils: new fee scheme * chore: add changeset * l2geth: delete dead code * integration-tests: fix typo * integration-tests: fixes * fees: use fee scalar * lint: fix * rollup: correct gas payment comparison * fix(integration-tests): do not hardcode gas price * core-utils: update with new scheme * l2geth: refactor rollup oracle * l2geth: clean up DoEstimateGas * l2geth: implement latest scheme * tests: fix up * lint: fix * l2geth: better sycn service test * optimism: rename to TxGasLimit * fee: fix docstring * tests: fix * variables: rename * l2geth: prevent users from sending txs with too high of a fee * integration-tests: fix import * integration-tests: fix type * integration-tests: fix gas limits * lint: fix * l2geth: log error Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * Add static analysis action (#848) * Add static analysis github action setup python and install slither * Add nvmrc file for setting node to v14.17 * Update slither command run to link missing contract packages from monorepo root * Add steps for installing dependencies * Add yarn build step to github action * Enable colour in github action for static analysis * Disable certain detectors * Ensure slither does not fail build * Add instructions on running static analysis to monorepo readme * build(deps): bump ws from 7.4.4 to 7.4.6 in /ops/docker/hardhat (#987) Bumps [ws](https://github.com/websockets/ws) from 7.4.4 to 7.4.6. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](https://github.com/websockets/ws/compare/7.4.4...7.4.6) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix[l2geth]: fix accidental merge conflict (#994) * feat[message-relayer]: relay tx generator (#952) * feat[message-relayer]: relay tx generator * whoops, I burned our infura key * fix minor bug * add comments * add more comments and clean stuff up * add empty test descriptions * add tests * move smock to dev deps * chore: add changeset * minor cleanup to merkle tree proof function * use bignumber math to avoid nested await * use a better interface * minor fixes and simplifications * backwards compatible dtl syncing (#986) * kovan: fix attempt * kovan: db fix * kovan: types are strings from db * l2geth: parse things as strings * chore: add changeset * dtl: also stringify the range query * geth: dereference * geth: assign err * dtl: handle null * dtl: fix unit tests * fix[smock]: fix broken call assertions for overloaded functions (#996) * fix[smock]: fix broken call assertions for overloaded functions * chore: add changeset * minor correction and add a test * add a test for non-overloaded functions * fix[message-relayer]: fix failing test because of merge with develop (#1000) * fix[message-relayer]: remove spreadsheet mode (#998) * fix[message-relayer]: remove spreadsheet mode * chore: add changeset * Lower local rollup timestamp refresh (#985) * update rollup timestamp refresh * increase refresh time to 5s * feat: fees v3 (#999) * core-utils: fee impl v3 * l2geth: fees v3 impl * integration-tests: update for fees v3 * chore: add changeset * fix: typo * integration-tests: fix and generalize * fees: update fee scalar * l2geth: check gas in the mempool behind usingovm * tests: fix up * l2geth: remove dead var * truffle: fix config * fix: remove dead coders (#1001) * chore: delete dead coders * chore: add changeset * dtl: remove dead imports * core-utils: delete dead tests * batch-submitter: remove txtype * chore: add changeset * docs[message-relayer]: add a README and improve the interface for generating proofs (#1002) * docs[message-relayer]: add basic docs and clean up an interface * chore: add changeset * dtl: log error stack for failed http request (#995) * dtl: log error stack for failed http request * chore: add changeset * Add rpc-proxy service for whitelisting JSON RPC methods to the sequencer. (#945) * Add healthcheck endpoint for rpc-proxy Added ethereum-nginx-proxy source updated README and docker image build * Check ETH_CALLS_ALLOWED is set, clean up comments, remove old Dockerfile * Pass additional information across domains via token gateways (#824) * feat(contracts): add from and data args to L1ERC20Gateway fix(integration): add gasLimit to fundUser refactor(contracts): add data to gateway events add changeset fix(integration): provide data in outboundTransfer refactor(contracts): reset Abs_L2TokenGateway to Abs_L2DepositedToken refactor(contracts): fix mismatched names * feat[contracts]: add custom gas arg to gateway fix(contracts): take max of user vs. default gas * fix(integrations): update ovm-eth function call * fix(integration): remove unecessary explicit gasLimit * test(contracts): 32kb transfer, 9MM gas * fix(contracts): fixup comment, bytes arg last * fix(integration): args order in integrations * fix(contracts): remove unused L2 gas arg * fix(contracts): limit data that can be passed to L2 * fix(integration): better tests for data length * test: check for error on too large data * Experimental: specify gaslimit in before hook * fix(integration): add l2 gas argument * fix: increase gas on fundUser * fix(contracts): remove duplicate max size limit * fix(integration): fine tune gas amounts * lint * fix: large data test * fix(integration): set gas closer to real cost * fix(contracts): remove unused bridge variables These variables were the default gas amounts for cross domain messages * fix(contracts): Reorder args Place dynamic length args last * fix(integration): update estimateGas values * fix(integration): reset eth withdraw estimate to 21000 * fix(integration): update expected gas amount * fix(integration): reduce gas amount for ETH withdraw * More consistent style for Constant values (#991) * chore(contracts): make container addresses be constants chore(contracts): consistent style for constant vars * chore(contracts): add internal on predeploy constants * feat: deployment config for fee oracle contract (#936) * feat[contracts]: add GasPriceOracle w/o predeploy Based on #912 * feat[contracts]: congestion price oracle * chore: add changeset * contracts: gas price oracle (#917) * contracts: gas price oracle * tests: update * fees: fix tests * contracts: simplify gas price oracle * lint: fix * test: execution price is at the 1st storage slot * chore: rename predeploy to GasPriceOracle * chore: rename gas price oracle test name Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * Add an L2 deploy script for gas oracle contract * Add a kovan deployment artifact * Add deployment to readme * Add extra validation & initial execution price * Update README.md * Fix execution price logic * Perform new deployment with final contract * contracts: better require in ovm gas price oracle * Deploy L2GasPriceOracle * Update contract to use new fee logic & rename to gas * Deploy updated contract * Fix lint * gas price oracle: do not restrict gas price * gas price oracle: new deployment * tests: delete dead test Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * ops: expose debug namespace (#1007) * develop merge fixes * refactor[l2geth]: queue origin type (#975) * refactor: queueOrigin type * Convert queueOrigin to uint8 in encode * Add changeset * Regenerate json marshall * style: combine lines * Add Stringer for QueueOrigin * Turn QueueOrigin into uint8 * l2geth: gen tx meta fix * l2geth: gen tx meta fix * lint Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> * fix(sync-service): prevent underflows (#1015) * fix(sync-service): prevent underflows * chore: add changeset * chore: remove dead confirmation depth * chore: remove eth1conf depth from rollup config * test: remove duplicate value in array (#1014) * ci: tag docker image for canary with abbreviated GITHUB_SHA (#1006) * ci: tag docker image for canary with abbreviated GITHUB_SHA * ci: update from 6 bytes to 8 bytes of abbreviation * refactor: improve logging for transactions being submitted to chain with gasPrice (#1016) * refactor: improve logging for transactions being submitted to chain with gasPrice * lint: apply lint autofixes * dtl: remove stringify from db logic + more overflow protection (#1010) * dtl: remove stringify from db logic * l2geth: overflow protection * dtl: overflow protection * chore: add changeset * ci: upload logs for failed integration tests (#1020) * fix(dtl): improve slow blocking JSON parsing that occurs during l2 sync (#1019) The use of eth_getBlockRange returns a large response which is very slow to parse in ethersjs, and can block the event loop for upwards of multiple seconds. When this happens, incoming http requests will likely timeout and fail. Instead, we will parse the incoming http stream directly with the bfj package, which yields the event loop periodically so that we don't fail to serve requests. * fix: lint errors in dtl (#1025) * fix[dtl]: fix dtl bug breaking verifiers (#1011) * fix[dtl]: fix dtl bug breaking verifiers * tweaks so tests pass * chore: add changeset * fix: deterministic blockhashes (#1032) * config: set etherbase * l2geth: add deterministic clique key * l2geth: default value * chore: add changeset * test: add sync test for deterministic blockhash Co-authored-by: Kevin Ho <kevinjho1996@gmail.com> * Version Packages (#978) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * ci: add sync test's own workflow (#1031) * fix(dtl): incorrect parsing of eth_getBlockRange result (#1037) * Version Packages (#1045) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: no gas refund (#1043) * l2geth: remove the gas refund * chore: add changeset * refactor[contracts]: remove one-off GasPriceOracle deployment file (#1046) * refactor[contracts]: remove one-off gpo deployment * chore: add changeset * feat[contracts]: introduce new L1ChugSplashProxy contract (#1009) * feat[contracts]: add L1ChugSplashProxy * improve comments slightly * start adding tests * add more tests * make the system pausable * added another test * add some extra comments * Update packages/contracts/test/contracts/chugsplash/L1ChugSplashProxy.spec.ts Co-authored-by: Maurelian <maurelian@protonmail.ch> * Update packages/contracts/test/contracts/chugsplash/L1ChugSplashProxy.spec.ts Co-authored-by: Maurelian <maurelian@protonmail.ch> * chore: add changeset * address review feedback Co-authored-by: Maurelian <maurelian@protonmail.ch> * feat[contracts]: add sequencer fee wallet (#1029) * wip: first draft of the fee wallet * add fee wallet to dump * rename to sequencer vault * add L1 fee wallet to geth config * add unit tests * fix geth linting error * add a basic integration test * fix broken integration test * add test for correct storage slot * add integration test for fee withdrawal * fix typo in integration tests * fix a bug bin integration tests * Update OVM_SequencerFeeVault.sol * fix bug in contract tests * chore: add changeset * fix bug in contract tests * build(deps): bump glob-parent from 5.1.1 to 5.1.2 (#1036) Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2. - [Release notes](https://github.com/gulpjs/glob-parent/releases) - [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md) - [Commits](https://github.com/gulpjs/glob-parent/compare/v5.1.1...v5.1.2) --- updated-dependencies: - dependency-name: glob-parent dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: Liam Horne <liam@lihorne.com> * fix: predeploy gasprice oracle (#1039) * l2geth: delete extra config options * l2geth: stop using extra config options * l2geth: more stop using extra config options * chore: add changeset * l2geth: add new config for gpo owner * chore: add changeset * l2geth: fix tests * tests: fix build * l2geth: optimize loops (#1027) * l2geth: optimize loops * l2geth: stop ticker when done * l2geth: don't wait for first tick * chore: add changeset * Enable custom tagging of release docker image (#1048) * ci: enable custom tagging of release docker image * ci: refactor to add prerelease prefix for secuirty * doc: typo * ci: fix indentation issue of canary workflow * ci: fix typo with GITHUB_SHA * fix: typo in USE_HARDHAT config (#1023) * fix: abi encoded tx (#1049) * contracts: don't double rlp decode * chore: add changeset * lint: fix * deps: update * linting: cleanup * feat: contracts: use selector * fix: contracts: use typescript * contracts: use interface * l2geth: bump to go 1.15 (#1058) * l2geth: bump to go 1.15 * chore: add changeset * Change monotonicity band-aid code to log warnings not errors (#1060) * refactor: change monotonicity band-aid code to log warnings not errors * build: add changeset * feat(contracts, l2geth): native ETH value support for ovmCALL (#1038) * feat(contracts): add ovmCALL-types with native value * add ovmCALLVALUE context * add ovmBALANCE * test success and revert cases * test empty contract case * chore: lint * test(integration-tests): ovmCALL-types with value (compiler and wrapper) * fix ovmDELEGATECALL type, update tests * add ovmSELFBALANCE * fix ovmDELEGATECALL jumping to CALL * chore: lint * fix(contracts): account for intrinsic gas of OVM_ETH sends * fix(contracts): merge conflict bug * fix(contracts): update gas benchmark * feat(contracts, integration-tests): use new value-compatible compiler * feat(contracts,l2geth): support value calls in OVM_ECDSAContractAccount * fix(contracts): ovmDELEGATECALL does not change message context * feat(contracts): sending value between EOAs * test(integration-tests): ovmDELEGATECALL preserves ovmCALLVALUE * test(integration-tests): assert ovmSELFBALANCEs correct * test(integration-tests): intrinsic gas for eth value calls * test(integration-tests): update gas values * chore(contracts): lint * feat(contracts, l2geth): eth_calls with nonzero value * chore: minor fixups and comments based on PR feedback * test(integration-tests): add requested tests from PR reviews * test(integration-tests): ovmSELFBALANCE is preserved in ovmDELEGATECALLs * fix(contracts): fix bug where ovmDELEGATECALL could fail if balance was lower than the ovmCALLVALUE * chore: add changeset * fix(contracts): update intrinsic gas for worst-case value sends * chore: address final PR nits/improvements Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> * Add erc1271 support to contract account (#1052) * add ERC1271 support, failing unit tests * add integration test for isValidSignature * remove .only * lint * add changeset * clean up 1271 tests and lint * switch back to using waffle wallet * lint * fix import * feat[contracts]: slightly better account funding for hardhat accounts (rebased) (#1065) * feat[contracts]: better account funding for hardhat accounts * add a sleep to avoid any potential problems * chore: add changeset * fix: bug with gas estimation in funding step * fix: limit to 20 accounts max Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> * Ensure Sentry is correctly set up for DTL and MR (#1054) * refactor: add logger and metrics to options for BaseService * refactor: thread sentryOptions through from message-relayer into BaseService * refactor: ensure DTL Logger is using Sentry for errors * style: lint base-service.ts * refactor: init Sentry on batch-submitter too * refactor: init Sentry on message-relayer too * refactor: pass in basic logger to MessageRelayerService * build: provide changeset * fix: correct usage of use-sentry boolean config * refactor: appropriately type loggingOptions * build: add @sentry/node * build: add @sentry/node to message-relayer and fix linting issue * Add more logging information to monotonicity violation logs (#1066) * refactor: log idx of monotonicity violation from batch * build: add changeset * temporarily disable hardhat example tests (#1071) * fix: monotonicity auto healer (#1070) * fix: monotonicity auto healer * add: changeset * Version Packages (#1053) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Standard token bridge (#988) * Remove abstract token gateway and deposited token implementations * Further simplification of bridge contracts * Standart token bridge and L2 token implementation * Fix spacing * Implement case when a bad deposit happens to a nonexistent L1<>L2 token pair * Use SafeMath in common token bridge accounting * test(contracts): fix finalizeWithdrawal test * fix(contracts): use SafeERC20 on token deposits * Rename OVM_L1ERC20Gateway to OVM_L1ERC20Bridge contract * Rename iOVM_L1ERC20Gateway to iOVM_L1ERC20Bridge contract * Cleanup gateway to bridge rename * Better name for the mapping holding l1->l2 deposit amounts * Use OZ SafeMath * Rename local variables in OVM_L2DepositedERC20 from gateway to bridge * Merge ETH and ERC20 bridge contracts * Rename OVM_L1ERC20Bridge to OVM_L1StandardBridge and fix tests from merging the ETH and ERC20 bridges * Better name for iAbs_BaseCrossDomainMessenger -> iOVM_CrossDomainMessenger * Correct the bounce back of deposit sender and recipient properties * Remove obsoleted event from OVM_L2DepositedERC20 * chore(contracts): change references from ETHGateway to Bridge * Fix a linting error * fix(contracts): add bridge to deployer * Split off ERC20Bridge interface for the purposes of being reused in custom ERC20 bridges * Split off interface natspec definitions * Draft version of OVM_L2DepositedERC20 splitted into a standard L2 erc20: L2StandardERC20 and a common L2 bridge: OVM_L2StandardBridge * style(contracts): define L1_ETH_ADDRESS as constant * test(integration): update interface to use depositETH * test(contracts): fix OVM_L1StandardBridge tests * test(contracts): fix L2 Standard Bridge tests * test(contracts): lint and remove an obsolete test case * Fix modifier check to comply with the L2 bridge distinction from L2 token * Simplify address <> interface casting in bridges * Ensure natspec comments are correct also add l1 and l2 token params to WithdrawalInitiated event for consistency * Fix issues in L1 and L2 bridges to ensure cross domain messages are sent only between the two bridges also adjusted withdrawals to send to either finalizeETHWithdrawal or finalizeERC20Withdrawal depending on which asset is being withdrawn * Remove AddressManager from the L1 standard bridge * REVERT ME: instruments cross domain enabled * fix(contracts): remove Address Manager from L1 Bridge * feat(contracts): make L2 Standard Bridge a predeploy * WIP: update deployments for standard bridges * WIP: update deployments for standard bridges * l2geth: TEMP log contract calls * chore(l2geth): replace eth gateway with standard bridge * fix(contracts): make contract-deployment/config work * WIP fix(integration): update integration tests for bridge * Remove ovmEth from L1 Standard bridge as obsoleted * Separate ERC20 standard implementation from L2 bridge * Formatting fixes * chore(l2geth): replace eth gateway with standard bridge * Revert "REVERT ME: instruments cross domain enabled" This reverts commit d5bb8f8f67974d0a3e65fc000f08858328a4bbbc. * fix: lint ts * Implement EIP-165 in the Standard L2 ERC20 token Also switch that to be based off the OpenZeppelin default implementation plus mint and burn Additionally remove the obsoleted iOVM_ERC20 * fix(contracts): add deployment check on bridge proxy fix(contracts): whitespace fix(contracts): init bridge implementation with non-zero address * Remove dependency on Ownable contract for the StandardERC20 token on L2 * fix(contracts): update deployment scripts * fix: lint * remove debugging code * fix: correct rpc get balance slot * restore l2 cross domain messenger * fix: lint * Add a test for a non compliant token deposit * Only allow EOAs to deposit ETH and ERC20 * Add comments and tests for ERC165 implementation * Decide against using explicit ETH MOCK address as we're not using it for checks * Fix linting issues * Add onlyEOAContract restriction to standard bridge withdrawals * Update codehashes in L2 Standard bridge * fix(ops): remove unintentionally added file * feat(contracts): add expectApproxGasCost function * fix(integration): proper arrayify input on fundUser * fix(integration): proper gas value checks * Revert "Add onlyEOAContract restriction to standard bridge withdrawals" This reverts commit 2713c06ceb2609e4f13718e1034a4d76210d9758. * fix(contracts): removed unused expectApproxGasCost for now * fix(contracts): update OVM_SequencerFeeVault for bridge changes * lint * Update deployment for L1 Bridge w/ ChugSplash * Revert "l2geth: TEMP log contract calls" This reverts commit 21d42259278449f221bf34605162229b3d9d4fa9. * Apply suggestions from code review * Apply suggestions from code review * fix(contracts): deploy with chugsplash proxy * fix(contracts): add working bridge and chugsplash proxy deployment * fix(contracts,integration): 500k gas for depositETH * comment(contracts): describe failed deposit handling on l2 * Apply suggestions from code review Co-authored-by: ben-chain <ben@pseudonym.party> * docs: add changeset * fix(integration): set working l2 gas amount on funduser * test(integration): add receive() test * fix(contracts): reset receive to 1.2MM l2 gas * test(examples): skip l1-l2 example test for now * fix(contracts): drop hardcoded gas to 500k in receive() * fix(contracts): use abi.encodeWithSignature * fix(contracts): resolve merge conflicts * feat(integration): add expectApprox for flexible gas testing * fix(integration): fix failing gas tests * fix: incorrect l2 gas for deposit * Update utils.ts * fix(workflow): disable l1-l2 example until npm imports are fixed * chore: final round of PR review nits and tests Co-authored-by: Maurelian <maurelian@protonmail.ch> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: ben-chain <ben@pseudonym.party> Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> * fix: comment out codeowners (#1073) * fix: use predeploy constant lib for em wrapper (#1075) * fix: use predeploy constant lib for em wrapper * chore: add changeset * fix[l2geth]: off-by-one sometimes breaking replica sync (#1082) * fix[l2geth]: off-by-one sometimes breaking replica sync * chore: add changeset * fix(l2geth): Log 'end of OVM execution' correctly (#1080) * refactor[contracts]: move account contracts to predeploy folder (#1085) * refactor[contracts]: move account contracts to predeploy folder * chore: add changeset * maintenance[contracts]: rename precompiles test folder to predeploys (#1086) * fix[bs]: disambiguate generic submission errors (#1051) * fix[bs]: disambiguate generic submission errors * add cases for errors * separate out errors from transaction reverts with reasons * remove extraneous errors * WETH deposit and withdraw on OVM_ETH (#1083) * feat(contracts): add no-op WETH9 functionality to OVM_ETH * working WETH deposit and withdraw + tests * add changeset * address PR feedback * update WETH9 contract implementation * add fallback to WETH9 * add fallback and revert withdraw test * update nit comment Co-authored-by: ben <ben@pseudonym.party> * Also move the accounts interface to iOVM/predeploys (#1087) * refactor[contracts]: move account interface to predeploy folder * chore: add changeset * Version Packages (#1089) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: use -z flag for var unset in canary * Use Eslint instead of Tslint (#1005) * removed tslint * forgot to commit files * made .eslintrc.js consistent for all subdirs and other cleanup * [removed] includes and files keys from tsconfig.json * removed file level linting exceptions and added details to line level * added changeset * fixed newly introduced linting errors from rebase * enable json import for batch submitter * removed ecdsa-coder * maybe a tsconfig issue? * Update deploy.ts Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: platocrat <37757724+platocrat@users.noreply.github.com> * metrics[batch-submitter]: add new batch submitter metrics (#1074) * metrics[batch-submitter]: add new batch submitter metrics * chore: changeset * account for failed submissions * Fix canary publishing (#1093) * ci: fix custom docker tag * ci: use new env file * ci: use outputs from previous job * ci: fix headers of jobs * ci: inherit canary tag from builder * feat[ci]: upload logs for sync tests if failure (#1098) * deploy: goerli 0.4.0 (#1099) * deployments: goerli 0.4.0 rc * readme: update * chore: add changeset * fix[dtl]: defend against RPC provider missing events (#1084) * fix[dtl]: defend against RPC provider missing events * chore: add changeset * respond to review comments * better error handling for missing handlers * deploy: kovan v.4.0 rc (#1101) * deploy: kovan v0.4.0 rc * chore: add changeset * readme: update * maintenance[monorepo]: first pass update to README (#1106) * maintenance[monorepo]: first pass update to README Doing some relatively minor updates to the README just to clean things up a bit. * replying to review comments * Move the metric prefix string to a label (#1047) Added changeset and fixes Changeset to patch * fix[smock]: add support for hardhat 2.4.0 (#1112) * fix[smock]: add support for hardhat 2.4.0 * chore: add changeset * lint: fix * build(deps): bump hosted-git-info from 2.8.8 to 2.8.9 (#1064) Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](https://github.com/npm/hosted-git-info/compare/v2.8.8...v2.8.9) --- updated-dependencies: - dependency-name: hosted-git-info dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * Misc. small improvements to README (#1115) * Update README.md * Update README.md * fix[dtl]: use the same L2 chain ID everywhere (#1122) * fix[dtl]: use the same L2 chain ID everywhere * chore: add changeset * fix: make sync tests only on workflow dispatch (#1123) * fix[dtl]: remove old stringification function (#1134) * fix[dtl]: remove old stringification function * chore: add changeset * fix[dtl]: log server errors as ERROR instead of INFO (#1133) * fix[dtl]: log server errors as ERROR instead of INFO * chore: add changeset * Contracts: connectL1Contracts & connectL2Contracts (#713) * Contracts: connect-contracts * Trying to resolve build problems * connect-contracts build working * Adds artifacts-ovm back to gitignore * Removes incorrect changes * Adds copy-artifacts script * Adds test file (not working yet) * fix: incorrect contract instantiation * Improves tests and removes old deployment versions * Single source of truth for predeploy addresses * Reverts deployments/README.md * Makes connect-contracts more DRY * Adds missing @ethersproject/abstract-signer dependency * Adds argument evaluation * Adds L1Contracts and L2Contracts types * Attempts removing artifacts-ovm again * Adds webpack config (not working yet) * build: add artifacts to dist (#776) * Updates lint rule * Adds l2 imports * Fixes dependency tree bug * Removes webpack stuff * Fixing package.json issues and adds .DS_Store to gitignore * Removes test-contracts script * Reverting script change * Adds comments * Adds comment * Renames deployments folders * Fixes linting errors * Generates markdown * build: add deployments directory to Dockerfiles * Removes unneeded contracts, improves error handling and tests * Adds changeset * yarn.lock * Removes console.log * Changes from minor to patch version * Fixes lint errors Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * fix: prevent overflow in abi encoding (#1135) * l2geth: prevent overflow in abi encoding to ovm codec tx * chore: add changeset * tests: replica syncing (#981) * [wip] add l2_dtl and replica images * passing basic dummy tx test * add erc20 test * add sync test to ci Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> * fix[relayer]: update exported files list in package.json (#1138) * fix[relayer]: update exported files * chore: add changeset * fix: import path (#1141) * fix: correct import path for altered contract path * chore: add changeset * refactor: improve logging for batch submission timeout scenarios (#1120) * Add highest L1 and L2 block number Gauge metrics to DTL (#1125) * build: add prom-client to data-transport-layer * refactor: thread metrics more carefully through data-transport-layer; add two new metrics * style: fix some style issues * refactor: make metrics mandatory * refactor: move metrics register code to top of file * style: apply linting * refactor: move promethesus initialization after express * refactor: move promBundle call up, provide registry * build: add changeset * Improve Watcher ability to find transactions (#1107) * remove listeners and use loop to find tx receipt * add yarn ready * moved filters inside loop * [added] changeset * Add minimal vscode settings and extensions (#1109) * chore: add minimal vscode settings and extensions * chore: Add "files.trimTrailingWhitespace" to vscode native config * chore: replace vscode prettier plugin with eslint plugin * fix[contracts]: remove part of MultiMessageRelayer deployment (#1144) * fix[contracts]: remove part of MultiMessageRelayer deployment * chore: add changeset * Define L1 Starting block via OwnershipTransferred rather than AddressSet (#1129) * Update service.ts * Create thirty-years-look.md Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * Easy fix for broken watchers (#1121) * Easy fix for broken watchers * Ran yarn changeset Co-authored-by: Liam Horne <liam@lihorne.com> * feat: go packages (#1111) * go: add utils module * readme: update * Version Packages (#1094) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * build: add husky pre-commit hook to lint (#1146) * feat[contracts]: add mainnet deploy script (#1147) * Add mainnet deploy script * Update mainnet.sh * Address PR review feedback * feat: mainnet contract deployment 0.4.0 (#1148) * feat: mainnet contract deployment 0.4.0 * feat: deployments readme * chore: add changeset * contracts: remove dead contract * contracts: remove dead config * tests: fix to not test for old contracts * feat: `rollup gasPrices` RPC endpoint (#1136) * feature: l2geth endpoint * chore: add changeset Co-authored-by: Liam Horne <liam@lihorne.com> * Adds l2 standard bridge to contracts markdown file (#1151) * Version Packages (#1150) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add more info about our branching strategy to the README (#1114) * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Remove references to OVM_L1ETHGateway in deployments and readme (#1119) Co-authored-by: Maurelian <maurelian@protonmail.ch> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: Elena Gesheva <elena@arenabg.com> Co-authored-by: ben-chain <ben@pseudonym.party> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> Co-authored-by: Karl Floersch <karl@karlfloersch.com> Co-authored-by: Rajiv Patel-O'Connor <rajiv.patel.oconnor@gmail.com> Co-authored-by: rajivpo <rajivpatel-oconnor@Rajivs-MacBook-Pro-2.local> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kevin Ho <kevinjho1996@gmail.com> Co-authored-by: Ben Wilson <82120899+optimisticben@users.noreply.github.com> Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: Tim Myers <timmyers09@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Annie Ke <annieke8@gmail.com> Co-authored-by: platocrat <37757724+platocrat@users.noreply.github.com> Co-authored-by: Matt Masurka <m.masurka@gmail.com> Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> Co-authored-by: Alejandro Santander <Palebluedot@gmail.com> * Re-apply key changes on top of optimism most current develop * Add docker-compose-replica.yml (#109) * Create docker-compose-replica.yml * Add replica service * Update docker-compose-omgx-replica.yml Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * fix linter; patch gethl2 * configure the deployer correctly * fix proposer / batch submitter * update chainIDs * update rpc test * Create README_OMGX.md * upstream - needs more work * Adds delay to watcher (#1159) * Adds delay to watcher * Simplifies delay * Adds changeset * Fix wallet test * Fix deployment test * Add Python * Update Dockerfile.omgx_monorepo * Remove package-lock * fix: bind dtl functions for missing event codepath (#1161) * dtl: bind this in L1 missing element error handlers * dtl: add additional logline * chore: add changeset * dtl: add more metrics * dtl: use counter instead of gauge Co-authored-by: Kevin Ho <kevinjho1996@gmail.com> * fix: remove 'editor.formatOnSave' from global settings' (#1163) * merge conflicts * Update pre-commit * Version Packages (#1167) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * minor * Update pre-commit * Fix wallet test (#119) * Fix wallet test * Fix deployment test * Add Python * Update Dockerfile.omgx_monorepo * Remove package-lock Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * Reapply standard changes on top of current develop * Update package.json * doc: add notes for releasing new versions with changesets (#1166) * Bind correct object to method handler in DTL (#1168) * fix: bind correct object to method handler * build: add changeset * Version Packages (#1169) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix web wallet * Fix integration test (#124) * Fix integration test (#125) * Fix integration test * Fix integration test * Fix wallet_react * Fix lint test * Remove package-lock * Update integration.yml * Fix wallet deployer * Collect docker log * Fix l1-l2-deposit-withdrawal test * Fix sync test * Add chainID to deployer config * make sync tests dispatch only Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * Add short contribution section to primary README (#1157) * Add short contribution section to primary README * Update README.md * fix: prevent batch submitter from submitting batches if low on ETH * build: add changeset * Eslint ignore the hardhat folder * Update README.md * Beginning to add working examples * hardhart and waffle example tests * document/check waffle * test l1-l2 example * add patch-package * Update package.json * build: ensure lint only staged files on commit * refactor: do not run --fix on lint-staged * refactor: *.{ts,js} for eslint regex * l2geth: rollup client explicitly checks for >= 400 errors * l2geth: sync service retries connection to remote server * l2geth: test errors returning from remote * chore: add changeset * syncservice: nit * feat[message-relayer]: add easy relay tool * chore: add changeset * upkeep[monorepo]: add changeset info to README * merge conflict squash * Daily sync up (#137) * build: ensure lint only staged files on commit * refactor: do not run --fix on lint-staged * refactor: *.{ts,js} for eslint regex * l2geth: rollup client explicitly checks for >= 400 errors * l2geth: sync service retries connection to remote server * l2geth: test errors returning from remote * chore: add changeset * syncservice: nit * feat[message-relayer]: add easy relay tool * chore: add changeset * upkeep[monorepo]: add changeset info to README Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Kelvin Fichter <kelvin@optimism.io> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * build: set up eslint prettier correctly * style: run yarn lint --fix at root * build: add necessary packages to workspace root * build: remove --format stylish * build: set semvery ranges to match across packages * build: set up prettierrc.js for monorepo * refactor: rename Range to BlockRange * build: set up correct working directories * build: set up lint:fix to use eslint not prettier * style: run lint:fix on all code * build: remove prettier extension recommendation * style: update configuration to include babel-eslint for .js linting * build: set concurrency to 1 to prevent git add errors on lerna lint * github actions: bump geth CI golang version * fix(contracts): prevent L2->L1 calls to system contracts * Update message relayer fast contracts (#139) * prepare for wallet reorg * Create yarn.lock * fix hardhat bug * merge conflict resolve * daily sync up (#141) * build: set up eslint prettier correctly * style: run yarn lint --fix at root * build: add necessary packages to workspace root * build: remove --format stylish * build: set semvery ranges to match across packages * build: set up prettierrc.js for monorepo * refactor: rename Range to BlockRange * build: set up correct working directories * build: set up lint:fix to use eslint not prettier * style: run lint:fix on all code * build: remove prettier extension recommendation * style: update configuration to include babel-eslint for .js linting * build: set concurrency to 1 to prevent git add errors on lerna lint * fix(contracts): prevent L2->L1 calls to system contracts Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: ben <ben@pseudonym.party> * Add Factory contract for creating standard ERC20 tokens compliant with the standard bridge * Disallow 0 address for l1 token when creating l2 standard token * Fix linting issue * Add deployment script for the L2 token factory * Fix deploy script OVM_L2StandardTokenFactory constructor params * Add changeset * Cleanup deployment script for OVM_L2StandardTokenFactory and fix a solidity linting error * refactor(integration): Add clarity to the expectApprox function signature * fix: skip codechecks for PRs from external repos * DRAFT move react wallet and the contracts to more clear folders (#138) * DRAFT move react wallet and the contracts to more clear folders * merging the axios integration chagnes * updated the message-relayer-fast contracts * integrate message-relayer-fast into standard dockers * Dockerize the message-relayer-fast * update Readme.md * remove duplicated contracts - just keep everything in /contracts * add deploy for fast messenger * message-relayer-fast testing * Update serve.sh * Delete yarn.lock * Update constants.ts * Create yarn.lock * Update constants.ts * Update function-manipulation.spec.ts * increase the retries and other minor fixes * Improved documentation * fix omgx integration tests * Update omgx-integration.yml * integration test remove duplicated tests * Fix units test configuration * Update docker-compose-omgx-services.yml * integration test setup fixes * fix wallet integration test * fix for crash on return * integration tests for `message-relayer-fast` * Update env.ts * Autodeploy Token Bridges * Update wallet contracts * Update utils.ts * improve omgx integration tests * Add address manager address to GH actions for now Co-authored-by: sahil kashetwar <> Co-authored-by: Sahil k <sahil@enya.ai> Co-authored-by: cby3149 <cby3149@outlook.com> * merge conflicts * GH actions regular changes * husky * Daily sync up (#144) * build: set up eslint prettier correctly * style: run yarn lint --fix at root * build: add necessary packages to workspace root * build: remove --format stylish * build: set semvery ranges to match across packages * build: set up prettierrc.js for monorepo * refactor: rename Range to BlockRange * build: set up correct working directories * build: set up lint:fix to use eslint not prettier * style: run lint:fix on all code * build: remove prettier extension recommendation * style: update configuration to include babel-eslint for .js linting * build: set concurrency to 1 to prevent git add errors on lerna lint * github actions: bump geth CI golang version * fix(contracts): prevent L2->L1 calls to system contracts * Add Factory contract for creating standard ERC20 tokens compliant with the standard bridge * Disallow 0 address for l1 token when creating l2 standard token * Fix linting issue * Add deployment script for the L2 token factory * Fix deploy script OVM_L2StandardTokenFactory constructor params * Add changeset * Cleanup deployment script for OVM_L2StandardTokenFactory and fix a solidity linting error * refactor(integration): Add clarity to the expectApprox function signature * fix: skip codechecks for PRs from external repos Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: ben <ben@pseudonym.party> Co-authored-by: elenadimitrova <elena@arenabg.com> Co-authored-by: Reggie Gomez <reggieag@gmail.com> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * docker: pin to alpine 3.13 for l2geth A bug has appeared when older versions of Docker are used to build alpine based images in alpine version 3.14. To prevent this problem from happening to the users, this PR pins the version to 3.13. The observed problem is that `make` cannot run any command and the error message states `Operation not permitted.` Removing `make` was one way to solve the problem but that would increase the diff from upstream geth. See these links for details: https://github.com/alpinelinux/docker-alpine/issues/182 https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.14.0 * fix: update statement for skipping codechecks * contracts: add set-l2-gasprice task This task allows a user to update the L2 gas price using hardhat. An example of doing so would be: ```bash $ export CONTRACTS_DEPLOYER_KEY=0x.. $ CONTRACTS_RPC_URL=https://kovan.optimism.io npx hardhat set-l2-gasprice \ --l2-gas-price 1 ``` This hardcodes the predeploy address of the `OVM_GasPriceOracle` smart contract and the Owner must be used to do the updating, otherwise the transaction will revert. * removed unused functions from core utils * [added] changeset * next gen integration tests for the OMGX stack (#149) * next gen integration tests for the OMGX stack * finish first pass integration test outline * move LP tests to the `message-relayer-fast` * Update omgx-integration.yml * add more tests to message-relayer-fast * connect up the .env variables * hard code URIs * Update utils.ts * Update omgx-integration.yml * fix - should have been 8080 * Update omgx-integration.yml * which address to use? * Update omgx-integration.yml * removing not needed code * remove superfluous logging code * Update utils.ts * Update utils.ts * additional comments and formatting improvements * fix: use older changes on tests (#152) * fix: use older structure * correct messenger * LP fees on the correct side * correct messenger * rearrange depl order Co-authored-by: Souradeep Das <dsouradeep2@gmail.com> * Update README_OMGX.md (#150) Refactored some changes and added some comments I thought might be helpful for people. Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * tests: re-enable all tests (#155) * re-enable all tests * re-enable all tests * Add solhint to contracts package * Turn off compiler-version rule in solhint * Add suggestions by @maurelian https://github.com/ethereum-optimism/optimism/pull/1033#issuecomment-866146467 * Change solhint output formatting to table * Disable contract-name-camelcase rule in solhint * Fix max-line-length linting issues in contracts * Fix quotes linting issues in contracts * Remove private-vars-leading-underscore rule in solhint * Add contracts linting to github action * Fix for hardhat account balance parsing * Disable generating the bytecodeHash in hardhat contract artifacts * Review fixes * Fix review notes * Fix smockit for a change in hardhat ^2.4.0 which changes the way it parses errors from returndata Fix provided by @smartcontracts * dtl: configurable gas price backend Adds a new config option `--l1-gas-price-backend` or `DATA_TRANSPORT_LAYER_L1_GAS_PRICE_BACKEND` that can be set to `l1` or `l2`. This impacts the behavior of the HTTP endpoint `GET /eth/gasprice` by changing what is queried to return the L1 gas price. The L1 gas price is required to compute the L2 fee since the L2 fee consists of `L1 gas price * L1 gas used + L1 gas price * L2 gas limit`. If the L1 gas price differs too much between different L2 providers, then users using `eth_estimateGas` may submit transactions with too low of a fee and be unable to submit transactions to the sequencer. By configuring the DTL to use L2 as the L1 gas price backend, it will call the Sequencer's RPC endpoint `rollup_gasPrices` which returns the L1 and L2 gas prices from the point of view of the sequencer. The L2 gas price exists in the state, so that will always be the same between the sequencer and any replicas. The L1 gas price does not live on chain, so querying for it from the sequencer directly will ensure that users send transactions with a fee that is large enough. Also adds eth/gasprice info to README. * Remove bl wl service (#154) * replace `bl-wl` with direct calls the `omgx_deployer` * Update docker-compose-omgx-services.yml * Update up_local.sh * Add CORS headers to http servers * updated frontend to use the two new HTTP servers for the addresses * update webwallet to work with both local and rinkeby * Add missing .env variables to GH actions * re-enable docker tages * re-enable wallet transaction history * Update up_local.sh * Update up_local.sh * Add flag to omgx_deployer to only serve addresses w/o deploying new contracts * Update docker-compose-omgx-services.yml * Add back tagging system and improved reliability of GH actions * removed commented out service * add rinkeby token addresses (#161) Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * fix: lint deploy-l2 folder in contracts * Add AWS integration (#159) * Add AWS integration * Remove artifacts * updated ops_omgx/README.md and added .github/workflows/deploy2aws-integration.yml and .github/workflows/push2aws.yml * add automated provision and deletion of an ec2 instance for running the integration tests Co-authored-by: Petar Denev <pdenev@gmail.com> * fix: update CI to avoid running out of memory * Version Packages * ci: release latest image tags on release * feat: update README to include info about rebasing * Add op_exporter for sequencer metrics and health endoint Added metric for sequencer health Added Dockerfile for op_exporter; Fixed Dockerfile path * merge conflicts * re-comment out the usual GH actions * feat[integration-tests]: make tests work for prod networks * chore: add changeset * Increase client_body_buffer_size for rpc-proxy Added client_max_body_size to rpc-proxy config * l2geth: use `hexutil.Big` to prevent overflows The `RollupClient` decodes the JSON from the DTL as a uint64, this updates it to be a `big.Int` Includes a test for the value field that ensures it does not overflow * ci(contracts): only run codecov if contracts package is modified In order to skip running the CodeCov job when it isn't relevant, a new job was added to the ts-packges workflow. For a PR, this job identifies all the files modified between the base branch and the tip of the PR branch, and writes to a variable which can be used to decide if subsequent jobs should run. Github Actions provides an easy method for achieving this at the level of a workflow, but not for specific jobs within a workflow. * Version Packages * chore(ci): Skip codecov on push events * feat: add workflow for running SNX test suite * go: implement gasprices package The `gasprices` package implements the logic that updates L2 gasprices on the Optimistic Ethereum Network. Co-authored-by: Karl Floersch <karl@karlfloersch.com> * gas-oracle: implement and test This commit adds the `gas-oracle` which is an offchain entity that sends transactions to L2 to update the gas price. It must be configured with a private key as the `OVM_GasPriceOracle` is owned. The `gas-oracle` is added to the changesets setup. Tests are included as well as CI. Dockerizing will happen in a follow up PR. * gas-oracle: ci + docker build/publish Adds a dockerfile for the `gas-oracle` as well as adding it as a service in the `docker-compose.yaml`. It is not enabled by default due to memory issues in CI already happening occasionally where the integration tests are oom killed. The `gas-oracle` is configured with a key that owns the `OVM_GasPriceOracle`. This PR adds the `gas-oracle` to the Github Actions workflow that is responsible for publishing the docker images. * Add replica (#169) * fix: update erc20 deposits (#166) * fix: update erc20 deposits * fix: auto default token Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * resolve merge conflicts * Update docker-compose.yml * Update docker-compose.yml * [pull] develop from ethereum-optimism:develop (#164) * contracts: add set-l2-gasprice task This task allows a user to update the L2 gas price using hardhat. An example of doing so would be: ```bash $ export CONTRACTS_DEPLOYER_KEY=0x.. $ CONTRACTS_RPC_URL=https://kovan.optimism.io npx hardhat set-l2-gasprice \ --l2-gas-price 1 ``` This hardcodes the predeploy address of the `OVM_GasPriceOracle` smart contract and the Owner must be used to do the updating, otherwise the transaction will revert. * Add op_exporter for sequencer metrics and health endoint Added metric for sequencer health Added Dockerfile for op_exporter; Fixed Dockerfile path * feat[integration-tests]: make tests work for prod networks * chore: add changeset * Increase client_body_buffer_size for rpc-proxy Added client_max_body_size to rpc-proxy config * l2geth: use `hexutil.Big` to prevent overflows The `RollupClient` decodes the JSON from the DTL as a uint64, this updates it to be a `big.Int` Includes a test for the value field that ensures it does not overflow * ci(contracts): only run codecov if contracts package is modified In order to skip running the CodeCov job when it isn't relevant, a new job was added to the ts-packges workflow. For a PR, this job identifies all the files modified between the base branch and the tip of the PR branch, and writes to a variable which can be used to decide if subsequent jobs should run. Github Actions provides an easy method for achieving this at the level of a workflow, but not for specific jobs within a workflow. * Version Packages * chore(ci): Skip codecov on push events * feat: add workflow for running SNX test suite * go: implement gasprices package The `gasprices` package implements the logic that updates L2 gasprices on the Optimistic Ethereum Network. Co-authored-by: Karl Floersch <karl@karlfloersch.com> * gas-oracle: implement and test This commit adds the `gas-oracle` which is an offchain entity that sends transactions to L2 to update the gas price. It must be configured with a private key as the `OVM_GasPriceOracle` is owned. The `gas-oracle` is added to the changesets setup. Tests are included as well as CI. Dockerizing will happen in a follow up PR. * gas-oracle: ci + docker build/publish Adds a dockerfile for the `gas-oracle` as well as adding it as a service in the `docker-compose.yaml`. It is not enabled by default due to memory issues in CI already happening occasionally where the integration tests are oom killed. The `gas-oracle` is configured with a key that owns the `OVM_GasPriceOracle`. This PR adds the `gas-oracle` to the Github Actions workflow that is responsible for publishing the docker images. Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Ben Wilson <bwilson@optimism.io> Co-authored-by: Kelvin Fichter <kelvin@optimism.io> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: Ben Wilson <82120899+optimisticben@users.noreply.github.com> Co-authored-by: Kevin Ho <kevinjho1996@gmail.com> Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: Maurelian <maurelian@protonmail.ch> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Karl Floersch <karl@karlfloersch.com> * Update docker-compose.yml * adding l1-l2 test ecs scheduled task that does verify communication between L1 and L2 and L2 to L1 (#167) Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> * Update docker-compose.yml * daily update (#170) * contracts: add set-l2-gasprice task This task allows a user to update the L2 gas price using hardhat. An example of doing so would be: ```bash $ export CONTRACTS_DEPLOYER_KEY=0x.. $ CONTRACTS_RPC_URL=https://…

tynes requested review from ben-chain, karlfloersch, maurelian and smartcontracts as code owners May 13, 2021 21:34

tynes requested a review from elenadimitrova May 13, 2021 21:44

smartcontracts previously approved these changes May 13, 2021

View reviewed changes

elenadimitrova suggested changes May 14, 2021

View reviewed changes

elenadimitrova approved these changes May 17, 2021

View reviewed changes

tynes requested a review from annieke as a May 17, 2021 17:23

github-actions bot added A-contracts A-ops Area: ops labels May 17, 2021

tynes force-pushed the feat/bump-gaslimit-10-mil branch from 0187753 to f045359 Compare May 17, 2021 17:25

smartcontracts force-pushed the v0.4.0-rc branch from 5198312 to 32610cf Compare May 17, 2021 17:36

tynes requested a review from K-Ho as a code owner May 17, 2021 17:36

smartcontracts force-pushed the v0.4.0-rc branch from 32610cf to 3f3d9f0 Compare May 17, 2021 17:40

tynes force-pushed the feat/bump-gaslimit-10-mil branch from f045359 to aa58f6a Compare May 17, 2021 17:45

tynes added 4 commits May 17, 2021 10:45

optimism: bump gaslimit to 10million

0e006c7

chore: add changeset

74f4094

optimism: bump max gaslimit to 10 mil

4b7a662

chore: add changeset

aa58f6a

gakonst added 2 commits May 19, 2021 10:35

chore: remove unnecessary changeset

b906b8f

chore: remove unnecessary changeset

51e92cc

maurelian approved these changes May 19, 2021

View reviewed changes

gakonst merged commit 02c88ad into regenesis/0.4.0 May 19, 2021

gakonst deleted the feat/bump-gaslimit-10-mil branch May 19, 2021 17:00

gakonst mentioned this pull request May 20, 2021

fix: configure max gas limit to 11m #928

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

optimism: bump gaslimit to 10 million #870 #871

optimism: bump gaslimit to 10 million #870 #871

tynes commented May 13, 2021

changeset-bot bot commented May 13, 2021 •

edited

Loading

smartcontracts commented May 13, 2021

tynes commented May 13, 2021

tynes commented May 13, 2021

elenadimitrova May 14, 2021

tynes May 17, 2021

elenadimitrova May 14, 2021

tynes May 17, 2021

tynes commented May 17, 2021

platocrat commented May 17, 2021

maurelian commented May 18, 2021

tynes commented May 18, 2021

snario commented May 19, 2021

optimism: bump gaslimit to 10 million #870 #871

optimism: bump gaslimit to 10 million #870 #871

Conversation

tynes commented May 13, 2021

changeset-bot bot commented May 13, 2021 • edited Loading

⚠️ No Changeset found

smartcontracts commented May 13, 2021

tynes commented May 13, 2021

tynes commented May 13, 2021

elenadimitrova May 14, 2021

Choose a reason for hiding this comment

tynes May 17, 2021

Choose a reason for hiding this comment

elenadimitrova May 14, 2021

Choose a reason for hiding this comment

tynes May 17, 2021

Choose a reason for hiding this comment

tynes commented May 17, 2021

platocrat commented May 17, 2021

maurelian commented May 18, 2021

tynes commented May 18, 2021

snario commented May 19, 2021

changeset-bot bot commented May 13, 2021 •

edited

Loading