Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update README #8731

Merged
merged 7 commits into from
Mar 1, 2024
Merged

doc: update README #8731

merged 7 commits into from
Mar 1, 2024

Conversation

mds1
Copy link
Contributor

@mds1 mds1 commented Dec 21, 2023

Updates the development and release process, adds missing entries to the directory structure, fixes links, and adds a table of contents. Leaving as a draft as we should not merge until we actually have the initial smart contract releases

@mds1 mds1 requested review from tynes and trianglesphere December 21, 2023 21:18
Copy link
Contributor

coderabbitai bot commented Dec 21, 2023

Walkthrough

Walkthrough

The Optimism project underwent significant improvements, notably in the README.md file. Changes include adding a table of contents, refining documentation links and descriptions, updating the "Good First Issues" link, restructuring directories, providing insights on production releases and the development/release process. Additionally, a specific functional change was made in the packages/contracts-bedrock/lib/lib-keccak subproject by updating the commit hash.

Changes

File Path Change Summary
README.md Added table of contents; updated documentation links and descriptions; changed "Good First Issues" link; rearranged and added new directories in structure section; included details on production releases and the development/release process.
packages/contracts-bedrock/lib/lib-keccak Updated subproject commit hash from 0115edbbc60b5f702392caafc3a142061e6142fa to 59dcbd7b0de1fd00b44f4ce41e99a7f990564d11.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@mds1 mds1 marked this pull request as draft December 21, 2023 21:22
Copy link
Contributor

github-actions bot commented Jan 5, 2024

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jan 5, 2024
@mds1 mds1 removed the Stale label Jan 8, 2024
Updates the development and release process, adds missing entries to
the directory structure, fixes links, and adds a table of contents.
@mds1 mds1 force-pushed the docs/update-README branch from 7781900 to 60f8eec Compare January 8, 2024 17:33
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

semgrep-app bot commented Jan 10, 2024

Semgrep found 10 sol-style-return-arg-fmt findings:

Named return arguments to functions must be appended with an underscore (_)

Ignore this finding from sol-style-return-arg-fmt.

Semgrep found 39 sol-style-notice-over-dev-natspec findings:

Prefer @notice over @dev in natspec comments

Ignore this finding from sol-style-notice-over-dev-natspec.

Semgrep found 3 todos_require_linear findings:

  • op-service/eth/blob.go: L85, L75
  • op-node/rollup/derive/engine_queue.go: L692

Please create a GitHub ticket for this TODO.

Ignore this finding from todos_require_linear.

tynes added a commit that referenced this pull request Jan 11, 2024
Removes the patch-package dep as well as the `patches` directory
from the repo.

Closes ethereum-optimism/client-pod#455

Based on conversation in #8731 (comment)
github-merge-queue bot pushed a commit that referenced this pull request Jan 16, 2024
* deps: remove patch-package

Removes the patch-package dep as well as the `patches` directory
from the repo.

Closes ethereum-optimism/client-pod#455

Based on conversation in #8731 (comment)

* scripts: remove postinstall
dshiell pushed a commit to polymerdao/optimism-dev that referenced this pull request Jan 22, 2024
* deps: remove patch-package

Removes the patch-package dep as well as the `patches` directory
from the repo.

Closes https://github.com/ethereum-optimism/client-pod/issues/455

Based on conversation in ethereum-optimism#8731 (comment)

* scripts: remove postinstall
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jan 26, 2024
@mds1
Copy link
Contributor Author

mds1 commented Jan 30, 2024

I think there are some useful changes in here, but still waiting on the v1.0.0 contracts release. @maurelian Would you be able to get this PR over the line since it seems you're owning the setup of the contracts release/tag process?

@maurelian
Copy link
Contributor

I think there are some useful changes in here, but still waiting on the v1.0.0 contracts release. @maurelian Would you be able to get this PR over the line since it seems you're owning the setup of the contracts release/tag process?

Yes.

@maurelian maurelian self-assigned this Jan 31, 2024
@github-actions github-actions bot removed the Stale label Jan 31, 2024
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Feb 14, 2024
@mds1 mds1 removed the Stale label Feb 14, 2024
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Feb 29, 2024
@mds1 mds1 removed the Stale label Feb 29, 2024
@mds1 mds1 marked this pull request as ready for review February 29, 2024 03:15
@mds1
Copy link
Contributor Author

mds1 commented Feb 29, 2024

Marking this as ready for review now that we have the retroactive contract releases:

Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small typographic comments, but contents lgtm

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@mds1 mds1 requested a review from a team as a code owner February 29, 2024 20:50
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.42%. Comparing base (34779f7) to head (a0f454c).
Report is 8 commits behind head on develop.

❗ Current head a0f454c differs from pull request most recent head 34acaf2. Consider uploading reports for the commit 34acaf2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #8731       +/-   ##
============================================
- Coverage    28.73%   16.42%   -12.32%     
============================================
  Files          162      120       -42     
  Lines         7144     5217     -1927     
  Branches      1309     1157      -152     
============================================
- Hits          2053      857     -1196     
+ Misses        4985     4285      -700     
+ Partials       106       75       -31     
Flag Coverage Δ
cannon-go-tests ?
chain-mon-tests 27.14% <ø> (ø)
common-ts-tests ?
contracts-bedrock-tests 0.62% <ø> (ø)
contracts-ts-tests 12.25% <ø> (ø)
core-utils-tests ?
sdk-next-tests 41.94% <ø> (ø)
sdk-tests 41.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 42 files with indirect coverage changes

@mds1 mds1 force-pushed the docs/update-README branch from a0f454c to 34acaf2 Compare March 1, 2024 16:25
@trianglesphere trianglesphere requested a review from tynes March 1, 2024 17:44
@mds1 mds1 added this pull request to the merge queue Mar 1, 2024
Merged via the queue into develop with commit c04421a Mar 1, 2024
68 checks passed
@mds1 mds1 deleted the docs/update-README branch March 1, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants