-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update README #8731
doc: update README #8731
Conversation
WalkthroughWalkthroughThe Optimism project underwent significant improvements, notably in the README.md file. Changes include adding a table of contents, refining documentation links and descriptions, updating the "Good First Issues" link, restructuring directories, providing insights on production releases and the development/release process. Additionally, a specific functional change was made in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Updates the development and release process, adds missing entries to the directory structure, fixes links, and adds a table of contents.
7781900
to
60f8eec
Compare
Semgrep found 10
Named return arguments to functions must be appended with an underscore ( Semgrep found 39
Prefer Semgrep found 3 Please create a GitHub ticket for this TODO. Ignore this finding from todos_require_linear. |
Removes the patch-package dep as well as the `patches` directory from the repo. Closes ethereum-optimism/client-pod#455 Based on conversation in #8731 (comment)
* deps: remove patch-package Removes the patch-package dep as well as the `patches` directory from the repo. Closes ethereum-optimism/client-pod#455 Based on conversation in #8731 (comment) * scripts: remove postinstall
* deps: remove patch-package Removes the patch-package dep as well as the `patches` directory from the repo. Closes https://github.com/ethereum-optimism/client-pod/issues/455 Based on conversation in ethereum-optimism#8731 (comment) * scripts: remove postinstall
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
I think there are some useful changes in here, but still waiting on the v1.0.0 contracts release. @maurelian Would you be able to get this PR over the line since it seems you're owning the setup of the contracts release/tag process? |
Yes. |
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Marking this as ready for review now that we have the retroactive contract releases: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small typographic comments, but contents lgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8731 +/- ##
============================================
- Coverage 28.73% 16.42% -12.32%
============================================
Files 162 120 -42
Lines 7144 5217 -1927
Branches 1309 1157 -152
============================================
- Hits 2053 857 -1196
+ Misses 4985 4285 -700
+ Partials 106 75 -31
Flags with carried forward coverage won't be shown. Click here to find out more. |
Updates the development and release process, adds missing entries to the directory structure, fixes links, and adds a table of contents. Leaving as a draft as we should not merge until we actually have the initial smart contract releases