Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pivotal Sepolia #674

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

stevenkhong
Copy link

@stevenkhong stevenkhong commented Nov 7, 2024

Adding a New Chain

This PR adds Pivotal Sepolia to the registry.

Checklist

  • I have declared the chain at the appropriate Superchain Level.
  • I have run just validate <chain-id> locally to ensure all local validation checks pass.
  • I have run just codegen to ensure that the chainlist and other generated files are up-to-date and include my chain.

@stevenkhong stevenkhong requested a review from a team as a code owner November 7, 2024 04:09
genesis_creation_commit = "f8143c8cbc4cc0c83922c53f17a1e47280673485"
node_version = "18.12.1"
monorepo_build_command = "pnpm"
genesis_creation_command = "opnode2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to get this to pass locally by changing this value opnode2 --> forge1. Please push that change and we should see the ci test suite pass as a result

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for pointing out the issue. Seems to pass validation on local:

just validate 16481:
Screenshot 2024-12-04 at 1 28 57 PM

just validate-genesis-allocs 16481:
Screenshot 2024-12-04 at 1 29 09 PM

@Wazabie Wazabie self-assigned this Dec 3, 2024
@Wazabie Wazabie added F-do-not-merge Flag: Do Not Merge M-new-chain-request Meta: New Chain Request labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-do-not-merge Flag: Do Not Merge M-new-chain-request Meta: New Chain Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants