Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(validation/standard): restructure config files #761

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

edobry
Copy link
Contributor

@edobry edobry commented Dec 10, 2024

Description

This PR restructures the validation/standard/*.toml files to improve DevX. It also adds standard configs for the sepolia-dev-0 chain.

@geoknee
Copy link
Collaborator

geoknee commented Dec 10, 2024

I appreciate the thrust of this, but given these files are referenced in the standard rollup charter we may not be able to change them easily.

@edobry
Copy link
Contributor Author

edobry commented Dec 10, 2024

Cross-linking relevant question

#718 (comment)

@edobry
Copy link
Contributor Author

edobry commented Dec 10, 2024

@geoknee good to know; do we have any set process or guidelines for how to make changes to these files, if this needs governance approval or anything of the sort? Looks like we link directly to the file in the charter, this seems fragile, wondering if there's an opportunity for some sort of disintermediation (linking to the SCR site instead?)

cc @bitwiseguy @tessr

@edobry edobry force-pushed the edobry/standard-config-restructure branch from 4ffe4de to b07703b Compare December 10, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants