Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dispute game contracts for oplabs-devnet-0 and op-sepolia #789

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Inphi
Copy link
Contributor

@Inphi Inphi commented Dec 13, 2024

Updates the dispute game contracts for the oplabs sepolia devnet and op-sepolia.

This also adds PermissionedDelayedWETH, and MIPS64 to the chain addresses.

Context for MIPS64 Superchain Upgrades

The CANNON and PERMISSIONED_CANNON game implementations will be replaced with new implementations that use the MIPS64 VM. MIPS64 is effectively the old MIPS VM. The MIPS64.sol contract semver precedes the MIPS.sol semver and so a new MIPS64 config value is added to prevent the backwards semver check from failing in CI.
This is awkward as it's no longer clear which VM implementation is used by a chain from looking at the superchain-registry. This awkwardness is temporary as once the superchain upgrades to MIPS64, we can remove the MIPS64 config field by replacing the MIPS config value with a deployed MIPS64 contract address.

The op-program prestate releases are agnostic to type of VM used to generate the prestate. That is, given a absolute prestate hash in the release registry, it's either a MIPS or MIPS64 generated prestate but not both. This creates a problem during FP validation checks as the op-sepolia MIPS64 upgrade was based on the op-program/v1.4.0-rc.3 release. And the prestate of that release already exists in the registry as a MIPS prestate.
To workaround this issue, FP validation is tweaked to avoid checking the absolute prestate on testnets that use MIPS64. This workaround can be removed once OPCM manages upgrades.

@Inphi Inphi force-pushed the inphi/sep-dev-0 branch 2 times, most recently from 4bb2067 to 49ce28c Compare December 18, 2024 15:21
@Inphi Inphi changed the title Update dispute game contracts for oplabs-devnet-0 Update dispute game contracts for oplabs-devnet-0 and op-sepolia Dec 18, 2024
@Inphi Inphi force-pushed the inphi/sep-dev-0 branch 2 times, most recently from 0b14019 to e2de554 Compare December 18, 2024 15:49
@Inphi Inphi marked this pull request as ready for review December 18, 2024 16:06
@Inphi Inphi requested a review from a team as a code owner December 18, 2024 16:06
Copy link
Member

@sebastianst sebastianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe ethereum-optimism/superchain-ops#421 will change some addresses for op-sepolia again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants