Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax in #681 by referencing #831 #1095

Merged
merged 3 commits into from
Oct 15, 2018
Merged

Conversation

ligi
Copy link
Member

@ligi ligi commented May 18, 2018

as correctly brought up by @maciejhirsz here (#681 (comment)) and just discussed with @nagydani - referencing #831 in the syntax part of #681

@axic
Copy link
Member

axic commented Sep 20, 2018

@nagydani can you approve this?

@axic
Copy link
Member

axic commented Sep 20, 2018

@ligi btw, the motivation section has

This specification supersedes ERC #67

I think it would make sense including a replaces: 67 header.

@ligi
Copy link
Member Author

ligi commented Sep 24, 2018

@axic thanks - good idea - I think a replaces: header would make sense here. Will open a PR for this after we merged this one. I will see @nagydani most likely this week so I think we can get this merged ,-)

Copy link
Contributor

@nagydani nagydani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfectly reasonable.

@nagydani
Copy link
Contributor

@ligi btw, the motivation section has

This specification supersedes ERC #67

I think it would make sense including a replaces: 67 header.

We did have that header and it was removed because EIP 67 has, in fact, never been accepted.

@Arachnid Arachnid merged commit 30385fe into ethereum:master Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants