-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-1344: Add chain id opcode #1344
Conversation
type: Standards Track | ||
status: Draft | ||
created: 2018-08-22 | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a discussions-to URL.
@Arachnid Hey, what do I need to do to get this merged? :D |
Wanted to ping this EIP. I think inclusion of this opcode for Istanbul may be very valuable for EIP-712 (#712) applications (being able to programmatically query chain ID for constructing the domain separator) |
Would love that too, still not sure what the best way is to push this forward :/ |
Have to go through the process, and place it on the Istanbul roadmap before May 17th. Would love to help you out in making this happen, if another similar EIP hasn't already been planned. |
@rmeissner picking up the conversation on EthMagicians, probably needs some additional detail as it's missing the "Rationale" and "Backwards Compatibility" sections. Not sure if we should write Test Cases, but the Implementation is easier enough it is probably okay leaving that empty. |
* Add chain id opcode * Update EIP number * Update file name * Add discussion-to
PR based on the issue #901
Discussions at https://ethereum-magicians.org/t/add-chain-id-opcode-for-replay-protection-when-handling-signed-messages-in-contracts/1131