Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-1344: Add chain id opcode #1344

Merged
merged 7 commits into from
Apr 1, 2019
Merged

EIP-1344: Add chain id opcode #1344

merged 7 commits into from
Apr 1, 2019

Conversation

rmeissner
Copy link
Contributor

@rmeissner rmeissner commented Aug 22, 2018

type: Standards Track
status: Draft
created: 2018-08-22
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a discussions-to URL.

@rmeissner rmeissner changed the title Add chain id opcode EIP-1344: Add chain id opcode Aug 28, 2018
@rmeissner
Copy link
Contributor Author

@Arachnid Hey, what do I need to do to get this merged? :D

@fubuloubu
Copy link
Contributor

fubuloubu commented Apr 1, 2019

Wanted to ping this EIP. I think inclusion of this opcode for Istanbul may be very valuable for EIP-712 (#712) applications (being able to programmatically query chain ID for constructing the domain separator)

@rmeissner
Copy link
Contributor Author

Would love that too, still not sure what the best way is to push this forward :/

@fubuloubu
Copy link
Contributor

Have to go through the process, and place it on the Istanbul roadmap before May 17th.

Would love to help you out in making this happen, if another similar EIP hasn't already been planned.

@Arachnid Arachnid merged commit d053eb6 into ethereum:master Apr 1, 2019
@fubuloubu
Copy link
Contributor

@rmeissner picking up the conversation on EthMagicians, probably needs some additional detail as it's missing the "Rationale" and "Backwards Compatibility" sections. Not sure if we should write Test Cases, but the Implementation is easier enough it is probably okay leaving that empty.

ilanolkies pushed a commit to ilanolkies/EIPs that referenced this pull request Nov 12, 2019
* Add chain id opcode

* Update EIP number

* Update file name

* Add discussion-to
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants