ERC902: Modernize formatting & specify codes as ERC1066 #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Modernize formatting * Specify return codes as following ERC1066 * Use author GitHub usernames instead of emails * Update implementation repo * Set discussions-to
|
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
|
|
Very sorry to bother you, but this one needs some manual intervention when you get a second @Arachnid
|
|
@Souptacular You're the best; thanks for the merge 🎉🎉🎉
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERC1066discussions-toI'm going to out on a limb and guess that this won't automege because we used company email addresses rather than usernames. All of the authors have since left that company, so this PR fixes that. As some proof that I am in fact the author of ERC902, here is the original PR: #902