Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create eip-1538.md #1879

Merged
merged 2 commits into from
Mar 28, 2019
Merged

Create eip-1538.md #1879

merged 2 commits into from
Mar 28, 2019

Conversation

mudgen
Copy link
Contributor

@mudgen mudgen commented Mar 27, 2019

There are sufficient people using ERC 1538 to warrant the creation of the EIP.

Discussion is here: #1538

The EIP will be linked to by ERC-1155.

Copy link
Contributor

@nicksavers nicksavers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the link to EIP-1155 a requirement for this proposal?
If so, that would warrant a requires:-field

EIPS/eip-1538.md Outdated
status: Draft
type: Standards Track
category: ERC
created: 31 October 2018
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use the standard date format used in other EIPs?

@nicksavers
Copy link
Contributor

Also this PR seems an almost duplication of #1567
Can one of these be closed?

@mudgen
Copy link
Contributor Author

mudgen commented Mar 27, 2019

@nicksavers I updated it to use the standard date format.

I closed #1567.

EIP 1538 does not link to EIP 1155. It is the other way around, EIP 1155 links to ERC1538, and will instead link to EIP 1538 when EIP 1538 is published.

@nicksavers @fulldecent thanks for your help moving this along.

@nicksavers nicksavers merged commit d91d055 into ethereum:master Mar 28, 2019
ilanolkies pushed a commit to ilanolkies/EIPs that referenced this pull request Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants