Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Rejected EIPs" into EIP-233 (and EIP-1679) #2081

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Add "Rejected EIPs" into EIP-233 (and EIP-1679) #2081

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8057010
Add "Rejected EIPs" into EIP-233 (and EIP-1679)
axic May 1, 2019
52ca09c
Merge remote-tracking branch 'ethereum/master' into eip233
axic Jun 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions EIPS/eip-1679.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ This meta-EIP specifies the changes included in the Ethereum hardfork named Ista

- TBD

### Rejected EIPs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does 1559 make this list? It sound more like a default "no". Then a flat out rejection? Should there be a place for things that have been tabled and are unlikely to make it without considerable work, and things that have been rejected and aren't going to be considered?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is it better to make a note of this similar to how Progpow has a sub-note?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well this is just adding the new templates and not documenting any decisions.

- TBD

### Proposed EIPs

- [EIP-615](https://eips.ethereum.org/EIPS/eip-615): Subroutines and Static Jumps for the EVM
Expand Down
9 changes: 8 additions & 1 deletion EIPS/eip-233.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@ Once a timeline with key dates is agreed upon for other crucial dates. The basic

Anyone that wishes to propose a Core EIP for the hard fork should make a PR against the Meta EIP representing the hard fork. The EIP must be published as at least `Draft`. It enters the _Proposed EIPs_ section, along with at least one person who is a point of contact for wanting to include the EIP.

Once the EIP has been accepted by Core Devs, the EIP should be moved to the _Accepted EIPs_ section. If the EIP has major client implementations and no security issues by the timeline date, it is scheduled for inclusion.
EIPs can move states by discussion done on the "[All Core Devs Meetings](https://github.com/ethereum/pm/)":
- If accepted for a hard fork, the EIP should be moved to the _Accepted EIPs_ section. If the EIP has major client implementations and no security issues by the timeline date, it is scheduled for inclusion.
- If rejected from a hard fork, the EIP should be moved to the _Rejected EIPs_ section.
- Once the EIPs in the _Accepted EIPs_ section have successfully launched on a testnet roll out, they are moved to the _Included EIPs_ section.

---

Expand Down Expand Up @@ -80,6 +83,10 @@ This meta-EIP specifies the changes included in the Ethereum hardfork named Ista

- TBD

### Rejected EIPs

- TBD

### Proposed EIPs

- TBD
Expand Down