-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-1193: Add close method #2261
Conversation
Already have a deployed implementation for this with WalletConnect web3-provider package |
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
|
I think the CI failing here is unrelated to the actual change being made. Rerunning it should fix it, but I can't do that. Can you, Pedro? Anyway, I think this PR should be merged. As I mentioned in this EIP'ss issue, this was discussed during Devcon V and we agreed on implementing this change. |
I believe the original vision from @frozeman was to keep this provider as a pure simple clean wrapper over the Ethereum JSON-RPC API. It was not intended to have any methods, other than This is why Any messages from the JSON-RPC API are to be emitted over key Emitting: @frozeman urged that should be the maximum extent for this API, along with suggesting that it would be of great accessibility to have this wrapper available on I only meant to add notifications cc #2319 |
In the case of this PR, I would suggest proposing it as new methods to the JSON-RPC API such as I think other useful ones based on prior discussion could include |
Replaced by #2586 |
Add the close method to the Ethereum provider API to allow Dapps to close the connection.
The motivation behind this change is to allow Dapps to switch between providers and closing the connection with first one before opening the connection with the second one.
Example: User enables connection with injected provider but then wants to disconnect to connect to another provider like WalletConnect, Portis or Fortmatic