-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resurrect EIP-1328 #4416
Merged
Merged
Resurrect EIP-1328 #4416
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c918220
Resurrect EIP-1328
ligi 498904f
Update to current EIP-1
ligi a5e188c
Remove the specific use case
ligi 458faf7
Update eip-1328.md
pedrouid 72e45a7
Update eip-1328.md
pedrouid b71e351
Update EIPS/eip-1328.md
ligi 6433ca0
Update EIPS/eip-1328.md
ligi 3d25ca3
Merge pull request #2 from pedrouid/patch-9
ligi 0bb6cf8
Update EIPS/eip-1328.md
ligi 109f8c4
Update EIPS/eip-1328.md
ligi 9a41f1a
Merge pull request #3 from pedrouid/patch-10
ligi 844fd5f
Update eip-1328.md
pedrouid 9306edb
Merge pull request #4 from pedrouid/patch-11
ligi 0e728c3
Apply suggestions by @MicahZoltu
ligi 7980502
Apply my suggestions to the PR
SamWilsn 9559a47
Merge pull request #5 from SamWilsn/resurrect_resurrect_1328
ligi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pedrouid do we perhaps want to remove "This URI can then be shown either as a QR code or as a link." - think it adds no value and restricts us without a need. e.g. how does the "copy" fall in place there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this is already addressed when "link" is mentioned since it's a common pattern to include
copy to clipboard
for website links as well