Described transactions #4430

ricmoo · 2021-11-07T04:55:51Z

Adding an EIP for described transactions, splitting EIP-3224 into multiple EIPs as discussed on the discussions to.

(the EIP number in the draft will be updated once this PR has been assigned a number and this PR updated)

… review.

eth-bot · 2021-11-07T04:56:30Z

All tests passed; auto-merging...

(pass) eip-4430.md

classification
`updateEIP`

passed!

MicahZoltu

Since this is an ERC I'll leave it to others to review, but figured I would give some initial feedback to limit the time this EIP is stuck blocked.

EIPS/eip-4430.md

axic · 2021-11-11T12:21:09Z

Why did you wanted to revive 3224 if this is the split out version?

Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>

ricmoo · 2021-11-12T05:02:38Z

@axic This (EIP-4430) is the described transactions split out from EIP-3224 , which is now just the described messages. Once these are through, I'll be adding two new EIPs for the respective JSON-RPC methods.

EIPS/eip-4430.md

…described-transactions

ricmoo · 2021-12-06T01:31:36Z

Is there still anything outstanding on this EIP that I've missed?

ricmoo · 2021-12-27T22:17:51Z

@axic @MicahZoltu Any remaining issues regarding this?

I'm working on an article to help articulate this EIP and EIP-3224, but waiting for this to be posted to eips.ethereum.org.

Thanks!

MicahZoltu · 2021-12-28T02:31:38Z

The remaining issue is lack of EIP editors. 😖 @lightclient and @axic are the only two people actively reviewing ERCs, and sometimes they both disappear for weeks on end. 😢

This is the problem with volunteer work...

MicahZoltu · 2021-12-28T02:32:13Z

Maybe @wschwab wants to take a stab at reviewing this?

ricmoo · 2022-01-21T21:44:18Z

Pinging @wschwab

wschwab · 2022-01-23T18:52:48Z

sorry, I'd missed this - will take a look (prolly not today, but within the next couple/few)

ricmoo · 2022-01-23T20:33:15Z

@wschwab Thanks; if you would like access to my draft article which aims to better explain this EIP, please DM me on twitter or send me an e-mail to me@ricmoo.com. :)

wschwab

I've left some comments and thoughts - it looks like there are a couple of things that need cleaning up, but this is otherwise pretty much there!

Some of the comments may stem from my own misunderstanding - I do want to ping you for the article, but figured it would be better if I got things rolling in the meantime.

wschwab · 2022-01-24T16:59:20Z

EIPS/eip-4430.md

+are generated simultaneously by evaluating the method on a contract:
+
+```solidity
+function eipXXXDescribe(bytes inputs, bytes32 reserved) view returns (string description, bytes execcode)


Suggested change

function eipXXXDescribe(bytes inputs, bytes32 reserved) view returns (string description, bytes execcode)

function eip4430Describe(bytes inputs, bytes32 reserved) view returns (string description, bytes execcode)

Also, I don't fully understand the spec. Is there a function actually named eip4430Describe that needs to be present in the contract in order to leverage this EIP? I suspect not since there could only be one per contract (or per argument set?) whereas the contract may contain many, if so, what is the specification for the name (and arguments) of a EIP-4430 compliant function?

For now I want to avoid giving it a real name, since people might start using it before its ready and I want to avoid a signTypeData_v4 situation.

wschwab · 2022-01-24T17:28:19Z

EIPS/eip-4430.md

+- Homoglyphs attacks
+- Right-to-left mark may affect rendering
+- Many other things, deplnding on your environment
+


I'd recommend reiterating the concern the point made above that contracts can implement this maliciously (purposely giving an inaccurate description)

wschwab · 2022-01-24T17:38:50Z

EIPS/eip-4430.md

+@TODO (consider adding it as one or more files in `../assets/eip-####/`)
+
+I will add examples in Solidity and JavaScript.


Reference Implementation is optional, so this could be merged without it, but I do feel like it would be very useful for this EIP, and also figure you didn't want to leave this section quite like this - if you'd like you can still leave the latter line, but the @TODO should be removed imho

wschwab · 2022-01-24T17:44:17Z

EIPS/eip-4430.md

+title: Described Transactions
+description: A technique for contract authors to enable wallets to provide a human-readable description of the effect of of a transaction with a given contract.
+author: Richard Moore (@ricmoo), Nick Johnson (@arachnid)
+discussions-to: https://github.com/ethereum/EIPs/issues/4431


the usual recommendation is to link to a thread in the Ethereum Magicians Discourse

Should I change it? There is already some (but not much discussion) on the current link.

Yes, all new EIPs should be using Ethereum Magicians. Since this is a new EIP, it should as well. We currently only make exceptions for existing EIPs (merged as draft before we moved to Ethereum Magicians) that are receiving updates or moving through status changes.

ricmoo · 2022-03-30T09:04:43Z

Is it possible to move this to draft soon-ish? I'd rather not go through the effort of un-stagnating an EIP. Once it is draft, it is much easier to make changes to.

ricmoo · 2022-03-31T10:58:48Z

I've made the requested change and will link the old discussions to the new.

MicahZoltu · 2022-03-31T15:34:01Z

CI failures:

eip-4430.md: description exceeds max length of 140 characters

./EIPS/eip-4430.md:15: funcions ==> functions

EIPS/eip-4430.md

Co-authored-by: Micah Zoltu <micah@zoltu.net>

MicahZoltu · 2022-04-01T13:31:52Z

Oh, right. I don't have permission to approve ERCs. You'll have to wait for one of the ERC editors.

lightclient

LGTM

* Updated EIP-2098 compact representation with suggestions and moved to review. * Added draft for described transactions. * Updated EIP-4430 with its EIP number and discussions-to. * Updated EIP-4430 filename. * Fixed per request. * Update EIPS/eip-4430.md Co-authored-by: Alex Beregszaszi <alex@rtfs.hu> * Fixed typo. * Updated as requested. * Updated as per suggestion. * Revert file modified in wrong branch. * Updated link to etheruem magicians. * Update EIPS/eip-4430.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Updated EIP-4430 with shorter description. Co-authored-by: Alex Beregszaszi <alex@rtfs.hu> Co-authored-by: Micah Zoltu <micah@zoltu.net>

ricmoo added 4 commits June 22, 2021 16:07

Updated EIP-2098 compact representation with suggestions and moved to…

0eee426

… review.

Merge branch 'ethereum:master' into master

89d7bda

Merge branch 'ethereum:master' into master

b85b59c

Added draft for described transactions.

6225b92

ricmoo added 2 commits November 7, 2021 00:58

Updated EIP-4430 with its EIP number and discussions-to.

5b5f9b9

Updated EIP-4430 filename.

347f3bb

MicahZoltu reviewed Nov 8, 2021

View reviewed changes

EIPS/eip-4430.md Outdated Show resolved Hide resolved

EIPS/eip-4430.md Show resolved Hide resolved

EIPS/eip-4430.md Outdated Show resolved Hide resolved

Fixed per request.

fa4b3cb

axic reviewed Nov 11, 2021

View reviewed changes

EIPS/eip-4430.md Outdated Show resolved Hide resolved

Update EIPS/eip-4430.md

165dde6

Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>

wuharvey reviewed Nov 13, 2021

View reviewed changes

EIPS/eip-4430.md Outdated Show resolved Hide resolved

ricmoo added 5 commits December 5, 2021 15:19

Fixed typo.

91797c7

Merge branch 'described-transactions' of github.com:ricmoo/EIPs into …

a75d55e

…described-transactions

Updated as requested.

f2f7dc2

Updated as per suggestion.

2981252

Revert file modified in wrong branch.

90659e1

alita-moore added automerge and removed automerge labels Jan 18, 2022

zmanian mentioned this pull request Jan 23, 2022

docs(adr): ADR-050 SIGN_MODE_TEXTUAL cosmos/cosmos-sdk#10701

Merged

19 tasks

wschwab reviewed Jan 24, 2022

View reviewed changes

github-actions bot added the stale label Mar 25, 2022

github-actions bot removed the stale label Mar 30, 2022

Updated link to etheruem magicians.

d34724f

eth-bot added the newEIPFile label Mar 31, 2022

MicahZoltu reviewed Mar 31, 2022

View reviewed changes

EIPS/eip-4430.md Outdated Show resolved Hide resolved

ricmoo and others added 2 commits March 31, 2022 19:56

Update EIPS/eip-4430.md

0e7bac5

Co-authored-by: Micah Zoltu <micah@zoltu.net>

Updated EIP-4430 with shorter description.

c77bde7

MicahZoltu closed this Apr 1, 2022

MicahZoltu reopened this Apr 1, 2022

lightclient approved these changes Apr 5, 2022

View reviewed changes

eth-bot added updateEIP and removed newEIPFile labels Apr 5, 2022

kodiakhq bot merged commit 904be25 into ethereum:master Apr 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Described transactions #4430

Described transactions #4430

ricmoo commented Nov 7, 2021

eth-bot commented Nov 7, 2021 •

edited

Loading

MicahZoltu left a comment

axic commented Nov 11, 2021

ricmoo commented Nov 12, 2021

ricmoo commented Dec 6, 2021

ricmoo commented Dec 27, 2021

MicahZoltu commented Dec 28, 2021

MicahZoltu commented Dec 28, 2021

ricmoo commented Jan 21, 2022

wschwab commented Jan 23, 2022

ricmoo commented Jan 23, 2022

wschwab left a comment

wschwab Jan 24, 2022

wschwab Jan 24, 2022

ricmoo Mar 30, 2022

wschwab Jan 24, 2022

wschwab Jan 24, 2022

wschwab Jan 24, 2022

ricmoo Mar 30, 2022

MicahZoltu Mar 31, 2022

ricmoo commented Mar 30, 2022

ricmoo commented Mar 31, 2022

MicahZoltu commented Mar 31, 2022

MicahZoltu commented Apr 1, 2022

lightclient left a comment

	function eipXXXDescribe(bytes inputs, bytes32 reserved) view returns (string description, bytes execcode)
	function eip4430Describe(bytes inputs, bytes32 reserved) view returns (string description, bytes execcode)

		@TODO (consider adding it as one or more files in `../assets/eip-####/`)

		I will add examples in Solidity and JavaScript.

Described transactions #4430

Described transactions #4430

Conversation

ricmoo commented Nov 7, 2021

eth-bot commented Nov 7, 2021 • edited Loading

All tests passed; auto-merging...

(pass) eip-4430.md

MicahZoltu left a comment

Choose a reason for hiding this comment

axic commented Nov 11, 2021

ricmoo commented Nov 12, 2021

ricmoo commented Dec 6, 2021

ricmoo commented Dec 27, 2021

MicahZoltu commented Dec 28, 2021

MicahZoltu commented Dec 28, 2021

ricmoo commented Jan 21, 2022

wschwab commented Jan 23, 2022

ricmoo commented Jan 23, 2022

wschwab left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ricmoo commented Mar 30, 2022

ricmoo commented Mar 31, 2022

MicahZoltu commented Mar 31, 2022

MicahZoltu commented Apr 1, 2022

lightclient left a comment

Choose a reason for hiding this comment

eth-bot commented Nov 7, 2021 •

edited

Loading