EIP-4626: Preview functions #4705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alcueca it would be helpful to rename the PR to include the EIP so anyone looking at the PRs can see which EIP this refers to. |
|
@lightclient looks like auto merge got disabled for some reason, mind helping us out here? 😅 |
|
alright nvm, i just dup'd it in #4710 instead 😅 |
PhABC
pushed a commit
to PhABC/EIPs
that referenced
this pull request
Jan 25, 2022
* preview functions * swap preview
PhABC
pushed a commit
to PhABC/EIPs
that referenced
this pull request
Jan 25, 2022
* preview functions * swap preview
eth-bot
pushed a commit
that referenced
this pull request
Jan 28, 2022
* Fix date * Automatically merged updates to draft EIP(s) 3416 (#3446) Hi, I'm a bot! This change was automatically merged because: - It only modifies existing Draft, Review, or Last Call EIP(s) - The PR was approved or written by at least one author of each modified EIP - The build is passing * Update eip-2315.md (#3760) * Update eip-2315.md * Update eip-2315.md * Update eip-4573.md (#4680) * Update eip-4573.md * formatting eqn * Update eip-4573.md * EIP-4626: Preview functions (#4705) * preview functions * swap preview * Finalize ERC-1271 Well beyond the last-call deadline. Time to cement this and make it final. Co-authored-by: hexzorro <80925920+hexzorro@users.noreply.github.com> Co-authored-by: Greg Colvin <greg@colvin.org> Co-authored-by: Alberto Cuesta Cañada <38806121+alcueca@users.noreply.github.com>
PowerStream3604
pushed a commit
to PowerStream3604/EIPs
that referenced
this pull request
May 19, 2022
* preview functions * swap preview
PowerStream3604
pushed a commit
to PowerStream3604/EIPs
that referenced
this pull request
May 19, 2022
* Fix date * Automatically merged updates to draft EIP(s) 3416 (ethereum#3446) Hi, I'm a bot! This change was automatically merged because: - It only modifies existing Draft, Review, or Last Call EIP(s) - The PR was approved or written by at least one author of each modified EIP - The build is passing * Update eip-2315.md (ethereum#3760) * Update eip-2315.md * Update eip-2315.md * Update eip-4573.md (ethereum#4680) * Update eip-4573.md * formatting eqn * Update eip-4573.md * EIP-4626: Preview functions (ethereum#4705) * preview functions * swap preview * Finalize ERC-1271 Well beyond the last-call deadline. Time to cement this and make it final. Co-authored-by: hexzorro <80925920+hexzorro@users.noreply.github.com> Co-authored-by: Greg Colvin <greg@colvin.org> Co-authored-by: Alberto Cuesta Cañada <38806121+alcueca@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After an intense internal discussion, we have decided that 4 preview functions are needed, one for each of the 4 mutable functions. Significant use cases would either not be possible or would be not compliant if using a single
exchangeRatefunction.On the other hand, to allow easier integration of the simpler use cases,
exchangeRate()has been kept as an alias forredeemPreview(10**decimals())