Update EIP-663: Replace runtime stack checks with EOF validation rules #7241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
chfast
approved these changes
Jul 14, 2023
|
✅ All reviewers have approved. |
hugo-dc
reviewed
Jul 19, 2023
EIPS/eip-663.md
Outdated
| - `SWAPN n` to fail if `stack_height < (n + 1)`. | ||
| - `DUPN n` to fail if `stack_height + 1 > 1024`. | ||
| - `DUPN n` and `SWAPN n` to fail if gas available is less than 3. | ||
| - `DUPN n` to fail validation if `stack_height < n`. |
There was a problem hiding this comment.
It's a bit confusing using variable n here.
For example, if n=0:
DUPN 0to fail validation ifstack_height < 0.
It is defined above that n is imm+1, but in the same line n looks like it should be the same value. Maybe it could be changed to something like:
For 0 <= i<= 255:
DUPN ito fail validation ifstack_height < i+1.
Where i represents the immediate.
There was a problem hiding this comment.
It was a mistake not to change the line with 0 <= n <= 255, changed now, please check.
gumb0
force-pushed
the
eip-663-validation
branch
from
e6ed148
to
5dcf553
Compare
21 tasks
axic
approved these changes
Sep 22, 2023
eth-bot
approved these changes
Sep 22, 2023
streamnft-tech
pushed a commit
to streamnft-tech/EIPs
that referenced
this pull request
Oct 27, 2023
RaphaelHardFork
pushed a commit
to RaphaelHardFork/EIPs
that referenced
this pull request
Jan 30, 2024
just-a-node
pushed a commit
to connext/EIPs
that referenced
this pull request
Feb 17, 2024
GAEAlimited
pushed a commit
to GAEAlimited/EIPs
that referenced
this pull request
Jun 19, 2024
blacksnow2
pushed a commit
to blacksnow2/EIPs
that referenced
this pull request
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.