Update EIP-2537: Remove redundant MUL precompiles #8945

chfast · 2024-10-09T13:12:49Z

This removes BLS12_G1MUL and BLS12_G2MUL precompiles because they are trivially replaceable by corresponding MSM precompiles.

This reduces the number of precompile's addresses defined in this EIP from 9 to 7. The addresses of remaining 7 precompiles are changed to be continues.

The Rationale entry describes why this change make sense. Additionally, the cost of MSM for single input (k==1) has been corrected to match the original MUL cost. The specification now suggests how this case should be implemented.
Moreover, because of the ABI compatibility between MUL and MSM all existing tests for MULs can be easily converted to tests for MSMs.

The PoC of MUL and MSM precompiles equivalence is provided in evmone PR#1042.

The adjustment of the MSM implementation for single input in evmone PR#1046.

eth-bot · 2024-10-09T13:13:15Z

✅ All reviewers have approved.

jochem-brouwer

One comment, some line got deleted which likely should not be deleted

EIPS/eip-2537.md

ralexstokes · 2024-10-09T19:39:01Z

I think we have historically preferred to not overload precompiles like this, but I'd love to hear what others think

cygnusv

EIPS/eip-2537.md

asanso · 2024-10-12T07:26:16Z

not sure as well, it's kind of matter of taste here. At this point we could even remove BLS12_G1ADD and BLS12_G2ADD because they are trivially replaceable by corresponding MSM precompiles......

chfast · 2024-12-18T14:50:52Z

not sure as well, it's kind of matter of taste here. At this point we could even remove BLS12_G1ADD and BLS12_G2ADD because they are trivially replaceable by corresponding MSM precompiles......

The ADD situation is different because: semantic (no subgroup check), ABI (no scalar input), and gas costs differ.

We could actually extend ADD to MULTI_ADD in the future upgrade in (almost) backward compatible manner.

MarekM25 · 2024-12-18T15:29:57Z

EIPS/eip-2537.md

@@ -277,10 +251,12 @@ MSMs are expected to be performed by Pippenger's algorithm (we can also say that

 To avoid non-integer arithmetic, the call cost is calculated as `(k * multiplication_cost * discount) / multiplier` where `multiplier = 1000`, `k` is a number of (scalar, point) pairs for the call, `multiplication_cost` is a corresponding single multiplication call cost for G1/G2.


We remove MUL, so we have to update this reference: "multiplication_cost"

I think the intent is that removing the precompile is separate from the gas schedule of a multiplication

my read is that multiplication_cost here would be either the G1 or G2 "base" gas cost depending on the nature of the MSM

going to go ahead and approve, we can update this EIP later if needed, but it looks good to me at the moment

ralexstokes

thanks for the update! decided to move ahead w/ this on ACDE #202

chfast · 2024-12-19T17:26:59Z

I'd like to rebase this on the merged gas cost changes and proof read it.

ralexstokes · 2024-12-19T17:28:06Z

I'd like to rebase this on the merged gas cost changes and proof read it.

ah ok, sounds good

it looks like EIP bot is not responding anyway so I think you can do this in this PR

eth-bot

All Reviewers Have Approved; Performing Automatic Merge...

This removes `BLS12_G1MUL` and `BLS12_G2MUL` precompiles because they are trivially replaceable by corresponding MSM precompiles. This reduces the number of precompile's addresses defined in this EIP from 9 to 7. The addresses of remaining 7 precompiles are changed to be continues. The Rationale entry describes why this change make sense. Additionally, the cost of MSM for single input (`k==1`) has been corrected to match the original MUL cost. The specification now suggests how this case should be implemented. Moreover, because of the ABI compatibility between MUL and MSM all existing tests for MULs can be easily converted to tests for MSMs. The PoC of MUL and MSM precompiles equivalence is provided in [evmone PR#1042](ethereum/evmone#1042).

eth-bot

All Reviewers Have Approved; Performing Automatic Merge...

Signed-off-by: garyschulte <garyschulte@gmail.com>

https://github.com/ethereum/EIPs/pull/9097/files https://github.com/ethereum/EIPs/pull/9098/files https://github.com/ethereum/EIPs/pull/9116/files Signed-off-by: garyschulte <garyschulte@gmail.com> adjust unit test gas costs, fix offset-by-one bug in the discount table Signed-off-by: garyschulte <garyschulte@gmail.com> implement bump in gas cost for bls map functions according to ethereum/EIPs@92c94cf Signed-off-by: garyschulte <garyschulte@gmail.com> using Pawel's suggested discount table from ethereum/EIPs#9116 (comment) Signed-off-by: garyschulte <garyschulte@gmail.com> use bls pairing costs from https://github.com/ethereum/EIPs/pull/9098/files Signed-off-by: garyschulte <garyschulte@gmail.com> remove MUL per ethereum/EIPs#8945 Signed-off-by: garyschulte <garyschulte@gmail.com> fix g1 msm max discount case, add g2 msm max discount case Signed-off-by: garyschulte <garyschulte@gmail.com> remove bls mul ops from benchmark subcommand Signed-off-by: garyschulte <garyschulte@gmail.com> use besu-native 1.1.1 Signed-off-by: garyschulte <garyschulte@gmail.com>

- ethereum/EIPs#8945

Remove redundant G1/G2 MUL precompiles easily replaceable with MSMs. Spec update: ethereum/EIPs#8945.

chfast requested a review from eth-bot as a code owner October 9, 2024 13:12

github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Oct 9, 2024

eth-bot added the a-review Waiting on author to review label Oct 9, 2024

jochem-brouwer reviewed Oct 9, 2024

View reviewed changes

EIPS/eip-2537.md Show resolved Hide resolved

chfast force-pushed the eip2537/remove_muls branch from bfa6096 to 40cc72d Compare October 9, 2024 18:44

chfast mentioned this pull request Oct 9, 2024

Execution Layer Meeting 198 ethereum/pm#1163

Closed

timbeiko mentioned this pull request Oct 10, 2024

EIP-2537 Breakout Call ethereum/pm#1176

Closed

cygnusv reviewed Oct 12, 2024

View reviewed changes

EIPS/eip-2537.md Outdated Show resolved Hide resolved

Marchhill mentioned this pull request Oct 15, 2024

Update EIP-2537: Added MSM and pairings precompiles without subgroup checks #8965

Closed

poojaranjan mentioned this pull request Oct 16, 2024

EIPIP Meeting 110 ethcatherders/EIPIP#361

Closed

16 tasks

poojaranjan mentioned this pull request Oct 29, 2024

EIP Editing Office Hour Meeting 46 ethcatherders/EIPIP#363

Closed

58 tasks

chfast force-pushed the eip2537/remove_muls branch from 40cc72d to 6ff64d1 Compare December 18, 2024 14:56

chfast changed the title ~~Update EIP-2537: Remove MUL precompiles~~ Update EIP-2537: Remove redundant MUL precompiles Dec 18, 2024

MarekM25 approved these changes Dec 18, 2024

View reviewed changes

MarekM25 reviewed Dec 18, 2024

View reviewed changes

Marchhill mentioned this pull request Dec 18, 2024

Bls precompiles: remove MUL NethermindEth/nethermind#7932

Draft

16 tasks

gurukamath mentioned this pull request Dec 19, 2024

Update EIP-2537 ethereum/execution-specs#1061

Open

marioevz mentioned this pull request Dec 19, 2024

new(tests): Add generic precompile-absence test ethereum/execution-spec-tests#1036

Open

8 tasks

ralexstokes approved these changes Dec 19, 2024

View reviewed changes

chfast force-pushed the eip2537/remove_muls branch from 6ff64d1 to 5f042c9 Compare December 19, 2024 17:29

eth-bot enabled auto-merge (squash) December 19, 2024 17:30

eth-bot previously approved these changes Dec 19, 2024

View reviewed changes

auto-merge was automatically disabled December 19, 2024 17:36
Head branch was pushed to by a user without write access

chfast dismissed eth-bot’s stale review via b412323 December 19, 2024 17:36

chfast force-pushed the eip2537/remove_muls branch from 5f042c9 to b412323 Compare December 19, 2024 17:36

eth-bot enabled auto-merge (squash) December 19, 2024 17:37

eth-bot approved these changes Dec 19, 2024

View reviewed changes

eth-bot merged commit eb4715f into ethereum:master Dec 19, 2024
10 checks passed

tersec mentioned this pull request Dec 19, 2024

devnet-5 readiness status-im/nimbus-eth1#2942

Open

10 tasks

chfast mentioned this pull request Dec 19, 2024

chore(tests): EIP-2537: remove BLS MUL precompiles (MVP) ethereum/execution-spec-tests#1039

Merged

8 tasks

garyschulte added a commit to garyschulte/besu that referenced this pull request Dec 19, 2024

remove MUL per ethereum/EIPs#8945

1e3d865

Signed-off-by: garyschulte <garyschulte@gmail.com>

garyschulte added a commit to garyschulte/besu that referenced this pull request Dec 19, 2024

remove MUL per ethereum/EIPs#8945

5c735e0

Signed-off-by: garyschulte <garyschulte@gmail.com>

garyschulte mentioned this pull request Dec 19, 2024

release version 1.1.0 hyperledger/besu-native#229

Merged

garyschulte added a commit to garyschulte/besu that referenced this pull request Dec 20, 2024

remove MUL per ethereum/EIPs#8945

f234cfa

Signed-off-by: garyschulte <garyschulte@gmail.com>

garyschulte added a commit to garyschulte/besu that referenced this pull request Dec 20, 2024

remove MUL per ethereum/EIPs#8945

72d2f6a

Signed-off-by: garyschulte <garyschulte@gmail.com>

garyschulte added a commit to garyschulte/besu that referenced this pull request Dec 20, 2024

remove MUL per ethereum/EIPs#8945

76540dc

Signed-off-by: garyschulte <garyschulte@gmail.com>

gurukamath added a commit to gurukamath/execution-specs that referenced this pull request Dec 20, 2024

remove MUL pre-compiles from BLS

af33227

- ethereum/EIPs#8945

gurukamath mentioned this pull request Dec 20, 2024

EELS Update EIP-2537: Remove redundant MUL precompiles ethereum/execution-specs#1063

Merged

gurukamath added a commit to gurukamath/execution-specs that referenced this pull request Dec 20, 2024

remove MUL pre-compiles from BLS

186e493

- ethereum/EIPs#8945

chfast mentioned this pull request Dec 20, 2024

Updates to BLS precompiles (EIP-2537) ethereum/evmone#1089

Draft

chfast added a commit to ethereum/evmone that referenced this pull request Dec 20, 2024

precompiles: Remove redundant BLS MUL precompiles

6e214c6

Remove redundant G1/G2 MUL precompiles easily replaceable with MSMs. Spec update: ethereum/EIPs#8945.

This was referenced Dec 22, 2024

Remove obsolete precompiles from EIP 2537 ethereumjs/ethereumjs-monorepo#3823

Open

Implement pectra devnet-5 spec ethereumjs/ethereumjs-monorepo#3807

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update EIP-2537: Remove redundant MUL precompiles #8945

Update EIP-2537: Remove redundant MUL precompiles #8945

chfast commented Oct 9, 2024 •

edited

Loading

eth-bot commented Oct 9, 2024 •

edited

Loading

jochem-brouwer left a comment

ralexstokes commented Oct 9, 2024

cygnusv left a comment

asanso commented Oct 12, 2024

chfast commented Dec 18, 2024

MarekM25 Dec 18, 2024

ralexstokes Dec 19, 2024

ralexstokes Dec 19, 2024

ralexstokes left a comment

chfast commented Dec 19, 2024

ralexstokes commented Dec 19, 2024

eth-bot left a comment

eth-bot left a comment

		@@ -277,10 +251,12 @@ MSMs are expected to be performed by Pippenger's algorithm (we can also say that

		To avoid non-integer arithmetic, the call cost is calculated as `(k * multiplication_cost * discount) / multiplier` where `multiplier = 1000`, `k` is a number of (scalar, point) pairs for the call, `multiplication_cost` is a corresponding single multiplication call cost for G1/G2.

Update EIP-2537: Remove redundant MUL precompiles #8945

Update EIP-2537: Remove redundant MUL precompiles #8945

Conversation

chfast commented Oct 9, 2024 • edited Loading

eth-bot commented Oct 9, 2024 • edited Loading

jochem-brouwer left a comment

Choose a reason for hiding this comment

ralexstokes commented Oct 9, 2024

cygnusv left a comment

Choose a reason for hiding this comment

asanso commented Oct 12, 2024

chfast commented Dec 18, 2024

MarekM25 Dec 18, 2024

Choose a reason for hiding this comment

ralexstokes Dec 19, 2024

Choose a reason for hiding this comment

ralexstokes Dec 19, 2024

Choose a reason for hiding this comment

ralexstokes left a comment

Choose a reason for hiding this comment

chfast commented Dec 19, 2024

ralexstokes commented Dec 19, 2024

eth-bot left a comment

Choose a reason for hiding this comment

eth-bot left a comment

Choose a reason for hiding this comment

chfast commented Oct 9, 2024 •

edited

Loading

eth-bot commented Oct 9, 2024 •

edited

Loading