Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-7691: Move to Review #9095

Merged
merged 6 commits into from
Dec 18, 2024
Merged

Update EIP-7691: Move to Review #9095

merged 6 commits into from
Dec 18, 2024

Conversation

timbeiko
Copy link
Contributor

@timbeiko timbeiko commented Dec 5, 2024

Currently blocking #9094

@timbeiko timbeiko marked this pull request as ready for review December 5, 2024 18:25
@timbeiko timbeiko requested a review from eth-bot as a code owner December 5, 2024 18:25
@github-actions github-actions bot added c-status Changes a proposal's status s-review This EIP is in Review t-core labels Dec 5, 2024
@timbeiko timbeiko mentioned this pull request Dec 5, 2024
Merged
@eth-bot
Copy link
Collaborator

eth-bot commented Dec 5, 2024 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot added the a-review Waiting on author to review label Dec 5, 2024
@eth-bot eth-bot changed the title Update eip-7691.md Update EIP-7691: Move to Review Dec 5, 2024
@poojaranjan poojaranjan mentioned this pull request Dec 10, 2024
Closed
15 tasks
SamWilsn
SamWilsn requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to replace the <!-- todo --> comments with the actual values before moving into Review.

@timbeiko
Copy link
Contributor Author

@SamWilsn that comment was for the fork block, which we don't include until it gets set in ACD. Is the PR now OK to merge? Want to make sure we can properly reflect the Pectra scope in #9094

g11tech
g11tech previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we need to have another tag to track things to be filled before moving to final

may be <-- TBA --> or <-- TBF --> can be used to move to review

@eth-bot eth-bot enabled auto-merge (squash) December 17, 2024 09:04
eth-bot
eth-bot previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

auto-merge was automatically disabled December 18, 2024 18:53

Head branch was pushed to by a user without write access

@timbeiko timbeiko dismissed stale reviews from eth-bot and g11tech via e46da57 December 18, 2024 18:53
SamWilsn
SamWilsn previously approved these changes Dec 18, 2024
View reviewed changes
SamWilsn
SamWilsn approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess PECTRA_FORK_EPOCH can stay undefined 🤣

@eth-bot eth-bot enabled auto-merge (squash) December 18, 2024 18:59
eth-bot
eth-bot approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 1da6c75 into ethereum:master Dec 18, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eth-bot eth-bot eth-bot approved these changes

@SamWilsn SamWilsn SamWilsn approved these changes

@parithosh parithosh parithosh approved these changes

@g11tech g11tech g11tech left review comments

Assignees
No one assigned
Labels
a-review Waiting on author to review c-status Changes a proposal's status s-review This EIP is in Review t-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@timbeiko @eth-bot @parithosh @SamWilsn @g11tech