Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-7251: fix CONSOLIDATION_REQUEST_PREDEPLOY_ADDRES #9118

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

protolambda
Copy link
Contributor

Fixes the address.

Verified with: https://gist.github.com/protolambda/58f73421b91602a6a0f5104a9f0f5c89

The CONSOLIDATION_REQUEST_PREDEPLOY_ADDRESS now matches the address in the bytecode deployment section again.

@protolambda protolambda requested a review from eth-bot as a code owner December 9, 2024 14:19
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Dec 9, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Dec 9, 2024

✅ All reviewers have approved.

@eth-bot eth-bot added the a-review Waiting on author to review label Dec 9, 2024
@eth-bot eth-bot enabled auto-merge (squash) December 9, 2024 14:30
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 1df873f into ethereum:master Dec 9, 2024
10 checks passed
jangko added a commit to status-im/nimbus-eth1 that referenced this pull request Dec 19, 2024
[Update EIP-7251: Set MAX_CONSOLIDATIONS=2](ethereum/EIPs#9127)
will override
[Update EIP-7251: fix CONSOLIDATION_REQUEST_PREDEPLOY_ADDRES](ethereum/EIPs#9118)
therefore we only need the later.
tersec pushed a commit to status-im/nimbus-eth1 that referenced this pull request Dec 19, 2024
…2956)

* devnet-5: fix Consolidation and Withdrawal request predeploy address

[Update EIP-7251: Set MAX_CONSOLIDATIONS=2](ethereum/EIPs#9127)
will override
[Update EIP-7251: fix CONSOLIDATION_REQUEST_PREDEPLOY_ADDRES](ethereum/EIPs#9118)
therefore we only need the later.

* Fix test vectors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-review This EIP is in Review t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants