Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-7702: Add security consideration about use of storage #9136

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Update EIP-7702: Add security consideration about use of storage #9136

merged 5 commits into from
Dec 16, 2024

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Dec 14, 2024

Also applies a minor suggestion posted in #8969 after it was merged.

@frangio frangio requested a review from eth-bot as a code owner December 14, 2024 17:18
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Dec 14, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Dec 14, 2024 •
edited
Loading

File EIPS/eip-7702.md

Requires 1 more reviewers from @adietrichs, @lightclient, @SamWilsn, @vbuterin

@eth-bot eth-bot added the a-review Waiting on author to review label Dec 14, 2024
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Dec 14, 2024
@github-actions GitHub Actions
Copy link

The commit 9542103 (as a parent of fa2d00f) contains errors.
Please inspect the Run Summary for details.

@frangio
Copy link
Contributor Author

frangio commented Dec 14, 2024

This is unfortunately tripping into linting/CI errors from the EIP to ERC migration.

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Dec 15, 2024
lightclient
lightclient reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@lightclient lightclient mentioned this pull request Dec 16, 2024
Merged
@lightclient lightclient merged commit b2bed42 into ethereum:master Dec 16, 2024
10 checks passed
@frangio frangio deleted the 7702-security-storage branch December 16, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightclient lightclient lightclient left review comments

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Assignees
No one assigned
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-review This EIP is in Review t-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frangio @eth-bot @lightclient