Update EIP-1: Add changes on top of Sam's changes. #9151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oof-ofStake Consensus Specifications`.
File
|
eth-bot
changed the title
SamWilsn
reviewed
Dec 18, 2024
| ``` | ||
|
|
||
| Which renders as: | ||
|
|
||
| [HTML](https://html.spec.whatwg.org/commit-snapshots/578def68a9735a1e36610a6789245ddfc13d24e0/) | ||
| [HTML](https://html.spec.whatwg.org/commit-snapshots/578def68a9735a1e36610a6789245ddfc13d24e0) |
There was a problem hiding this comment.
The canonical location of this document has the trailing slash. Why remove it? Similarly, why remove it everywhere else?
There was a problem hiding this comment.
The idea was to being consistent to all URLs. (Either all with trailing slash, or all without trailing slash.)
Because trailing slashes do not (unless I'm mistaken) bring any information, I chose to remove them all.
|
The commit ba497de (as a parent of 32bf582) contains errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read commit by commit.