This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
Returndatacopy throws when offset+size is bigger than the size of returndata buffer #4124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
approved these changes
Jun 8, 2017
libevm/VM.cpp
Outdated
| @@ -763,6 +763,9 @@ void VM::interpretCases() | |||
| { | |||
| if (!m_schedule->haveReturnData) | |||
| throwBadInstruction(); | |||
| bigint const endOfAccess{bigint(m_SP[1]) + bigint(m_SP[2])}; | |||
There was a problem hiding this comment.
I would avoid explicit constructor here to still pretend bigint works like regular int.
bigint const endOfAccess = bigint(m_SP[1]) + bigint(m_SP[2]);
There was a problem hiding this comment.
Let me pretend that way.
Codecov Report
@@ Coverage Diff @@
## develop #4124 +/- ##
===========================================
- Coverage 65.7% 65.69% -0.01%
===========================================
Files 303 303
Lines 22999 23008 +9
===========================================
+ Hits 15112 15116 +4
- Misses 7887 7892 +5
|
|
Yes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the change in the EIP.