This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
New modexp cost #4278
Merged
New modexp cost #4278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4278 +/- ##
===========================================
+ Coverage 67.36% 67.42% +0.06%
===========================================
Files 306 306
Lines 23472 23478 +6
===========================================
+ Hits 15812 15831 +19
+ Misses 7660 7647 -13
|
|
No unit tests change was needed - it means they cover only the case for mod & base length <=64. Could we add tests for other two cases? |
gumb0
reviewed
Jul 24, 2017
libethcore/Precompiled.cpp
Outdated
| @@ -160,6 +160,16 @@ namespace | |||
| return 8 * (_expLength - 32) + highestBit; | |||
| } | |||
| } | |||
|
|
|||
| bigint mult_complexity(bigint const& _x) | |||
pirapira
force-pushed
the
new_modexp_cost
branch
from
a344b69 to
913d3ca
Compare
|
Right, the unit tests are only for very small, or very large |
|
I added unit tests for the other two cases. |
gumb0
approved these changes
Jul 25, 2017
|
AppVeyor build is failing and somehow I cannot restart AppVeyor. |
|
The tests around |
17 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the new cost formula ethereum/EIPs@4d4d8fb for modexp precompiled contract.