This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
renaming calls to include a subprotocol prefix #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| the Free Software Foundation, either version 3 of the License, or | ||
| (at your option) any later version. | ||
|
|
||
| ethereum.js is distributed in the hope that it will be useful, | ||
| but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| GNU General Public License for more details. | ||
| GNU Lesser General Public License for more details. |
There was a problem hiding this comment.
it's only for these 2 js files
|
Does qt not support binding a nested object? Ex: bind web3.eth to an Eth interface, web3.shh to Shh interface, etc. Then we would have 3 flush and consistent interfaces. |
|
To my knowledge, it does not support. The only way to bind nested object is to run javascript. And right now, we are sharing interface with go client (ethereum.js). Using Qt binding it would be much harder to achieve. |
gavofyork
pushed a commit
that referenced
this pull request
Nov 10, 2014
renaming calls to include a subprotocol prefix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsonrpc calls are now having prefixes so we can easily segment the interface.
restore web3.eth.lll