This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
Alternative code in aleth-interpreter SSTORE #5240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
commented
Sep 3, 2018
libaleth-interpreter/VM.cpp
Outdated
| } | ||
| else | ||
| { | ||
| auto const status = |
There was a problem hiding this comment.
We could also charge sstoreUnchangedGas upfront similar to pre-Constantinople way, but maybe it doesn't make much sense because doesn't prevent extra writes to DB
Codecov Report
@@ Coverage Diff @@
## net-sstore-interpreter #5240 +/- ##
=========================================================
- Coverage 61.01% 61% -0.02%
=========================================================
Files 338 338
Lines 27649 27652 +3
Branches 3203 3205 +2
=========================================================
- Hits 16871 16868 -3
- Misses 9649 9653 +4
- Partials 1129 1131 +2 |
chfast
force-pushed
the
net-sstore-interpreter
branch
from
6b50a69
to
02746a1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe this version is better, not sure.