Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Upgrade Hunter to 0.23.211 to enable use of Visual Studio 2017 #5719

Merged
merged 3 commits into from
Aug 19, 2019

Conversation

halfalicious
Copy link
Contributor

Fix #5516

Upgrade Hunter to get YAML-CPP fix which enables use of Visual Studio
2017 to build Aleth. Notable package updates are:

  • YAML-CPP (0.6.2-p0 -> 0.6.2-p1)
  • ethash (0.4.4 -> 0.5.0)

Upgrade Hunter to 0.23.211 get YAML-CPP fix which enables use of Visual Studio
2017 to build Aleth. Notable package updates are:
* YAML-CPP (0.6.2-p0 -> 0.6.2-p1)
* ethash (0.4.4 -> 0.5.0)
@codecov-io
Copy link

Codecov Report

Merging #5719 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5719      +/-   ##
==========================================
- Coverage   63.11%   63.09%   -0.02%     
==========================================
  Files         353      353              
  Lines       30193    30193              
  Branches     3386     3386              
==========================================
- Hits        19056    19051       -5     
- Misses       9901     9906       +5     
  Partials     1236     1236

Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. What was blocking VS 2017 before?

@chfast chfast merged commit 0618887 into master Aug 19, 2019
@halfalicious
Copy link
Contributor Author

halfalicious commented Aug 19, 2019

Great. What was blocking VS 2017 before?

@chfast Good question 😀 From #5516 (comment):

I believe this will be fixed by upgrading Hunter to the latest version (v0.23.211) (archive link) - the reason that the dependencies fail to build when generating the VS 2017 solution is because YAML-CPP has a workaround for VS's lack of noexcept which uses a token that's no longer present on VS2017 >= 15.8 (_NOEXCEPT). This was fixed in YAML-CPP release 0.6.2-p1 (fix commit), but the version of Hunter that Aleth currently uses (0.23.178) only has YAML-CPP version 0.6.2-p0.

@chfast chfast deleted the upgrade-hunter branch August 19, 2019 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails on Windows because yaml-cpp fails to build
4 participants