Make sync committee type conform to spec #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpetrunic
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The altair response schema for https://ethereum.github.io/eth2.0-APIs/#/Debug/getStateV2 fields
current_sync_committeeandnext_sync_committeeare not in line with the spec.pubkeyslength is 1024 andpubkey_aggregatesis an array, whereas https://github.com/ethereum/eth2.0-specs/blob/dev/specs/altair/beacon-chain.md#synccommittee specifiespubkeysof length 512 (SYNC_COMMITTEE_SIZE) and anaggregate_pubkeyfield which is a single public key.