Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that SSE keepalive is permitted #172

Merged
merged 2 commits into from
Oct 8, 2021
Merged

Clarify that SSE keepalive is permitted #172

merged 2 commits into from
Oct 8, 2021

Conversation

michaelsproul
Copy link
Collaborator

As per discussion on the Lighthouse issue tracker and Discord, clarify that event stream servers may send comments, particularly for keep-alive messages.

@michaelsproul michaelsproul mentioned this pull request Oct 7, 2021
Closed
ajsutton
ajsutton previously approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd almost be tempted to make this a should publish and specify a time so that VCs can know to set a reasonable timeout but given most chains have a head event every 12 seconds or so probably not that big a deal.

@michaelsproul
Copy link
Collaborator Author

michaelsproul commented Oct 7, 2021 •
edited
Loading

The CI breakage seems to be related to an update to the Spectral linter, which recently removed the operation-default-response rule: https://meta.stoplight.io/docs/spectral/ZG9jOjg2MDIwMDM-spectral-v5-to-v6-migration-guide#removed

I've deleted it in a separate commit

@mpetrunic mpetrunic merged commit 22b0d75 into ethereum:master Oct 8, 2021
@michaelsproul michaelsproul deleted the sse-keepalive branch October 8, 2021 09:59
@michaelsproul michaelsproul mentioned this pull request Oct 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mirage1348 Mirage1348 Mirage1348 approved these changes

@mpetrunic mpetrunic mpetrunic approved these changes

@ajsutton ajsutton ajsutton left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelsproul @ajsutton @mpetrunic @Mirage1348