-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup old endpoints that have been deprecated #218
Conversation
- v1/debug/states has been deprecated for a long time now, as has the v1/blocks endpoint. - v1/debug/heads seems to be a new deprecation so leaving that in the spec. I'm not sure why v2 exists, it looks like the execution_optimistic should have just been optional so that it was non breaking, but that horse hs bolted.
/eth/v1/beacon/blocks: | ||
$ref: "./apis/beacon/blocks/blocks.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should have been deleted. This API endpoint isn't deprecated and is the only way for validator clients to publish their non-blinded blocks to the beacon node
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hrm i may have deleted the wrong thing? will check now...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're correct, raising a pr to put back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Mistakenly removed in ethereum#218, this PR puts back the /eth/v1/beacon/blocks POST.
* Added POST /eth/v1/beacon/blocks back in place Mistakenly removed in #218, this PR puts back the /eth/v1/beacon/blocks POST. * Update beacon-node-oapi.yaml Co-authored-by: Michael Sproul <micsproul@gmail.com> Co-authored-by: Michael Sproul <micsproul@gmail.com>
v1/debug/states has been deprecated for a long time now, as has the v1/blocks endpoint.
v1/debug/heads seems to be a new deprecation so leaving that in the spec. I'm not sure why v2 exists, it looks like the execution_optimistic should have just been optional so that it was non breaking, but that horse hs bolted.