Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata fields to getBlobSidecars response #441

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

nflaig
Copy link
Collaborator

@nflaig nflaig commented Apr 11, 2024

As noted in #439 and after further discussion on discord, the rough consensus seems to be to add those metadata fields without bumping the api version, but to make them optional for now until all clients have updated their implementation.

Closes #439

Copy link
Collaborator

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nflaig nflaig merged commit 5bbd01e into ethereum:master Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getBlobSidecars is missing metadata fields in response
3 participants