-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use LIB_PREFIX in Rust bindings #317
Conversation
Is this still WIP? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I don't love the new macros, but it's probably the best option we have. This PR is a good tradeoff of usability & minor changes to the codebase post-audit. I made a commit that fixes clang-format's complaints and alters the comments a little to match the style of others. The CI check that is failing is a known problem which we can ignore for now. LGTM 👍
Still WIP on the Lighthouse integration unfortunately. We've hit a few linking issues that look like they might require further changes |
Ok, we've got it working reliably in Lighthouse now. I've pushed two commits here that seemed to help:
|
I added the generated bindings to the source to be able to see them. So I don't think anyone else has an attachment to that setup. I'm fine with moving them to the build dir |
Hey @michaelsproul I made a PR to your branch (michaelsproul#1) with some changes I'd like to make. I think this will simplify things a bit, but there were a lot of changes so I didn't feel comfortable committing them directly. Thoughts? Also, tag @asn-d6 since this is based on your original PR. |
Going to merge. I believe it's ready 👍 |
Extension of #313 to the Rust bindings.