Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use boxes & refs in Rust bindings #325

Closed
wants to merge 8 commits into from

Conversation

jtraglia
Copy link
Member

@jtraglia jtraglia commented Jul 7, 2023

This PR fixes the issue with Windows & should be overall more efficient.

  • When dealing with individual blobs, box them (store them on the heap).
    • This fixes the segmentation fault crash on Windows on 4844-devnet-7.
    • My theory is that these (relatively large) blobs were overflowing the stack.
  • For all of the KZG interface functions, take references.
    • I feel like this should have done this a while ago.
    • It should be more efficient as it saves us from cloning.

Note, this does not fix the benchmark issue on Windows:

@jtraglia
Copy link
Member Author

Actually, dang. Hold off on reviewing this. This PR still has the Windows segfault issue on 4844-devnet-7. I'll need to look into why the "boxed-blobs" branch works and this one doesn't.

@jtraglia
Copy link
Member Author

Still unable to get this working. Will re-open if something changes.

@jtraglia jtraglia closed this Jul 27, 2023
@jtraglia jtraglia deleted the boxes-and-refs branch August 1, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant