Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve python bindings build/install flow #460

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Improve python bindings build/install flow #460

merged 1 commit into from
Jul 24, 2024

Conversation

jtraglia
Copy link
Member

This PR updates the Python build/install flow to use python -m build and pip instead of setuptools.

@asn-d6
Copy link
Contributor

asn-d6 commented Jul 19, 2024 

❯ python3 -m build                                                                       
/usr/bin/python3: No module named build.__main__; 'build' is a package and cannot be directly executed

Hm... What am I missing?

@jtraglia
Copy link
Member Author

Weird. I'm not sure. Looks like it's installed incorrectly somehow.

asn-d6
asn-d6 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@asn-d6 asn-d6 merged commit 4fe9508 into ethereum:main Jul 24, 2024
38 checks passed
@jtraglia jtraglia deleted the better-python-install branch August 1, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asn-d6 asn-d6 asn-d6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtraglia @asn-d6