Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove benchmarks for Rust & Java #476

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

jtraglia
Copy link
Member

@jtraglia jtraglia commented Aug 8, 2024

Remove benchmarks in the Rust and Java bindings. This is mostly a maintenance issue. I would rather delete them than update them for EIP-7594. In my opinion, these benchmarks don't provide that much extra value.

Now, there will only be benchmarks in the Go bindings.

Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using the rust benchmarks, but I totally get the point about maintainance costs. I will start using the go benchmarks from now on.

LGTM! Thanks!

@jtraglia jtraglia merged commit f7cdb8f into ethereum:main Aug 8, 2024
38 checks passed
@jtraglia jtraglia deleted the remove-rust-and-java-benchmarks branch August 8, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants