Enable more compiler warnings #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR does not build on my Linux system. |
|
I'm actually using Apple's clang. They have their own fork if I understand correctly. What are the issues? |
|
The issues were an artifact of a separate build system issue. Will address on another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So once again, I feel like I've been tricked by the compiler. I thought that
-Wall -Wextrawas everything, but it's not.This PR enables these warnings & fixes the issues. The most noticeable change is probably the due to the implicit conversions from
uint64_ttouint32_ttointetc that we were doing. Rather than dealing with conversions, we can useuint64_tin these places. I actually like this better & think we should have done this from the beginning.See this link for a list of flags. Not all of them are listed here 🤷
https://gcc.gnu.org/onlinedocs/gcc-4.4.0/gcc/Warning-Options.html#Warning-Options