Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/epoch length #114

Merged
merged 5 commits into from
Apr 26, 2018
Merged

Bugfix/epoch length #114

merged 5 commits into from
Apr 26, 2018

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Apr 26, 2018 •
edited
Loading

Addresses #83

Implementation

  • add assertion in __init__
  • Move all of casper_config to separate fixtures that can be override in testing
  • add deploy_casper_contract(args) fixture to be able to test deploying casper with different args
  • add tests

@djrtwo djrtwo requested a review from ChihChengLiang April 26, 2018 13:22
ChihChengLiang
ChihChengLiang approved these changes Apr 26, 2018
View reviewed changes
Copy link
Contributor

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djrtwo djrtwo merged commit 71c63b2 into ethereum:master Apr 26, 2018
@djrtwo djrtwo deleted the bugfix/epoch-length branch April 26, 2018 14:13
@djrtwo djrtwo mentioned this pull request Apr 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChihChengLiang ChihChengLiang ChihChengLiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djrtwo @ChihChengLiang