Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify voluntary_exits gossip topic after Capella #3638

Closed
zilm13 opened this issue Mar 30, 2024 · 3 comments · Fixed by #3651
Closed

Clarify voluntary_exits gossip topic after Capella #3638

zilm13 opened this issue Mar 30, 2024 · 3 comments · Fixed by #3651

Comments

@zilm13
Copy link
Contributor

zilm13 commented Mar 30, 2024

I read the spec as topic is fixed to Capella after Capella:
https://github.com/ethereum/consensus-specs/blob/dev/specs/deneb/p2p-interface.md?plain=1#L121
While EIP-7044 is not clear on this.
Do we use current fork topic for gossip or Capella in Deneb and after?

@dapplion
Copy link
Collaborator

dapplion commented Apr 1, 2024

I understand it's current fork for symmetry with all other topics

@zilm13
Copy link
Contributor Author

zilm13 commented Apr 1, 2024

@dapplion we do the same but "due to the lock-in use of CAPELLA_FORK_VERSION" confuses me. At least would be good to confirm, that all clients are using Deneb fork id for exits gossip topic on Deneb.
We had few reports on no peers for this topic. I'd rephrase spec to "despite of" if we do the same job (changing topic for a new fork) as always.

@g11tech
Copy link
Contributor

g11tech commented Apr 4, 2024

yes as per lodestar impl, only the signature fork domain stays fixed while current topic is used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants