Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify voluntary_exits gossip topic after Capella #3651

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

zilm13
Copy link
Contributor

@zilm13 zilm13 commented Apr 4, 2024

Could we change wording here a bit, please. "Due to" sounds close to 'because of" and is a bit confusing, because we use CAPELLA_FORK for the signature domain but we don't lock the topic, we change it like we always do on every new fork - update topics for all objects to be derived from the current fork.
Should fix #3638

Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds great, thanks!

@ralexstokes ralexstokes merged commit 29a3cbb into ethereum:dev Apr 4, 2024
32 checks passed
@zilm13 zilm13 deleted the exits-deneb-fork branch April 5, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify voluntary_exits gossip topic after Capella
2 participants