Terminal blockhash override #2599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwwhww
reviewed
Sep 15, 2021
mkalinin
reviewed
Sep 15, 2021
djrtwo
reviewed
Sep 15, 2021
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2 tasks
|
closing in favor of adding a constant as in #2605 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a terminal block hash override for the merge fork as originally discussed here.
I'm creating this PR as a starting point for discussion while acknowledging that this might be somewhat controversial (more so than the total difficulty override) because coordinating on a specific blockhash might be perceived as more 'political'.