use correct timestamp for empty ExecutionPayload #2638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two similar functions to compute the timestamp for a given beacon chain slot. `compute_time_at_slot` is used for processing Eth1 votes, and does not take into account `GENESIS_TIME`. The other one, `compute_timestamp_at_slot`, is used everywhere else. When processing `ExecutionPayload`, the `merge/beacon-chain.md` spec uses the latter, `compute_timestamp_at_slot`, to verify the timestamp. However, in the test code, `build_empty_execution_payload` uses `compute_time_at_slot`. This patch changes the test to use the same function for creating the timestamp that is later used to verify it. Note that `GENESIS_TIME` is 0 so there is no practical difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two similar functions to compute the timestamp for a given
beacon chain slot.
compute_time_at_slotis used for processing Eth1votes, and does not take into account
GENESIS_TIME. The other one,compute_timestamp_at_slot, is used everywhere else. When processingExecutionPayload, themerge/beacon-chain.mdspec uses the latter,compute_timestamp_at_slot, to verify the timestamp. However, in thetest code,
build_empty_execution_payloadusescompute_time_at_slot.This patch changes the test to use the same function for creating the
timestamp that is later used to verify it. Note that
GENESIS_TIMEis 0so there is no practical difference.