validator status cleanup #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
actually still have a couple of cleanups to do and will handle merge conflict @JustinDrake. I'll ping for review |
|
okay, now this is ready for review @JustinDrake @hwwhww |
JustinDrake
approved these changes
Dec 11, 2018
hwwhww
reviewed
Dec 11, 2018
specs/core/0_beacon-chain.md
Outdated
| @@ -998,6 +1011,10 @@ def integer_squareroot(n: int) -> int: | |||
| return x | |||
| ``` | |||
|
|
|||
| #### `BLSVerify` | |||
|
|
|||
| `BLSVerify` is a function for verifying a BLS12-381 signature, defined in the [BLS12-381 spec](https://github.com/ethereum/eth2.0-specs/blob/master/specs/bls_verify.md). | |||
There was a problem hiding this comment.
Ah, I thought BLS Verification spec is "Boneh-Lynn-Shacham signatures verification" because it's not talking about the details of the curve, no?
There was a problem hiding this comment.
Well that doc is doing a BLS signature verification for a specific BLS12-381 curve
There was a problem hiding this comment.
renamed spec ref to "BLS Verification spec"
arnetheduck
reviewed
Dec 13, 2018
| Activate the validator with the given ``index``. | ||
| Note that this function mutates ``state``. | ||
| """ | ||
| if validator.status != PENDING_ACTIVATION: |
There was a problem hiding this comment.
need some proof-reading here - validator does not yet exist ;)
arnetheduck
reviewed
Dec 13, 2018
| validator.status = ACTIVE | ||
| validator.latest_status_change_slot = state.slot | ||
| state.validator_registry_delta_chain_tip = get_new_validator_registry_delta_chain_tip( | ||
| validator_registry_delta_chain_tip=validator_registry_delta_chain_tip, |
There was a problem hiding this comment.
likewise - where's the chain tip coming from?
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #274 and #268
process_depositand normal activation to better reuse code and ensure that thevalidator_registry_delta_chainis builtupdate_validator_statusexit_validatoris no longer used for changingACTIVE->ACTIVE_PENDING_EXITexit_validatoronly removes validator frompersistent_committeesand updatesvalidator_registry_delta_chainif not previously already exitedNot addressed but worth noting here:
process_depositthat said deposits from 1.0 should be processed in order as they were submit in the 1.0 chain, but there is no mechanism in "per-slot - deposits" to ensure this validity when processing a block. This needs to be considered more and handled in another PR. theDepositobject might need asourcefield (to distinguish 1.0 vs 2.0 deposits) and theBeaconStatemight need to remember the last deposit hash processed from the 1.0 chain.