Ensure light client optimistic_header to be at head
#2814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a light client updates its `finalized_header` using a forced update because of the timeout, and the new header was not signed by enough sync committee participants to pass `get_safety_threshold(store)`, it may occur that `store.finalized_header.slot > store.optimistic_header.slot`. This patch ensures that the `optimistic_header` is updated to the latest `finalized_header` if that happens, so that it always indicates the latest known and accepted head.
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Mar 15, 2022
Adds the additional check to ensure `optimistic_header` is always after `finalized_header` in `LightClientStore`, as introduced to the spec in ethereum/consensus-specs#2814
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Mar 15, 2022
Adds the additional check to ensure `optimistic_header` is always after `finalized_header`, as introduced to the spec in: ethereum/consensus-specs#2814
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Mar 16, 2022
Adds the additional check to ensure `optimistic_header` is always after `finalized_header` in `LightClientStore`, as introduced to the spec in ethereum/consensus-specs#2814
18 tasks
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a light client updates its
finalized_headerusing a forced updatebecause of the timeout, and the new header was not signed by enough sync
committee participants to pass
get_safety_threshold(store), it mayoccur that
store.finalized_header.slot > store.optimistic_header.slot.This patch ensures that the
optimistic_headeris updated to the latestfinalized_headerif that happens, so that it always indicates thelatest known and accepted head.